nodes/malkuthro-ComfyUI-Koolook
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
kflame-paste-path-browse
malkuthro-ComfyUI-Koolook/forks
T
History
malkuthroandClaude Opus 4.7 1bde57bf4e docs: fix stale fork READMEs + replace outdated copilot-instructions (#115) 
* docs: fix stale fork READMEs + retire outdated copilot-instructions

forks/README.md and forks/radiance_koolook/README.md both still pointed at
v1_0_1 as the active version — v1_0_1 was removed in v0.1.5; the only active
fork is v2_3_3. Layout examples and the Upgrade Flow Example pivot forward
(v2_3_3 → hypothetical v2_4_0), with a note about SKIP_VERSION_SUFFIX for
stable user-facing IDs across upgrades.

.github/copilot-instructions.md was severely out of date — referenced a
nonexistent k_easy_version.py, knew nothing about the Kforge Labs sidebar
(now the main feature), and had no mention of koolook_routes.py, dev-sync,
or the three-axis versioning model. Replaced with a thin pointer to
CLAUDE.md plus the high-stability orientation Copilot needs to place a
request before following links — file map, "things that bite", redirect.

Nice-to-have follow-ups filed as #113 (markdown mirror of the visual
sidebar guide) and #114 (small cross-ref / glossary polish).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(forks): fix v2.3.3 namespace-suffix bullet in THIRD_PARTY.md

The bullet claimed all exposed v2.3.3 node IDs are namespaced with
`__koolook_v2_3_3`, but both currently-registered IDs (`Easy_hdr_VAE_encode`,
`Easy_hdr_VAE_decode`) are Koolook-original names that opt out via
`SKIP_VERSION_SUFFIX` in versions/v2_3_3/__init__.py. The new wording
names the actual exposed IDs, points at the opt-out set, and explains
the reserved use of the `__koolook_v2_3_3` suffix for future ports of
upstream-named classes.

Caught in PR #115 review — the linked target (THIRD_PARTY.md) was
contradicting the new forks/README.md and CLAUDE.md text on the same
mechanism.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-08 22:09:55 +02:00
..
radiance_koolook
docs: fix stale fork READMEs + replace outdated copilot-instructions (#115)
2026-05-08 22:09:55 +02:00
__init__.py
Restructure fork tracking and versioned Radiance layout.
2026-04-24 15:45:04 +02:00
forks_manifest.yaml
docs(forks): finalize de-vendoring audit trail (closes #28) (#55)
2026-05-04 20:41:47 +02:00
README.md
docs: fix stale fork READMEs + replace outdated copilot-instructions (#115)
2026-05-08 22:09:55 +02:00
THIRD_PARTY.md
docs: fix stale fork READMEs + replace outdated copilot-instructions (#115)
2026-05-08 22:09:55 +02:00

README.md

Forks Workflow

This folder is the single source for all fork tracking metadata inside MAIN.

Purpose

  • Keep modified forked code in MAIN under versioned paths (for GitHub tracking).
  • Keep raw external checkouts outside MAIN under ../ComfyUI-Forks (for upstream reference/sync).
  • Keep all fork metadata in one place:
    • forks/forks_manifest.yaml
    • forks/THIRD_PARTY.md

Folder Layout in MAIN

  • forks/radiance_koolook/__init__.py -> package entrypoint used by root __init__.py
  • forks/radiance_koolook/versions/v2_3_3/ -> local modified node sources (currently the only active version)
  • forks/radiance_koolook/versions/<version>/UPSTREAM_PIN.yaml -> exact upstream parity pin

The earlier v1_0_1 fork was removed in v0.1.5 — see THIRD_PARTY.md for the rationale and recovery instructions.

External Folder Naming (outside MAIN)

Root: ../ComfyUI-Forks

  • Pinned baseline checkout:
    • radiance-v2.3.3-koolook
  • Rolling upstream checkout:
    • radiance-main-upstream

These names are referenced from forks/forks_manifest.yaml.

Referencing System

For each fork entry in forks/forks_manifest.yaml:

  • source_repo = canonical upstream URL
  • source_ref = release/tag (or baseline descriptor)
  • pinned_commit = exact reproducible commit hash
  • external_checkout.relative_path_from_forks_root = pinned raw reference folder
  • external_checkout.upstream_tracking_path_from_forks_root = rolling upstream folder
  • local_paths = files tracked in MAIN

Tagging Policy (from now on)

  • MAIN repo tags use SemVer: vMAJOR.MINOR.PATCH.
  • Local fork version folders use underscore variant of the same version:
    • v2_3_3, v2_4_0, etc.
  • Node mapping namespace suffixes must match folder versions:
    • __koolook_v2_3_3, __koolook_v2_4_0, etc.
  • Some node IDs opt out of the suffix via SKIP_VERSION_SUFFIX (see forks/radiance_koolook/versions/v2_3_3/__init__.py) to keep stable user-facing IDs across upgrades.
  • Keep source_ref + pinned_commit in forks/forks_manifest.yaml and UPSTREAM_PIN.yaml.

Upgrade Flow Example (Radiance)

Hypothetical bump from the current v2_3_3 to a future v2_4_0:

  1. Compare current local version (forks/radiance_koolook/versions/v2_3_3) with pinned raw baseline (../ComfyUI-Forks/radiance-v2.3.3-koolook).
  2. Pull latest upstream in ../ComfyUI-Forks/radiance-main-upstream.
  3. Create a new local version folder in MAIN, e.g. forks/radiance_koolook/versions/v2_4_0.
  4. Port/validate modifications.
  5. Namespace node IDs for that version (or keep them stable via SKIP_VERSION_SUFFIX when upstream IDs are unchanged).
  6. Add new entry/update metadata in forks/forks_manifest.yaml.

For the underlying mental model — three independent version axes (pack version / fork wrapper version / upstream pinned commit) — see docs/reference/versioning.md.

Rule of Thumb

  • If it is modified production code -> keep in MAIN under forks/.../versions/...
  • If it is raw upstream reference -> keep outside MAIN under ../ComfyUI-Forks
Reference in New Issue View Git Blame Copy Permalink