From 68a697d52153f79e33049b65161d3897c9fbf489 Mon Sep 17 00:00:00 2001 From: digital-garbage <133010426+digital-garbage@users.noreply.github.com> Date: Wed, 5 Aug 2026 15:23:14 +0300 Subject: [PATCH] fix: drop the H3 v2a_grad_scale chip v2a_grad_scale does nothing without joyai_audio_memory on any model, and gating the chip on that toggle still left a warning about a knob the user never asked about. Removes the chip, its fingerprint inputs, and the docs line. Co-Authored-By: Claude Opus 5 --- docs/MovieEditor.md | 5 ++--- movie_editor/frontend/pipeline_caps.js | 8 -------- movie_editor/frontend/view_bus.js | 4 ---- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/docs/MovieEditor.md b/docs/MovieEditor.md index 244302bd..8d624e9b 100644 --- a/docs/MovieEditor.md +++ b/docs/MovieEditor.md @@ -682,9 +682,8 @@ using both at once in one scene means one of them is untrained conditioning. Tex and both VAEs are shared. Needs ComfyUI v0.30.0 or newer. **Inert on H3:** Best-FaceID identity transfer, Bounded Attention, segmented detailing, the -second pass's latent op, and `v2a_grad_scale` all depend on LTX transformer structure H3 -does not have. The Chain Sampler switches them off and says why; the main window warns -before the run. +and the second pass's latent op all depend on LTX transformer structure H3 does not have. +The Chain Sampler switches them off and says why; the main window warns before the run. **Wrong:** Install stuck → **Cancel install**. Pip security policy errors → install packs manually in terminal. After Manager install, restart before pack install. diff --git a/movie_editor/frontend/pipeline_caps.js b/movie_editor/frontend/pipeline_caps.js index 6cd6255b..ff85446c 100644 --- a/movie_editor/frontend/pipeline_caps.js +++ b/movie_editor/frontend/pipeline_caps.js @@ -106,14 +106,6 @@ // Same idea for non-boolean knobs whose neutral value means "off". function h3DeadValueIssues(si) { const out = []; - // Only when joyai_audio_memory is on: v2a_grad_scale is that feature's coupling knob and - // does nothing without it on ANY model, so flagging a left-over value as an H3 limitation - // blames the wrong thing — it would be equally inert on LTX. - if (si.joyai_audio_memory && Math.abs(Number(si.v2a_grad_scale ?? 1) - 1) > 1e-6) { - out.push(["v2a_grad_scale", - "v2a_grad_scale scales LTXAV's video→audio cross-attention module; H3 has no separate " - + "video→audio attention, only joint rows."]); - } if (si.second_pass && si.second_pass_op && si.second_pass_op !== "none") { out.push(["second_pass_op", "The second pass still runs on H3, but its latent op ('" + si.second_pass_op + "') uses the " diff --git a/movie_editor/frontend/view_bus.js b/movie_editor/frontend/view_bus.js index 50865250..2d57a0be 100644 --- a/movie_editor/frontend/view_bus.js +++ b/movie_editor/frontend/view_bus.js @@ -137,10 +137,6 @@ core: (st.models || st.project?.models)?.disable_core, h3Bounded: st.project?.sampler_inputs?.bounded_attention_enabled, h3Detail: st.project?.sampler_inputs?.segmented_detailing, - // v2a_grad_scale only warns while joyai_audio_memory is on, so the toggle is part - // of the chip's message — without it, switching JoyAI off leaves the chip stranded. - h3Joyai: st.project?.sampler_inputs?.joyai_audio_memory, - h3V2a: st.project?.sampler_inputs?.v2a_grad_scale, h3Pass2: st.project?.sampler_inputs?.second_pass, h3Pass2Op: st.project?.sampler_inputs?.second_pass_op, // ... including the project's frame rate, which the H3 fixed-24-fps chip reads.