From e1cd94104a11b7806196103aeb661bbefbf8b021 Mon Sep 17 00:00:00 2001 From: digital-garbage <133010426+digital-garbage@users.noreply.github.com> Date: Fri, 21 Aug 2026 00:13:24 +0300 Subject: [PATCH] fix(editor): the upsampler hint promised an LTX download that H3 refuses 'auto' will not fetch a 128-channel file for a 24-channel model, so the old text sent H3 users to wait at the console for a download that never starts. Co-Authored-By: Claude Opus 5 --- movie_editor/frontend/engine_settings.js | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/movie_editor/frontend/engine_settings.js b/movie_editor/frontend/engine_settings.js index 54e265c3..5f9d5993 100644 --- a/movie_editor/frontend/engine_settings.js +++ b/movie_editor/frontend/engine_settings.js @@ -856,11 +856,19 @@ sel.append(o); }); sel.onchange = () => S.setSamplerInputNow("detail_upsampler", sel.value); + // An upsampler has to take latents the same width as the model's, so on H3 the LTX + // file is not a fallback and 'auto' deliberately will not fetch it. Promising a + // download that cannot happen sends people to wait at the console for nothing. + const h3 = !!(window.PipelineCaps && window.PipelineCaps.isH3(S.get())); g.append(field("Latent upsampler", sel, - "'auto' picks the newest installed one, or downloads the official file (~1 GB, once).", - "The LTX 2.3 spatial upsampler from models/latent_upscale_models — the official two-stage workflows use the same file.")); + h3 ? "'auto' uses an installed upsampler; it never downloads the LTX one on H3." + : "'auto' picks the newest installed one, or downloads the official file (~1 GB, once).", + h3 ? "MiniMax H3's latents are 24-channel, so it needs an upsampler trained for H3 — the LTX file is 128-channel and is refused by name rather than failing mid-render." + : "The LTX 2.3 spatial upsampler from models/latent_upscale_models — the official two-stage workflows use the same file.")); if (_detailUpsamplerChoices.length <= 1) { - g.append(hintEl("Nothing installed in models/latent_upscale_models yet — the first detailed run downloads the official upsampler automatically (watch the ComfyUI console).")); + g.append(hintEl(h3 + ? "Nothing installed in models/latent_upscale_models yet. H3 needs a 24-channel upsampler — put one there and it appears in this list; the operation is skipped, with the reason, until then." + : "Nothing installed in models/latent_upscale_models yet — the first detailed run downloads the official upsampler automatically (watch the ComfyUI console).")); } }