Commit Graph
326 Commits
Author SHA1 Message Date
digital-garbageandClaude Sonnet 5.5 30d1aa14a9 MiniMax H3-Image saves a PNG picture; Length and FPS are not offered and are set to 1
A pipeline with no length or rate input hides those controls in the Project and Scene panels. A preset can carry project numbers it goes with.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-11 03:27:51 +02:00
digital-garbageandClaude Sonnet 5.5 a62906278b Test: a pipe between two saved shortcuts arrives as options over HTTP
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 20:47:27 +02:00
digital-garbageandClaude Sonnet 5.5 5718a0d7e3 Options are split on the raw prompt, before shortcuts and variables expand, so [Shot 1] and other brackets inside them are safe
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 04:26:52 +02:00
digital-garbageandClaude Sonnet 5.5 7022982aa9 Alternative prompts: per-step options for [A|B] and the main prompt choice, in one place
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 02:55:24 +02:00
digital-garbageandClaude Sonnet 5.5 83ca881510 Step merging: Main prompt reads (A while B, A B, only A, only B) sets what the prompt says outside the merged steps
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 02:32:57 +02:00
digital-garbageandClaude Fable 5.2 db1602c6e6 Leak report: stay quiet when a patcher dies whose entry holds no model
ComfyUI builds a lookup entry per patcher on every model load and drops it when the model is already loaded. Its hand-over still fires when the patcher is freed, and was logged as "a dead patcher died; its parent is gone" although nothing can be lost there.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
2026-11-10 01:29:46 +02:00
digital-garbageandClaude Sonnet 5.5 9c415f81ee Simultaneous actions: [A|B] (and A|B between shortcuts) answers each option separately at the named Noise merging steps and merges them; timed phrases and the prompt blend are removed
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 01:27:19 +02:00
digital-garbageandClaude Sonnet 5.5 34db2b331d Reference sheet generator (optional module + dialog); leak report tests start from unwrapped ComfyUI functions
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 00:50:31 +02:00
digital-garbageandClaude Sonnet 5.5 0a8e16ab2b Plain short hints for the model loader and other long settings; details moved to the docs; a test fails on hints over 200 characters
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 00:38:26 +02:00
digital-garbageandClaude Sonnet 5.5 4faea24bcf SDE samplers: torchsde's Brownian start warnings stay silent even when the widened noise sampler cannot be used
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-10 00:10:01 +02:00
digital-garbageandClaude Sonnet 5.5 f5050a4574 Shorter in-app hints: what a setting does, where to start, what it needs
Long hints for 33 settings are cut to one or two sentences each, and the
Taste steering strength and blocks hints now give a starting value and
recommended blocks.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-09 13:26:17 +02:00
Claude c873f4b318 Review round 3: tour follows the renamed Generate button, upscale-model block also for the Training preview and a reloaded page, px/colour lint covers negatives and frame.css, tests for the load path and the flag
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjX7o2YfeGQE18MEtPu
2026-11-08 21:52:16 +00:00
Claude 19c6525d19 Old scene Source values open as the default; Generate refused while an upscale model runs; preset decodes with None without the Sol-H3 VAE; tour callout follows a redrawn button
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjX7o2YfeGQE18MEtPu
2026-11-08 21:05:34 +00:00
Claude cc93830a96 Upscale in Always mode tries again after a running generation instead of giving up; tests for relink wiring, first-40 window, RTX at job start
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjX7o2YfeGQE18MEtPu
2026-11-08 19:59:38 +00:00
Claude 76c707b81c Review fixes: hand-overs with no parent always logged, Upscale refused again at job start, leak label by live parent link, constructor test discriminates, CHANGELOG wording
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjX7o2YfeGQE18MEtPu
2026-11-08 19:44:53 +00:00
digital-garbageandClaude Sonnet 5.5 52d1d8ef56 ComfyUI loses track of a model whose patcher died when the parent link is gone, though cached patchers still hold it: point such an entry at a live patcher before ComfyUI's leak check
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-08 19:12:43 +02:00
digital-garbageandClaude Sonnet 5.5 75fd0d3885 Leak report: log every parent hand-over and every tracked model's state; test with the node cache keeping the chain
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-08 19:07:10 +02:00
Claude 405489c691 Jobs: a Stop before an exclusive job reaches the lock ends it at once
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjVsBg3ixjnT1Fgdy12
2026-11-08 16:17:17 +00:00
digital-garbageandClaude Sonnet 5.5 4f3f2acf4f Leak report: say when ComfyUI's parent hand-over finds no parent (and whether gc was running), and which patchers still hold the model
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-08 18:05:58 +02:00
Claude 3e5ffe2c2d Review fixes round 2: only Upscale and Interpolate jobs wait for each other, a queued one stops at once; tour numbers the parts on screen and Help sees it running
Tour and docs wording match the UI names.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjVsBg3ixjnT1Fgdy12
2026-11-08 15:56:30 +00:00
digital-garbageandClaude Sonnet 5.5 5dbc804e2d Leak report: when ComfyUI finds a model without its patcher, log what holds the model (types, function names, dict key names, never values)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-08 17:54:57 +02:00
Claude 09b6c70db7 Review fixes: removed file choices no longer refuse a render, stage LoRAs said when Two stages is not running, jobs run one at a time
A scene picture a video-only pipeline cannot use is named in Generate. CHANGELOG Brownian wording and Veda GPU labels match the code.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjVsBg3ixjnT1Fgdy12
2026-11-08 15:35:10 +00:00
digital-garbage 39707364d6 Watermark in Post (text or picture, corner, opacity, size, outline); settings of removed modules cleared from the project on open; round 2 fixes: trainer refuses a model it cannot copy with the reason, back-up slider keeps 1.0 and is held at 0.95, Post look hint 2026-11-08 02:47:09 +02:00
digital-garbage 84a92f3d14 Review round 1: carried last frame is the sampler's own, Interpolate keeps full length at x3/x4, MXFP8 skipped no longer blocks LoRA training, Diffusers lora_down/up spelling, back-up 1.0 step lookup, block map mean, Latent upscaler fallback declared, Story box on project switch 2026-11-08 02:22:54 +02:00
digital-garbageandClaude Sonnet 5.5 aa31b95ea5 Timeline header on one line; kit literals into tokens; Composer fits; running-state viewport test; remove Auto Montage
- Header: view toggles (Assets/Preview/Properties/Auto-hide) move to the top bar; progress, the prompt warning and scene actions (rate, upscale, interpolate) move to the row under the toolbar; the timeline head never wraps from 1000px up and never clips its controls. The top bar grows a line instead of spilling when it wraps.
- Kit: every literal pixel size in element CSS is a token (the ratchet test is now zero); Composer's text box follows the viewport; the catalogue shows the component sizes.
- test:viewport adds a fake ComfyUI queue and socket for the render-running state and asserts the header is one row.
- Auto Montage removed (button, window, code, README/docs, tests). Saved projects holding pieces it made still load: the reused flag is kept.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-06 14:28:45 +02:00
digital-garbageandClaude Sonnet 5.5 a033cda36c Reload caching: ETag/304 and content-hash immutable URLs for modules, CSS (incl. @import) and page tags; /api/modules answers 304 and is gzipped
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-06 12:40:45 +02:00
digital-garbageandClaude Sonnet 5.5 25cc6ed0b4 Review round 2: partial Q/K/V LoRAs, Turbo polish no longer read as the last step, cut-short videos refused, NaN-safe block map, bounded block ranges; Common phrases lists words and phrases of any length
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-06 12:23:25 +02:00
digital-garbageandClaude Sonnet 5.5 4f06ed9d89 Shortcuts find/replace: whole words, tidy removals, phrase total, fresh count; Two stages: restore the guider on any error between stages; honest hints
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-06 11:53:44 +02:00
digital-garbage 3dbcc8a4e8 Prompt enhancer: Dynamic style for more motion; counts-only motion check script 2026-11-05 23:29:27 +02:00
digital-garbageandClaude Sonnet 5.5 b551927ac0 Shortcuts: find, find and replace, and common phrases across the whole library
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 22:42:48 +02:00
digital-garbageandClaude Sonnet 5.5 9a698b64d7 Test: the Brownian 'other internals' test starts from the stock sampler, whatever an earlier test or the pack load already widened
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 22:06:11 +02:00
digital-garbage affa3a863e Veda: opt-in per-phase timing, one line naming every size of a Two stages run, fewer device reads
veda_timing (loader, method veda) logs the time in gather, score, select, kernel and scatter
for a run; off by default and it changes no number. The run line now names the size and tile
plan of each stage, not only the last. Cheap speed-ups that keep the numbers exactly: the
list width of kept tiles comes from the layout instead of a device read, the head groups and
the per-row pattern stay on the device, and the predictor's projections are copied from pinned
memory.
2026-11-05 21:57:31 +02:00
digital-garbage 1e2ac5ca67 Sparse attention method veda for MiniMax H3 (experimental), with an optional predictor download
Learned tile-sparse attention (Veda, arXiv 2605.30325): tiles, tile plans, predictor
scoring and selection in plain torch (tested on CPU, including a real tiny H3 with a
stand-in kernel), an INT8 Triton kernel derived from SageAttention (untested on a GPU),
installed through the same override and per-step wrapper as SLA. Runs at the predictor's
trained budget; LoRA, MXFP8, Two stages, dense steps and the attention backend compose.
Settings > Models offers the official Hugging Face download of the predictor on a click,
with its licence beside it; taggers and this share one downloader (core/fetch.py).
2026-11-05 21:32:39 +02:00
digital-garbageandClaude Sonnet 5.5 9b1cb52024 Post settings in Engine > Post: smoothing moved out of the node, plus auto contrast, auto brightness, colour strength
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 20:32:03 +02:00
digital-garbageandClaude Sonnet 5.5 0ed59f06d2 Two stages: Trilinear removed (migrated to Bicubic via renamed_options); Save Video: opt-in edge smoothing
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-11-05 20:19:14 +02:00
digital-garbage 5f6ed35929 Matrix: every modifier is listed or exempt with a reason, must report active, and must wire in; crossed with samplers and Two stages
Brownian leaves the stock sampler alone when torchsde internals differ. LoRA: unwrapped refiner layout, absent blocks, LoKr.
2026-11-05 15:58:29 +02:00
digital-garbage 4b306ae65f Round 3: Brownian noise equals stock noise at any sigma height; every LoRA wrapper reaches every Diffusers module
Queries are limited as plain numbers inside the sampler call. Tests for 11 wrappers and sigma 14.6.
2026-11-05 15:44:24 +02:00
digital-garbage 04e59550de Round 3: a stop during the encoder's last seconds still removes the file; a failed stop request is not a stop
Encoder error text no longer says 'upscaled' for Interpolate.
2026-11-05 15:36:42 +02:00
digital-garbage 478fb835dd Round 2: Brownian clamp survives the CPU tree's float32 cast; Stop per module; block map handles a paired input
Stop only reaches jobs that check for it; a failure landing with Stop counts as a stop. Hint for imported workflows corrected.
2026-11-05 15:29:32 +02:00
digital-garbage 9c4458307c Stop button also stops Upscale and Interpolate jobs
Jobs end as stopped (kept for the poll, no half file, no restarted message); Stop shows while one runs.
Python and JS tests for the cancel path.
2026-11-05 15:16:47 +02:00
digital-garbage 1b9f1cb6aa Review: Brownian noise is the stock noise again; block map profile survives audio+video blocks and cancel
Queries are clamped into torchsde's span instead of moving the span. A cancelled profile saves nothing.
Attention explorer temperature stays above zero under the map; unmeasured groups are not given 3x.
2026-11-05 15:10:18 +02:00
digital-garbage 51383b5370 Output review: stale last-frame picture removed, running jobs kept, encoder errors say why
A failed Save Video keep no longer leaves an older video's picture for the next shot.
Job cap evicts finished jobs only; stream_file and probe report ffmpeg's reason, not Broken pipe.
2026-11-05 15:05:48 +02:00
digital-garbageandClaude Sonnet 5.5 015ec6aa55 Test: the update status test no longer assumes the repo folder is called FunUI-v5
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjV3UWsHHjJiAXix29B
2026-11-05 14:48:36 +02:00
Claude 374cf3de29 Forget a stale namespace 'app' after a failed ComfyUI logger import
Fixes the 'cannot import name governance from app' collection error when pytest loads the root package before ComfyUI is on sys.path.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjV3UWsHHjJiAXix29B
2026-11-05 12:03:30 +00:00
Claude 33c21c0bc3 Continuity: a shot after an interpolated or upscaled clip still continues from the sampler's own picture
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjYBYFyV8YG5YDfYPRb
2026-11-02 14:44:07 +00:00
Claude d8ce442c04 Last-frame pictures go to ComfyUI's temp folder, not the media bin
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjYBYFyV8YG5YDfYPRb
2026-11-02 13:46:50 +00:00
Claude 06692cf79c Media bin: pin a picture as the aspect ratio source for all scenes (new scenes inherit it), and add a reference to all scenes
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjXTnZcw5grg6FUn3DV
2026-11-02 13:17:44 +00:00
Claude 344d554a71 Brownian noise: widen the tree past torchsde's 6-decimal rounding so SDE samplers stop warning about ta>=t0
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjUxS9c6hheZ8nePUYf
2026-11-02 13:07:27 +00:00
Claude 5eabca5839 LoRA loader: Apply to stage (First/Second/Both) for Two stages, and Diffusers-layout H3 LoRAs now load
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjVKTwSL4mCUi3hd811
2026-11-02 12:56:50 +00:00
Claude a0234fa01b Frozen node list: Save Video has the optional quality input
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Tw9fjW75aYB8UyVRZo6fCr
2026-11-01 12:00:07 +00:00