digital-garbageandClaude Opus 5
89e4b24b59
The sandbox was a claim the code could not make. `panels.js` said "no DOM node, no document... a module cannot style anything because it is never handed anything that could" -- while handing over `composer`, whose factories return handles wrapping a real element. A module could take one, style it, and reach the whole document through node.ownerDocument. No lint to evade, just the intended API. No module ever used it. Panels are rendered from the DECLARATION, and a module that wants to draw something should be declaring it. So it is gone, and the guarantee is now true as stated: the kit hands a module nothing that touches the DOM. What is NOT claimed any more: that a module CANNOT reach the DOM. A ui.js is an ES module in the page realm and `document` is a global. kit_lint is a discipline check, not a boundary -- globalThis["docu"+"ment"] defeats every regex and always will. It now catches the bracket-access spellings, which were the first thing tried and went straight through, and says plainly what it is and is not. The test that was supposed to protect this asserted "no value IS a node" while a value that MAKES nodes sat in the same object. It checks what it names now. And the overlay compaction test computed a before-snapshot and discarded it with `void before`, checking only that survivors do not collide -- true even if nothing ever moves. Two attempts to fix it failed against CORRECT code (earlier tests leave live claims, so the rung has a legitimate gap; and some demos close themselves, so closing them again is a no-op). It now opens two overlays of its own so the invariant runs every time, and removing notify() from zlayer fails three tests instead of none. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
48 lines
2.7 KiB
JavaScript
48 lines
2.7 KiB
JavaScript
// What a module may not do, and what the kit may not do.
|
|
//
|
|
// A DISCIPLINE CHECK, NOT A BOUNDARY. Say it plainly, because the difference
|
|
// matters: a module's ui.js is an ES module in the page realm, so `document` is
|
|
// a global it can reach and no regex can stop it. `globalThis["docu"+"ment"]`
|
|
// defeats every rule below and always will; only real isolation -- a worker,
|
|
// another realm -- would be a boundary.
|
|
//
|
|
// What this does buy: the accidental and the casual are caught in the file
|
|
// rather than at the moment they would have run, which is the difference
|
|
// between a failing test and a support ticket. The bracket-access spellings are
|
|
// here because they were the first thing tried and they went straight through.
|
|
//
|
|
// The runtime half is the real work: the kit hands a module nothing that
|
|
// touches the DOM, so following the contract requires no restraint.
|
|
|
|
export const MODULE_RULES = [
|
|
{ name: "inline-style", why: "presentation belongs to the kit",
|
|
test: /\.style\s*[.[]|\[\s*['"`]style['"`]\s*\]|setAttribute\s*\(\s*['"`]style/ },
|
|
{ name: "style-attribute", why: "presentation belongs to the kit",
|
|
test: /\bstyle\s*=\s*['"`]/ },
|
|
{ name: "class-manipulation", why: "kit classes are the kit's; a module names elements, not classes",
|
|
test: /\bclassList\b|setAttribute\s*\(\s*['"`]class/ },
|
|
{ name: "raw-element", why: "every element comes from the kit, not from a module",
|
|
test: /document\s*[.[]|createElementNS|\[\s*['"`]createElement['"`]\s*\]/ },
|
|
{ name: "reaching-for-globals", why: "a module is handed what it may use; the rest is not for it",
|
|
test: /\bglobalThis\b|\bwindow\s*[.[]|\bself\s*\[/ },
|
|
{ name: "markup", why: "content is data; the kit renders it as text",
|
|
test: /\binnerHTML\b|\bouterHTML\b|insertAdjacentHTML|\[\s*['"`](inner|outer)HTML['"`]\s*\]/ },
|
|
{ name: "stylesheet", why: "a module cannot ship styling, and cannot inject it either",
|
|
test: /adoptedStyleSheets|document\s*\.\s*head|<\s*(link|style)\b/ },
|
|
{ name: "hardcoded-colour", why: "colour comes from the theme tokens",
|
|
test: /#[0-9a-fA-F]{3,8}\b/ },
|
|
{ name: "hardcoded-size", why: "sizes come from the spacing and control scales",
|
|
test: /\b\d+(\.\d+)?px\b/ },
|
|
{ name: "eval", why: "nothing in a module is compiled at runtime",
|
|
test: /\beval\s*[([]|new\s+Function\s*\(|\[\s*['"`](eval|Function)['"`]\s*\]/ },
|
|
];
|
|
|
|
// The kit itself may style and may build elements -- that is its job -- but it
|
|
// must never interpret content.
|
|
export const KIT_RULES = [
|
|
{ name: "markup", why: "the kit renders content as text and never parses it",
|
|
test: /\binnerHTML\b|\bouterHTML\b|insertAdjacentHTML|document\s*\.\s*write/ },
|
|
{ name: "eval", why: "nothing in the kit is compiled at runtime",
|
|
test: /\beval\s*\(|new\s+Function\s*\(/ },
|
|
];
|