Files
olivv-cs-ComfyUI-FunPack/app
digital-garbageandClaude Sonnet 5 2e738a831e fix: reference-image wiring -- notice race and dangling-source masking
Round-1 adversarial review of 1abf136 found two real conditions:

- _buildQueueInputs set state.notice for an unwired reference directly,
  before GB.generate() ran check() -- whose own "warn" note writes the
  same field via GB.on("warn"). Whichever fired last won, so a person
  with any Engine Settings configured on a pipeline with no settings
  sink (the default pipeline is exactly that) would see "module
  settings didn't apply" instead of ever learning their reference was
  dropped. Fixed by applying the reference notice AFTER GB.generate()
  resolves, so it always wins that race instead of losing it silently.

- The Resolution-source picker's collapsed view can't tell "nothing
  picked" from "picked something since deleted from the bin" -- both
  render as MediaPicker's noneLabel placeholder. The References list
  right next to it already shows "(missing)" for this case; the
  source picker didn't. Added the same declaration as an insp-hint.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-15 14:54:39 +03:00
..