digital-garbageandClaude Opus 5
5f0247405c
A module whose setup() threw was reported as hidden with its panel already on screen -- appended one line too early. The file states the opposite guarantee. A redraw destroyed every control and then rebuilt, so a row revealed by another value -- one the first build never rendered and so never checked -- stripped the panel and threw on the way to refilling it. Building first makes a redraw as safe as the first build already was. A page loaded at a narrow width recorded the panel its own one-at-a-time rule had just closed as one the user wanted closed, so widening brought back only the left. What the user chose is now kept apart from what is on screen. The redraw test counted rows and passed against the bug; a control removed from a row leaves the row behind. It counts controls. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
81 lines
2.7 KiB
JavaScript
81 lines
2.7 KiB
JavaScript
// Mounting a module's panel.
|
|
//
|
|
// The guarantee this file exists to check is stated in panels.js: a module that
|
|
// failed is indistinguishable from one nobody installed. No placeholder, no
|
|
// greyed row, nothing on screen. It had never been tested against a module that
|
|
// fails AFTER its panel is built, which is the only case where there is
|
|
// something on screen to leave behind.
|
|
|
|
import test from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { setupDom, teardownDom } from "../../composer/tests/_dom.js";
|
|
|
|
let mountAll, offer, resetMounts, resetValues;
|
|
test.before(async () => {
|
|
setupDom();
|
|
await import("../../composer/composer.js");
|
|
({ mountAll } = await import("../panels.js"));
|
|
({ offer, _reset: resetMounts } = await import("../mounts.js"));
|
|
({ _reset: resetValues } = await import("../values.js"));
|
|
});
|
|
test.after(() => teardownDom());
|
|
|
|
function region() {
|
|
resetMounts();
|
|
resetValues();
|
|
const host = document.createElement("div");
|
|
document.body.replaceChildren(host);
|
|
offer("generation.model", host);
|
|
return host;
|
|
}
|
|
|
|
const spec = (over = {}) => ({
|
|
id: "demo", title: "Demo", mount: "generation.model",
|
|
settings: { steps: { type: "int", label: "Steps", default: 20 } },
|
|
...over,
|
|
});
|
|
|
|
test("a module whose setup throws leaves nothing on screen", async () => {
|
|
const host = region();
|
|
const { mounted, hidden } = await mountAll(
|
|
{ modules: [spec({ ui: "./boom.js" })] },
|
|
{ load: async () => ({ setup: () => { throw new Error("no"); } }) });
|
|
|
|
assert.deepEqual(mounted, []);
|
|
assert.equal(hidden.length, 1);
|
|
assert.equal(host.childElementCount, 0,
|
|
"a hidden module left its panel in the document");
|
|
});
|
|
|
|
test("a module whose ui.js will not import leaves nothing on screen", async () => {
|
|
const host = region();
|
|
const { hidden } = await mountAll(
|
|
{ modules: [spec({ ui: "./missing.js" })] },
|
|
{ load: async () => { throw new Error("404"); } });
|
|
|
|
assert.equal(hidden.length, 1);
|
|
assert.equal(host.childElementCount, 0);
|
|
});
|
|
|
|
test("a module that mounts is on screen, so the checks above can fail", async () => {
|
|
// Without this the two tests above pass on a mountAll that mounts nothing.
|
|
const host = region();
|
|
const { mounted, hidden } = await mountAll({ modules: [spec()] });
|
|
assert.deepEqual(hidden, []);
|
|
assert.equal(mounted.length, 1);
|
|
assert.equal(host.childElementCount, 1);
|
|
});
|
|
|
|
test("a module's setup still runs, and its teardown is kept", async () => {
|
|
const host = region();
|
|
let torn = 0;
|
|
const { mounted } = await mountAll(
|
|
{ modules: [spec({ ui: "./ok.js" })] },
|
|
{ load: async () => ({ setup: () => () => { torn += 1; } }) });
|
|
|
|
assert.equal(host.childElementCount, 1);
|
|
mounted[0].destroy();
|
|
assert.equal(torn, 1, "the unsubscribe setup() returned was dropped");
|
|
});
|