"""Stable Modal cloud entrypoint for ComfyUI Modal-Sync.""" import asyncio import base64 import copy import gc import hashlib import importlib import importlib.metadata import importlib.util from io import BytesIO import inspect import json import logging import math import os import queue import shutil import sys import tempfile import threading import time import zipfile import zlib from concurrent.futures import ThreadPoolExecutor from contextlib import contextmanager from dataclasses import dataclass from enum import Enum from pathlib import Path from typing import Any, Callable, Iterable, Iterator, Mapping, Sequence _REPO_ROOT = Path(__file__).resolve().parent _REMOTE_REPO_ROOT = Path("/root/comfyui_modal_sync_repo") _LOCAL_COMFYUI_ROOT = (Path.home() / "git" / "ComfyUI").resolve() _REMOTE_COMFYUI_ROOT = Path("/root/comfyui_src") _REMOTE_LLM_COMPILE_CACHE_ROOT = Path("/root/.cache/comfy-modal-llm") for candidate in ( _REPO_ROOT, _REMOTE_REPO_ROOT, _LOCAL_COMFYUI_ROOT, _REMOTE_COMFYUI_ROOT, ): candidate_str = str(candidate) try: candidate_exists = candidate.exists() except PermissionError: candidate_exists = False if candidate_exists and candidate_str not in sys.path: sys.path.insert(0, candidate_str) from runtime_environment import ( # noqa: E402 - paths are bootstrapped above. COMFYUI_RUNTIME_SOURCE_DIRECTORIES as _COMFYUI_IMAGE_RUNTIME_DIRECTORIES, COMFYUI_RUNTIME_SOURCE_FILES as _COMFYUI_IMAGE_RUNTIME_FILES, REMOTE_APP_PROTOCOL_VERSION as _REMOTE_APP_PROTOCOL_VERSION, REMOTE_PYTHON_VERSION, RemoteTorchBuild as _RemoteTorchBuild, build_remote_runtime_identity, custom_node_runtime_packages as _custom_node_runtime_packages, remote_accelerator_packages as _remote_accelerator_packages, remote_accelerator_validation_command as _remote_accelerator_validation_command, remote_apt_packages as _comfyui_apt_packages, remote_huggingface_packages as _remote_huggingface_packages, remote_huggingface_validation_command as _remote_huggingface_validation_command, remote_runtime_packages as _comfyui_runtime_packages, select_remote_torch_build as _select_remote_torch_build, ) from llm_recovery import ( # noqa: E402 LLM_FORCE_VLLM_THROUGHPUT_PAYLOAD_KEY, is_llm_memory_recovery_exhausted, ) from llm_staging import resolve_and_stage_model_references # noqa: E402 from durable_state import ( # noqa: E402 - paths are bootstrapped above. DurableObjectCommitBatch, DurableObjectRef, DurableStateError, FileDurableObjectStore, InMemoryRemoteInvocationStore, RemoteInvocationRecord, new_running_invocation_record, read_modal_volume_file, ) from output_artifacts import ( # noqa: E402 - paths are bootstrapped above. RemoteOutputSnapshot, capture_execution_result, snapshot_output_directory, ) from remote_protocol import ( # noqa: E402 - paths are bootstrapped above. BOUNDARY_INPUT_SIGNATURES_KEY as _BOUNDARY_INPUT_SIGNATURES_KEY, PRIMITIVE_WIDGET_INPUT_TYPES as _PRIMITIVE_WIDGET_INPUT_TYPES, ) from serialization import ( # noqa: E402 - paths are bootstrapped above. coerce_serialized_node_outputs, deserialize_node_inputs, deserialize_node_outputs, deserialize_value, serialize_mapping, serialize_node_inputs, serialize_node_outputs, serialize_value, ) from session_state import ( # noqa: E402 - paths are bootstrapped above. InMemoryRemoteSessionBridgeStore, InMemoryRemoteSessionStore, RemoteSessionBridgeRecord, RemoteSessionBridgeRecoveryKind, RemoteSessionBridgeRef, RemoteSessionHandle, RemoteSessionStateError, RemoteSessionValueRef, is_remote_session_bridge_ref_payload, is_remote_session_handle_payload, is_remote_session_value_ref_payload, stable_session_bridge_key, ) from settings import ( # noqa: E402 - paths are bootstrapped above. DEFAULT_MODAL_SECRET_NAME, get_settings, modal_deployment_app_name, ) try: # noqa: E402 - support package and flat Modal-container imports. from .cloud_prompt_server_shims import ( CloudPromptServerHooks, _HeadlessPromptQueue, _HeadlessPromptServerInstance, _NullPromptServer, _TracingPromptServer, configure_cloud_prompt_server_hooks, ) except ImportError: # pragma: no cover - exercised by flat cloud imports. from cloud_prompt_server_shims import ( CloudPromptServerHooks, _HeadlessPromptQueue, _HeadlessPromptServerInstance, _NullPromptServer, _TracingPromptServer, configure_cloud_prompt_server_hooks, ) try: # noqa: E402 - support package and flat Modal-container imports. from .cloud_session_bridge import ( CloudSessionBridgeHooks, _RemoteSessionBridgeResolutionStats, _bridge_record_replays_sampling_node, _build_durable_bridge_rehydration_plan, _build_remote_session_bridge_record, _deserialize_remote_session_bridge_producer_inputs, _get_remote_session_bridge_value, _json_payload_size_bytes, _load_loader_snapshot_profile, _load_remote_session_bridge_record, _log_remote_session_resolution_summary, _offload_large_bridge_payloads, _payload_remote_session_handle, _record_remote_session_resolution_event, _rehydrate_remote_session_bridge_value, _remote_session_bridge_recovery_input_names, _remote_session_bridge_replay_stack, _resolve_remote_session_inputs, _restore_planned_remote_session_bridge_value, _restore_serialized_remote_session_bridge_value, _sanitize_payload_for_session_bridge_record, _select_remote_session_bridge_recovery_kind, _serialize_durable_bridge_output, _session_bridge_store, _snapshot_profile_store, _store_remote_session_bridge_record, _store_remote_session_bridge_value, _subgraph_contains_sampling_node, configure_cloud_session_bridge_hooks, remote_session_store, ) except ImportError: # pragma: no cover - exercised by flat cloud imports. from cloud_session_bridge import ( CloudSessionBridgeHooks, _RemoteSessionBridgeResolutionStats, _bridge_record_replays_sampling_node, _build_durable_bridge_rehydration_plan, _build_remote_session_bridge_record, _deserialize_remote_session_bridge_producer_inputs, _get_remote_session_bridge_value, _json_payload_size_bytes, _load_loader_snapshot_profile, _load_remote_session_bridge_record, _log_remote_session_resolution_summary, _offload_large_bridge_payloads, _payload_remote_session_handle, _record_remote_session_resolution_event, _rehydrate_remote_session_bridge_value, _remote_session_bridge_recovery_input_names, _remote_session_bridge_replay_stack, _resolve_remote_session_inputs, _restore_planned_remote_session_bridge_value, _restore_serialized_remote_session_bridge_value, _sanitize_payload_for_session_bridge_record, _select_remote_session_bridge_recovery_kind, _serialize_durable_bridge_output, _session_bridge_store, _snapshot_profile_store, _store_remote_session_bridge_record, _store_remote_session_bridge_value, _subgraph_contains_sampling_node, configure_cloud_session_bridge_hooks, remote_session_store, ) try: # noqa: E402 - support package and flat Modal-container imports. from .cloud_durable_invocation import ( DurableInvocationErrors, _begin_remote_invocation, _canary_barrier_marker_exists, _canary_barrier_marker_key, _canary_interrupt_requested, _complete_remote_invocation, _durable_object_store, _execute_canary_payload, _execute_payload_with_output_capture, _execute_with_durable_invocation, _fail_remote_invocation, _invocation_record_store, _load_completed_remote_invocation_result, _load_remote_invocation_record, _put_canary_barrier_marker, _raise_if_canary_interrupted, _remote_comfy_output_directory, _remote_output_snapshot, _store_remote_invocation_record, _wait_for_canary_barrier, _wait_for_running_remote_invocation, configure_durable_invocation_errors, ) except ImportError: # pragma: no cover - exercised by flat cloud imports. from cloud_durable_invocation import ( DurableInvocationErrors, _begin_remote_invocation, _canary_barrier_marker_exists, _canary_barrier_marker_key, _canary_interrupt_requested, _complete_remote_invocation, _durable_object_store, _execute_canary_payload, _execute_payload_with_output_capture, _execute_with_durable_invocation, _fail_remote_invocation, _invocation_record_store, _load_completed_remote_invocation_result, _load_remote_invocation_record, _put_canary_barrier_marker, _raise_if_canary_interrupted, _remote_comfy_output_directory, _remote_output_snapshot, _store_remote_invocation_record, _wait_for_canary_barrier, _wait_for_running_remote_invocation, configure_durable_invocation_errors, ) try: # noqa: E402 - support package and flat Modal-container imports. from .cloud_image_env import ( _REMOTE_LLM_COMPILE_CACHE_ROOT, _install_custom_node_packages, _install_remote_accelerator_packages, _install_remote_torch_build, _modal_image_environment, _modal_secret_from_settings, _model_stager_image_environment, _remote_engine_cls_options, _should_ignore_comfyui_path, _should_ignore_repo_path, ) except ImportError: # pragma: no cover - exercised by flat cloud imports. from cloud_image_env import ( _REMOTE_LLM_COMPILE_CACHE_ROOT, _install_custom_node_packages, _install_remote_accelerator_packages, _install_remote_torch_build, _modal_image_environment, _modal_secret_from_settings, _model_stager_image_environment, _remote_engine_cls_options, _should_ignore_comfyui_path, _should_ignore_repo_path, ) try: # noqa: E402 - support package and flat Modal-container imports. from .cloud_app_guard import guard_against_existing_modal_app except ImportError: # pragma: no cover - exercised by flat cloud imports. from cloud_app_guard import guard_against_existing_modal_app try: # noqa: E402 - support package and flat Modal-container imports. from .cloud_runtime_context import ( interrupt_flag_store, invocation_record_store, node_output_cache_store, register_cloud_runtime_stores, session_bridge_store, snapshot_profile_store, volume_store, ) except ImportError: # pragma: no cover - exercised by flat cloud imports. from cloud_runtime_context import ( interrupt_flag_store, invocation_record_store, node_output_cache_store, register_cloud_runtime_stores, session_bridge_store, snapshot_profile_store, volume_store, ) logger = logging.getLogger(__name__) # Cloud app and ComfyUI bootstrap state. _CLOUD_HANDLER_NAME = "comfyui-modal-sync-cloud-timestamped" _COMFY_RUNTIME_INIT_LOCK = threading.Lock() _COMFY_RUNTIME_BASE_INITIALIZED = False _COMFY_RUNTIME_CUSTOM_NODE_ROOTS: set[str] = set() _EXTRACTED_CUSTOM_NODE_BUNDLES: dict[str, Path] = {} _FOLDER_PATHS_PATCH_LOCK = threading.Lock() _FOLDER_PATHS_PATCH_DEPTH = 0 _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH: Callable[[str, str], str | None] | None = None _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH_OR_RAISE: Callable[[str, str], str] | None = None _LOADER_CACHE_LOCK = threading.Lock() _LOADER_CACHE_WRAPPED_CLASSES: set[str] = set() _MODEL_STATE_DICT_COMPAT_WRAPPED = False # Loader, prewarm, and distributed node-output cache state. _LOADER_OUTPUT_CACHE: dict[tuple[str, str], tuple[Any, ...]] = {} _LOADER_CACHE_METRICS_LOCK = threading.Lock() _LOADER_CACHE_METRICS: dict[str, int] = {"hit": 0, "miss": 0} _LOADER_PREWARM_PLAN_KEYS_LOCK = threading.Lock() _LOADER_PREWARM_PLAN_KEYS: set[str] = set() _LLM_PREWARM_PLAN_KEYS_LOCK = threading.Lock() _LLM_PREWARM_PLAN_KEYS: set[str] = set() _NODE_OUTPUT_CACHE_KEY_PREFIX = "NC_" _NODE_OUTPUT_CACHE_RECORD_VERSION = 1 _PROMPT_EXECUTOR_STATES_LOCK = threading.Lock() _PROMPT_EXECUTOR_STATES: dict[str, "_ReusablePromptExecutorState"] = {} _DYNAMIC_PROMPT_WRAPPER_LOCK = threading.Lock() _PROMPT_METADATA_STATE = threading.local() # Modal volume reload and poisoned-container retirement state. _MODAL_VOLUME_RELOAD_MARKERS_LOCK = threading.Lock() _MODAL_VOLUME_RELOAD_OPEN_FILE_RETRY_DELAYS_SECONDS = ( 0.0, 0.25, 0.5, 1.0, 2.0, 4.0, 8.0, ) _MODAL_VOLUME_RELOAD_MARKER_CACHE_LIMIT = 256 _MODAL_VOLUME_RELOAD_MARKERS: queue.SimpleQueue[str] | None = None _MODAL_VOLUME_RELOAD_MARKER_SET: set[str] = set() _CONTAINER_TERMINATION_LOCK = threading.Lock() _REMOTE_ERROR_CONTAINER_EXIT_DELAY_SECONDS = 1.0 _CONTAINER_TERMINATION_SCHEDULED = False _REMOTE_VOLUME_READTHROUGH_ROOT = ( Path(tempfile.gettempdir()) / "comfy-modal-volume-readthrough" ) # Durable invocation and session-bridge state. _REMOTE_INVOCATION_ABANDON_JOIN_SECONDS = 0.5 try: import modal # type: ignore except ModuleNotFoundError: # pragma: no cover - remote entrypoint only. modal = None class RemoteSubgraphExecutionError(RuntimeError): """Raised when remote subgraph execution fails.""" class RemoteInvocationInProgressError(RuntimeError): """Raised when an idempotent invocation is already running remotely.""" class RemoteInvocationAbandonedError(RuntimeError): """Raised when a streamed invocation loses its consumer before completion.""" class RemoteCanaryInterruptedError(RuntimeError): """Raised when a live remote canary observes its shared interrupt flag.""" class RemoteCanaryBarrierTimeoutError(TimeoutError): """Raised when live canary calls fail to overlap before their deadline.""" class ExistingModalAppError(RuntimeError): """Raised when deploying would overwrite an existing Modal app.""" configure_durable_invocation_errors( DurableInvocationErrors( invocation_in_progress=RemoteInvocationInProgressError, canary_interrupted=RemoteCanaryInterruptedError, canary_barrier_timeout=RemoteCanaryBarrierTimeoutError, ) ) class RemoteFailureDisposition(str, Enum): """Describe whether one remote failure implies poisoned worker state.""" EXPECTED = "expected" DETERMINISTIC = "deterministic" POISONED_WORKER = "poisoned-worker" def _guard_against_existing_modal_app(settings: Any, modal_module: Any) -> None: """Fail local Modal app construction when the configured app already exists.""" guard_against_existing_modal_app( settings, modal_module, error_type=ExistingModalAppError, ) def _record_loader_cache_metric(result: str) -> None: """Increment one warm-worker loader-cache metric counter.""" with _LOADER_CACHE_METRICS_LOCK: _LOADER_CACHE_METRICS[result] = _LOADER_CACHE_METRICS.get(result, 0) + 1 def _loader_cache_metric_snapshot() -> dict[str, int]: """Return the current cumulative loader-cache metrics.""" with _LOADER_CACHE_METRICS_LOCK: return dict(_LOADER_CACHE_METRICS) @dataclass class _ReusablePromptExecutorState: """Hold a warm-container PromptExecutor and the lock guarding its reuse.""" executor: Any lock: threading.Lock @dataclass class _PersistedNodeCacheRestoreState: """Track which distributed cache entries were restored into one prompt execution.""" restored_node_ids: list[str] restored_cache_keys_by_node_id: dict[str, str] restore_original_method: Callable[[], None] @dataclass(frozen=True) class _NodeOutputCacheLookupResult: """Hold one distributed cache lookup result before hydration into the live outputs cache.""" node_id: str cache_key: str | None raw_record: Any | None cache_entry: Any | None @dataclass class _RemoteExecutionControl: """Track interruption state for one active remote payload execution.""" cancellation_event: threading.Event interrupt_flag_key: str def _meaningful_progress_values( node_state: dict[str, Any] ) -> tuple[float, float] | None: """Return numeric progress values only for node states that represent real progress.""" try: progress_value = float(node_state.get("value", 0.0)) max_value = float(node_state.get("max", 1.0)) except (TypeError, ValueError): return None if max_value <= 1.0: return None return progress_value, max_value def _schedule_process_exit(delay_seconds: float, exit_code: int) -> None: """Exit the current process after a short delay to retire a bad Modal container.""" def exit_later() -> None: """Sleep briefly so Modal can ship the error response before exiting the worker.""" if delay_seconds > 0: time.sleep(delay_seconds) logger.error( "Exiting Modal container process with code=%s after remote failure.", exit_code, ) sys.stdout.flush() sys.stderr.flush() os._exit(exit_code) threading.Thread( target=exit_later, name="modal-container-exit", daemon=True, ).start() def _schedule_process_exit_unless_cancelled( *, delay_seconds: float, exit_code: int, cancel_event: threading.Event, reason: str, ) -> None: """Exit the current process after a delay unless the caller cancels first.""" def exit_later() -> None: """Wait for cancellation or exit the worker if the delay expires.""" if delay_seconds > 0 and cancel_event.wait(timeout=delay_seconds): logger.debug("Cancelled delayed Modal container restart for %s.", reason) return logger.error( "Exiting Modal container process with code=%s after %s.", exit_code, reason ) sys.stdout.flush() sys.stderr.flush() os._exit(exit_code) threading.Thread( target=exit_later, name="modal-container-cancel-restart", daemon=True, ).start() def _schedule_remote_cancel_restart( *, component_id: str, completion_event: threading.Event, ) -> bool: """Restart the Modal worker if a cancelled remote prompt keeps executing.""" if not _is_modal_container_runtime(): return False delay_seconds = max(0.0, get_settings().remote_cancel_restart_seconds) logger.warning( "Remote cancellation requested for component=%s; scheduling container restart in %.3fs unless execution stops first.", component_id, delay_seconds, ) _schedule_process_exit_unless_cancelled( delay_seconds=delay_seconds, exit_code=0, cancel_event=completion_event, reason=f"remote cancellation timeout for component={component_id}", ) return True def _is_interrupt_like_failure(exc: Exception) -> bool: """Return whether one remote failure represents an expected interruption rather than a crash.""" return "interrupt" in str(exc).lower() def _is_session_state_like_failure(exc: Exception) -> bool: """Return whether one remote failure came from prompt-scoped session routing/state issues.""" if isinstance(exc, RemoteSessionStateError): return True return "remote session" in str(exc).lower() def _remote_failure_disposition(exc: Exception) -> RemoteFailureDisposition: """Classify one execution failure for worker-retirement decisions.""" if _is_interrupt_like_failure(exc) or _is_session_state_like_failure(exc): return RemoteFailureDisposition.EXPECTED if isinstance(exc, MemoryError) or is_llm_memory_recovery_exhausted(exc): return RemoteFailureDisposition.POISONED_WORKER message = str(exc).lower() poisoned_runtime_markers = ( "cuda out of memory", "cuda error", "device-side assert", "illegal memory access", "cublas_status", "cudnn_status", "hip error", ) if any(marker in message for marker in poisoned_runtime_markers): return RemoteFailureDisposition.POISONED_WORKER return RemoteFailureDisposition.DETERMINISTIC def _maybe_schedule_container_termination_on_error( payload: dict[str, Any], exc: Exception, ) -> bool: """Retire the current Modal container after a remote execution crash when configured.""" if not _is_modal_container_runtime(): return False if not bool(payload.get("terminate_container_on_error", True)): return False disposition = _remote_failure_disposition(exc) if disposition is not RemoteFailureDisposition.POISONED_WORKER: logger.warning( "Skipping Modal container termination for component=%s failure_disposition=%s because the worker is safe to reuse.", payload.get("component_id"), disposition.value, exc_info=(type(exc), exc, exc.__traceback__), ) return False global _CONTAINER_TERMINATION_SCHEDULED with _CONTAINER_TERMINATION_LOCK: if _CONTAINER_TERMINATION_SCHEDULED: return False _CONTAINER_TERMINATION_SCHEDULED = True logger.error( "Scheduling Modal container termination after remote execution failure for component=%s.", payload.get("component_id"), exc_info=(type(exc), exc, exc.__traceback__), ) _schedule_process_exit(_REMOTE_ERROR_CONTAINER_EXIT_DELAY_SECONDS, 1) return True def _build_cloud_log_formatter() -> logging.Formatter: """Return the default formatter for remote Modal-Sync logs with timestamps.""" return logging.Formatter( fmt="%(asctime)s.%(msecs)03d +%(relativeCreated)07.0fms %(levelname)s [%(name)s] %(message)s", datefmt="%H:%M:%S", ) def _configure_cloud_logging() -> logging.Logger: """Install a dedicated timestamped handler for the cloud runtime logger.""" logger.setLevel(logging.INFO) for existing_handler in logger.handlers: if getattr(existing_handler, "name", "") == _CLOUD_HANDLER_NAME: return logger handler = logging.StreamHandler(sys.stdout) handler.set_name(_CLOUD_HANDLER_NAME) handler.setLevel(logging.INFO) handler.setFormatter(_build_cloud_log_formatter()) logger.addHandler(handler) logger.propagate = False return logger def _is_modal_container_runtime() -> bool: """Return whether the current process is executing inside a Modal container.""" return os.getenv("MODAL_IS_REMOTE") == "1" or bool(os.getenv("MODAL_TASK_ID")) def _cloud_formatter() -> logging.Formatter: """Return the configured formatter used for cloud phase trace lines.""" for existing_handler in logger.handlers: if getattr(existing_handler, "name", "") == _CLOUD_HANDLER_NAME: formatter = existing_handler.formatter if formatter is not None: return formatter return _build_cloud_log_formatter() def _emit_cloud_info(message: str, *args: Any) -> None: """Emit an info line through logging and mirror it to stdout inside Modal containers.""" if not _is_modal_container_runtime(): logger.info(message, *args) return record = logger.makeRecord( logger.name, logging.INFO, __file__, 0, message, args, exc_info=None, ) print(_cloud_formatter().format(record), file=sys.stdout, flush=True) def _remote_execution_key(payload: dict[str, Any]) -> tuple[str, str]: """Return the registry key for one active remote execution.""" prompt_id = str( payload.get("prompt_id") or payload.get("component_id") or "modal-subgraph" ) component_id = str(payload.get("component_id") or "single-node") return prompt_id, component_id def _observe_remote_workflow_for_llm_mode(payload: dict[str, Any]) -> None: """Record real workflow arrivals for container-local vLLM auto promotion.""" if payload.get("payload_kind") == "canary": return from modal_llm_runtime import ( force_modal_vllm_throughput_after_memory_recovery, observe_modal_workflow_execution, ) prompt_id = payload.get("prompt_id") normalized_prompt_id = str(prompt_id).strip() if prompt_id is not None else None if bool(payload.get(LLM_FORCE_VLLM_THROUGHPUT_PAYLOAD_KEY)): force_modal_vllm_throughput_after_memory_recovery(normalized_prompt_id) return observe_modal_workflow_execution(normalized_prompt_id) def _remote_interrupt_flag_key(prompt_id: str, component_id: str) -> str: """Return the shared Modal interrupt-store key for one payload execution.""" return f"{prompt_id}:{component_id}" @contextmanager def _registered_remote_execution( payload: dict[str, Any], ) -> Iterator[_RemoteExecutionControl]: """Prepare interruption state for one active remote execution.""" prompt_id, component_id = _remote_execution_key(payload) control = _RemoteExecutionControl( cancellation_event=threading.Event(), interrupt_flag_key=_remote_interrupt_flag_key(prompt_id, component_id), ) try: yield control finally: interrupt_store = interrupt_flag_store() if modal is not None and interrupt_store is not None: interrupt_store.pop(control.interrupt_flag_key, None) @contextmanager def _timed_phase(phase: str, **fields: Any) -> Iterator[None]: """Log a start/finish pair with elapsed time for a named execution phase.""" field_suffix = "" if fields: rendered_fields = " ".join(f"{key}={value}" for key, value in fields.items()) field_suffix = f" {rendered_fields}" phase_started_at = time.perf_counter() _emit_cloud_info("Starting %s%s", phase, field_suffix) try: yield finally: _emit_cloud_info( "Finished %s in %.3fs%s", phase, time.perf_counter() - phase_started_at, field_suffix, ) _configure_cloud_logging() @contextmanager def _temporary_node_mapping( node_mapping: dict[str, type[Any]] | None ) -> Iterator[None]: """Temporarily overlay node mappings for tests or custom runtimes.""" if node_mapping is None: yield return import nodes original_mappings = dict(nodes.NODE_CLASS_MAPPINGS) original_display_mappings = dict(getattr(nodes, "NODE_DISPLAY_NAME_MAPPINGS", {})) try: nodes.NODE_CLASS_MAPPINGS.update(node_mapping) for class_type in node_mapping: nodes.NODE_DISPLAY_NAME_MAPPINGS.setdefault(class_type, class_type) yield finally: nodes.NODE_CLASS_MAPPINGS.clear() nodes.NODE_CLASS_MAPPINGS.update(original_mappings) if hasattr(nodes, "NODE_DISPLAY_NAME_MAPPINGS"): nodes.NODE_DISPLAY_NAME_MAPPINGS.clear() nodes.NODE_DISPLAY_NAME_MAPPINGS.update(original_display_mappings) def _extract_custom_nodes_bundle(bundle_path: str | None) -> Path | None: """Extract a mirrored custom_nodes bundle ZIP or manifest into a temporary import path.""" if not bundle_path: return None settings = get_settings() storage_roots = [Path(settings.remote_storage_root)] storage_roots.append(_REMOTE_VOLUME_READTHROUGH_ROOT) if settings.local_storage_root is not None: storage_roots.append(settings.local_storage_root) local_bundle: Path | None = None for storage_root in storage_roots: candidate = storage_root / bundle_path.lstrip("/") if candidate.exists(): local_bundle = candidate break if local_bundle is None: logger.warning( "Custom nodes bundle %s was not found in any known storage root.", bundle_path, ) return None cached_extraction_root = _EXTRACTED_CUSTOM_NODE_BUNDLES.get(local_bundle.name) if cached_extraction_root is not None and cached_extraction_root.exists(): if str(cached_extraction_root) not in sys.path: sys.path.insert(0, str(cached_extraction_root)) _emit_cloud_info( "Reusing extracted remote custom_nodes bundle from %s for %s.", cached_extraction_root, local_bundle.name, ) return cached_extraction_root extraction_root = ( Path(tempfile.gettempdir()) / "comfy-modal-sync-custom-nodes" / local_bundle.stem ) if extraction_root.exists(): shutil.rmtree(extraction_root) extraction_root.mkdir(parents=True, exist_ok=True) with _timed_phase("extract_custom_nodes_bundle", bundle=local_bundle.name): archives_to_extract = _resolve_custom_nodes_archives( local_bundle, storage_roots ) for archive_path in archives_to_extract: with zipfile.ZipFile(archive_path, "r") as archive: archive.extractall(extraction_root) _materialize_custom_nodes_manifest_assets( local_bundle, storage_roots, extraction_root, ) if str(extraction_root) not in sys.path: sys.path.insert(0, str(extraction_root)) _EXTRACTED_CUSTOM_NODE_BUNDLES[local_bundle.name] = extraction_root logger.info("Extracted remote custom_nodes bundle to %s", extraction_root) return extraction_root def _resolve_custom_nodes_archives( local_bundle: Path, storage_roots: list[Path], ) -> list[Path]: """Return the archive paths described by one custom_nodes bundle ZIP or manifest.""" if local_bundle.suffix.lower() == ".zip": return [local_bundle] if local_bundle.suffix.lower() != ".json": raise RuntimeError( f"Unsupported custom_nodes bundle format {local_bundle.suffix!r} for {local_bundle}." ) manifest_payload = _load_custom_nodes_manifest(local_bundle) entry_payloads = manifest_payload.get("entries") if not isinstance(entry_payloads, list): raise RuntimeError( f"Custom nodes manifest {local_bundle} did not contain a valid entries list." ) archive_paths: list[Path] = [] for entry_payload in entry_payloads: if not isinstance(entry_payload, dict): raise RuntimeError( f"Custom nodes manifest {local_bundle} contained a non-object entry." ) remote_path = entry_payload.get("remote_path") if not isinstance(remote_path, str) or not remote_path.strip(): raise RuntimeError( f"Custom nodes manifest {local_bundle} contained an entry without remote_path." ) archive_path = _resolve_custom_nodes_bundle_path(remote_path, storage_roots) if archive_path is None: raise RuntimeError( f"Custom nodes archive {remote_path} referenced by {local_bundle} was not found in any storage root." ) archive_paths.append(archive_path) return archive_paths def _load_custom_nodes_manifest(local_bundle: Path) -> dict[str, Any]: """Load and validate one versioned custom-node bundle manifest.""" try: manifest_payload = json.loads(local_bundle.read_text(encoding="utf-8")) except (OSError, json.JSONDecodeError) as exc: raise RuntimeError( f"Custom nodes manifest {local_bundle} is unreadable." ) from exc if not isinstance(manifest_payload, dict): raise RuntimeError( f"Custom nodes manifest {local_bundle} must be a JSON object." ) manifest_version = manifest_payload.get("version", 1) if manifest_version not in {1, 2}: raise RuntimeError( f"Custom nodes manifest {local_bundle} uses unsupported version {manifest_version!r}." ) return manifest_payload def _materialize_custom_nodes_manifest_assets( local_bundle: Path, storage_roots: list[Path], extraction_root: Path, ) -> None: """Link version-two package assets from mounted storage into extracted code.""" if local_bundle.suffix.lower() != ".json": return manifest_payload = _load_custom_nodes_manifest(local_bundle) if manifest_payload.get("version", 1) < 2: return materialized_count = 0 materialized_bytes = 0 for asset_payload in _iter_custom_nodes_manifest_assets( local_bundle, manifest_payload ): relative_path = _validated_custom_node_asset_relative_path( local_bundle, asset_payload, ) remote_path = str(asset_payload["remote_path"]) asset_path = _resolve_custom_nodes_bundle_path(remote_path, storage_roots) if asset_path is None: raise RuntimeError( f"Custom-node asset {remote_path!r} referenced by {local_bundle} was not found." ) expected_size = int(asset_payload["size_bytes"]) if asset_path.stat().st_size != expected_size: raise RuntimeError( f"Custom-node asset {remote_path!r} size did not match its manifest." ) destination = extraction_root / relative_path destination.parent.mkdir(parents=True, exist_ok=True) if destination.exists() or destination.is_symlink(): if ( destination.is_symlink() and destination.resolve() == asset_path.resolve() ): continue raise RuntimeError( f"Custom-node asset destination {destination} already exists in the code archive." ) destination.symlink_to(asset_path) materialized_count += 1 materialized_bytes += expected_size if materialized_count: logger.info( "Linked %d custom-node model asset(s) totaling %d bytes from mounted storage.", materialized_count, materialized_bytes, ) def _iter_custom_nodes_manifest_assets( local_bundle: Path, manifest_payload: Mapping[str, Any], ) -> Iterator[dict[str, Any]]: """Yield validated asset objects from one version-two manifest.""" entry_payloads = manifest_payload.get("entries") if not isinstance(entry_payloads, list): raise RuntimeError( f"Custom nodes manifest {local_bundle} has no valid entries list." ) for entry_payload in entry_payloads: if not isinstance(entry_payload, dict): raise RuntimeError( f"Custom nodes manifest {local_bundle} contains an invalid entry." ) asset_payloads = entry_payload.get("assets", []) if not isinstance(asset_payloads, list): raise RuntimeError( f"Custom nodes manifest {local_bundle} contains invalid assets." ) for asset_payload in asset_payloads: if not isinstance(asset_payload, dict): raise RuntimeError( f"Custom nodes manifest {local_bundle} contains an invalid asset." ) yield asset_payload def _validated_custom_node_asset_relative_path( local_bundle: Path, asset_payload: Mapping[str, Any], ) -> Path: """Return one safe extraction-relative custom-node asset path.""" relative_path_value = asset_payload.get("relative_path") remote_path = asset_payload.get("remote_path") sha256 = asset_payload.get("sha256") size_bytes = asset_payload.get("size_bytes") if not isinstance(relative_path_value, str) or not relative_path_value: raise RuntimeError( f"Custom nodes manifest {local_bundle} contains an asset without a path." ) if not isinstance(remote_path, str) or not remote_path: raise RuntimeError( f"Custom nodes manifest {local_bundle} contains an asset without storage." ) if ( not isinstance(sha256, str) or len(sha256) != 64 or not Path(remote_path).name.startswith(f"{sha256}_") ): raise RuntimeError( f"Custom nodes manifest {local_bundle} contains an invalid asset digest." ) if ( isinstance(size_bytes, bool) or not isinstance(size_bytes, int) or size_bytes < 0 ): raise RuntimeError( f"Custom nodes manifest {local_bundle} contains an invalid asset size." ) relative_path = Path(relative_path_value) if relative_path.is_absolute() or ".." in relative_path.parts: raise RuntimeError( f"Custom nodes manifest {local_bundle} contains unsafe asset path {relative_path_value!r}." ) return relative_path def _resolve_custom_nodes_bundle_path( bundle_path: str, storage_roots: list[Path] ) -> Path | None: """Resolve one custom_nodes bundle or archive path against the known storage roots.""" for storage_root in storage_roots: candidate = storage_root / bundle_path.lstrip("/") if candidate.exists(): return candidate return None def _register_custom_nodes_root(custom_nodes_root: Path) -> None: """Expose an extracted custom_nodes directory to ComfyUI's folder path registry.""" import folder_paths folder_paths.add_model_folder_path( "custom_nodes", str(custom_nodes_root), is_default=True ) def _active_comfyui_root() -> Path | None: """Return the ComfyUI source root visible to this runtime.""" for candidate in (_REMOTE_COMFYUI_ROOT, _LOCAL_COMFYUI_ROOT): try: if candidate.exists(): return candidate except PermissionError: continue return None def _force_import_package_from_root(module_name: str, package_root: Path) -> None: """Load a top-level package from a specific root, replacing a non-package shadow if needed.""" existing_module = sys.modules.get(module_name) if existing_module is not None and getattr(existing_module, "__path__", None): return package_dir = package_root / module_name init_path = package_dir / "__init__.py" if not init_path.exists(): logger.debug("Package %s does not exist under %s.", module_name, package_root) return spec = importlib.util.spec_from_file_location( module_name, init_path, submodule_search_locations=[str(package_dir)], ) if spec is None or spec.loader is None: raise ImportError( f"Unable to create an import spec for package {module_name!r}." ) module = importlib.util.module_from_spec(spec) sys.modules[module_name] = module spec.loader.exec_module(module) logger.info("Preloaded ComfyUI package %s from %s.", module_name, package_dir) def _ensure_comfyui_support_packages() -> None: """Preload top-level ComfyUI support packages that are vulnerable to name shadowing.""" comfyui_root = _active_comfyui_root() if comfyui_root is None: return _force_import_package_from_root("utils", comfyui_root) def _ensure_headless_prompt_server_instance() -> None: """Install a minimal PromptServer.instance for custom-node import-time hooks.""" try: import server except ModuleNotFoundError: return prompt_server_class = getattr(server, "PromptServer", None) if prompt_server_class is None: return if getattr(prompt_server_class, "instance", None) is not None: return node_replace_manager_class = getattr(server, "NodeReplaceManager", None) node_replace_manager = ( node_replace_manager_class() if callable(node_replace_manager_class) else None ) prompt_server_class.instance = _HeadlessPromptServerInstance(node_replace_manager) logger.info( "Installed headless PromptServer.instance for remote custom-node initialization." ) @contextmanager def _temporary_progress_hook(prompt_server: _NullPromptServer) -> Iterator[None]: """Install a ComfyUI progress hook so remote samplers emit numeric progress updates.""" import comfy.utils import comfy.model_management from comfy_execution.progress import get_progress_state from comfy_execution.utils import get_executing_context previous_hook = comfy.utils.PROGRESS_BAR_HOOK def hook( value: float, total: float, preview_image: Any, prompt_id: str | None = None, node_id: str | None = None, ) -> None: """Mirror ComfyUI progress-bar updates into the headless progress registry.""" executing_context = get_executing_context() if prompt_id is None and executing_context is not None: prompt_id = executing_context.prompt_id if node_id is None and executing_context is not None: node_id = executing_context.node_id comfy.model_management.throw_exception_if_processing_interrupted() if prompt_id is None: prompt_id = prompt_server.last_prompt_id if node_id is None: node_id = prompt_server.last_node_id if node_id is None: return resolved_node_id = str(node_id) get_progress_state().update_progress( resolved_node_id, value, total, preview_image ) preview_emitter = getattr(prompt_server, "emit_preview_update", None) if preview_image is not None and callable(preview_emitter): preview_emitter(node_id=resolved_node_id, preview_image=preview_image) comfy.utils.set_progress_bar_global_hook(hook) try: yield finally: comfy.utils.set_progress_bar_global_hook(previous_hook) @contextmanager def _temporary_remote_interrupt_monitor( component_id: str, cancellation_event: threading.Event | None, interrupt_store: Any | None = None, interrupt_flag_key: str | None = None, ) -> Iterator[None]: """Mirror shared cancellation requests into ComfyUI's interrupt flag inside Modal.""" if cancellation_event is None and ( interrupt_store is None or interrupt_flag_key is None ): yield return import nodes stop_event = threading.Event() execution_completed_event = threading.Event() restart_scheduled = False try: modal_exception_module = importlib.import_module("modal.exception") except ModuleNotFoundError: modal_exception_module = None modal_client_closed_error = getattr(modal_exception_module, "ClientClosed", None) def shared_cancel_flag_exists() -> bool: """Return whether the shared interrupt flag is present, tolerating Modal shutdown races.""" try: return bool(interrupt_store.contains(interrupt_flag_key)) except Exception as exc: if modal_client_closed_error is not None and isinstance( exc, modal_client_closed_error ): logger.info( "Remote interrupt monitor stopped after Modal client shutdown for component=%s.", component_id, ) stop_event.set() return False raise def consume_shared_cancel_flag() -> None: """Remove the shared interrupt flag if the Modal client is still alive.""" try: interrupt_store.pop(interrupt_flag_key, None) except Exception as exc: if modal_client_closed_error is not None and isinstance( exc, modal_client_closed_error ): logger.info( "Remote interrupt monitor skipped flag cleanup after Modal client shutdown for component=%s.", component_id, ) stop_event.set() return raise def monitor_interrupts() -> None: """Set ComfyUI's interrupt flag once the caller requests cancellation.""" nonlocal restart_scheduled while not stop_event.is_set(): if cancellation_event is not None and cancellation_event.wait(timeout=0.1): logger.info( "Remote interrupt monitor tripped local event for component=%s.", component_id, ) if not restart_scheduled: restart_scheduled = _schedule_remote_cancel_restart( component_id=component_id, completion_event=execution_completed_event, ) nodes.interrupt_processing() return if interrupt_store is None or interrupt_flag_key is None: continue if not shared_cancel_flag_exists(): continue logger.info( "Remote interrupt monitor observed shared cancel flag for component=%s.", component_id, ) consume_shared_cancel_flag() if stop_event.is_set(): return if cancellation_event is not None: cancellation_event.set() if not restart_scheduled: restart_scheduled = _schedule_remote_cancel_restart( component_id=component_id, completion_event=execution_completed_event, ) nodes.interrupt_processing() return interrupt_thread = threading.Thread( target=monitor_interrupts, name=f"modal-interrupt-{component_id}", daemon=True, ) interrupt_thread.start() try: yield finally: execution_completed_event.set() stop_event.set() interrupt_thread.join(timeout=1.0) def _ensure_default_custom_nodes_dir() -> Path | None: """Create the default ComfyUI custom_nodes directory when the image omits its contents.""" comfyui_root = _active_comfyui_root() if comfyui_root is None: return None custom_nodes_dir = comfyui_root / "custom_nodes" custom_nodes_dir.mkdir(parents=True, exist_ok=True) return custom_nodes_dir def _materialize_remote_asset_path(value: str) -> str: """Resolve a mirrored Modal asset reference to the container-local absolute file path.""" settings = get_settings() remote_storage_root = settings.remote_storage_root.rstrip("/") if value.startswith(f"{remote_storage_root}/"): return value if value.startswith("/"): volume_relative_roots = ( "/assets/", "/custom_nodes/", "/hashes/", "/input/", "/models/", "/output/", "/temp/", "/user/", ) if any(value.startswith(root) for root in volume_relative_roots): return f"{remote_storage_root}{value}" if value.startswith("/assets/"): return f"{remote_storage_root}{value}" return value def _readthrough_cache_path(volume_path: Path) -> Path | None: """Return the safe ephemeral cache path for one mounted-volume path.""" remote_storage_root = Path(get_settings().remote_storage_root).resolve() resolved_volume_path = volume_path.resolve() if not resolved_volume_path.is_relative_to(remote_storage_root): return None relative_path = resolved_volume_path.relative_to(remote_storage_root) return _REMOTE_VOLUME_READTHROUGH_ROOT / relative_path def _resolve_runtime_asset_path(value: str) -> str: """Resolve an asset through the mount first and the committed read-through cache second.""" materialized_path = Path(_materialize_remote_asset_path(value)) if not materialized_path.is_absolute() or materialized_path.exists(): return str(materialized_path) cache_path = _readthrough_cache_path(materialized_path) if cache_path is not None and cache_path.exists(): return str(cache_path) return str(materialized_path) def _clone_loader_cache_value(value: Any) -> Any: """Clone a cached loader output when the runtime object supports safe cloning.""" clone_method = getattr(value, "clone", None) if callable(clone_method): return clone_method() return value def _clone_loader_cache_outputs(outputs: tuple[Any, ...]) -> tuple[Any, ...]: """Return a request-safe copy of cached loader outputs.""" return tuple(_clone_loader_cache_value(output) for output in outputs) def _serialize_loader_cache_key(parts: dict[str, Any]) -> str: """Serialize a loader cache key into a stable string representation.""" return json.dumps(parts, sort_keys=True, default=str) def _build_unet_loader_cache_key(kwargs: dict[str, Any]) -> str: """Build a stable cache key for the ComfyUI UNET loader.""" import folder_paths return _serialize_loader_cache_key( { "unet_path": folder_paths.get_full_path_or_raise( "diffusion_models", str(kwargs["unet_name"]), ), "weight_dtype": kwargs.get("weight_dtype", "default"), } ) def _build_clip_loader_cache_key(kwargs: dict[str, Any]) -> str: """Build a stable cache key for the ComfyUI CLIP loader.""" import folder_paths return _serialize_loader_cache_key( { "clip_path": folder_paths.get_full_path_or_raise( "text_encoders", str(kwargs["clip_name"]), ), "type": kwargs.get("type", "stable_diffusion"), "device": kwargs.get("device", "default"), } ) def _build_dual_clip_loader_cache_key(kwargs: dict[str, Any]) -> str: """Build a stable cache key for the ComfyUI dual CLIP loader.""" import folder_paths return _serialize_loader_cache_key( { "clip_path_1": folder_paths.get_full_path_or_raise( "text_encoders", str(kwargs["clip_name1"]), ), "clip_path_2": folder_paths.get_full_path_or_raise( "text_encoders", str(kwargs["clip_name2"]), ), "type": kwargs.get("type"), "device": kwargs.get("device", "default"), } ) def _build_vae_loader_cache_key(kwargs: dict[str, Any]) -> str: """Build a stable cache key for the ComfyUI VAE loader.""" return _serialize_loader_cache_key({"vae_name": kwargs.get("vae_name")}) def _build_checkpoint_loader_cache_key(kwargs: dict[str, Any]) -> str: """Build a stable cache key for checkpoint-style model loaders.""" import folder_paths key_parts: dict[str, Any] = {} if "config_name" in kwargs: key_parts["config_path"] = folder_paths.get_full_path( "configs", str(kwargs["config_name"]) ) if "ckpt_name" in kwargs: key_parts["ckpt_path"] = folder_paths.get_full_path_or_raise( "checkpoints", str(kwargs["ckpt_name"]), ) if "model_path" in kwargs: key_parts["model_path"] = str(kwargs["model_path"]) return _serialize_loader_cache_key(key_parts) def _wrap_loader_method_with_cache( class_type: str, node_class: type[Any], method_name: str, cache_key_builder: Any, ) -> None: """Install a warm-container cache wrapper around a heavy loader method.""" if class_type in _LOADER_CACHE_WRAPPED_CLASSES: return original_method = getattr(node_class, method_name) method_signature = inspect.signature(original_method) def cached_method(self: Any, *args: Any, **kwargs: Any) -> tuple[Any, ...]: """Return cached loader outputs when an identical request was already loaded.""" bound = method_signature.bind(self, *args, **kwargs) bound.apply_defaults() normalized_kwargs = { key: value for key, value in bound.arguments.items() if key != "self" } cache_key = (class_type, cache_key_builder(normalized_kwargs)) with _LOADER_CACHE_LOCK: cached_outputs = _LOADER_OUTPUT_CACHE.get(cache_key) if cached_outputs is not None: _record_loader_cache_metric("hit") _emit_cloud_info( "Loader cache hit class_type=%s key=%s", class_type, cache_key[1] ) return _clone_loader_cache_outputs(cached_outputs) _record_loader_cache_metric("miss") _emit_cloud_info( "Loader cache miss class_type=%s key=%s", class_type, cache_key[1] ) outputs = original_method(self, *args, **kwargs) normalized_outputs = ( tuple(outputs) if isinstance(outputs, (list, tuple)) else (outputs,) ) with _LOADER_CACHE_LOCK: _LOADER_OUTPUT_CACHE[cache_key] = normalized_outputs return _clone_loader_cache_outputs(normalized_outputs) setattr(node_class, method_name, cached_method) _LOADER_CACHE_WRAPPED_CLASSES.add(class_type) def _install_loader_cache_wrappers() -> None: """Patch the heavyweight built-in model loaders to reuse warm-container state.""" nodes_module = _load_nodes_module() cacheable_loader_specs = { "CheckpointLoader": ("load_checkpoint", _build_checkpoint_loader_cache_key), "CheckpointLoaderSimple": ( "load_checkpoint", _build_checkpoint_loader_cache_key, ), "UNETLoader": ("load_unet", _build_unet_loader_cache_key), "CLIPLoader": ("load_clip", _build_clip_loader_cache_key), "DualCLIPLoader": ("load_clip", _build_dual_clip_loader_cache_key), "VAELoader": ("load_vae", _build_vae_loader_cache_key), "unCLIPCheckpointLoader": ( "load_checkpoint", _build_checkpoint_loader_cache_key, ), "ImageOnlyCheckpointLoader": ( "load_checkpoint", _build_checkpoint_loader_cache_key, ), } for class_type, (method_name, cache_key_builder) in cacheable_loader_specs.items(): node_class = nodes_module.NODE_CLASS_MAPPINGS.get(class_type) if node_class is None: continue _wrap_loader_method_with_cache( class_type, node_class, method_name, cache_key_builder ) def _alias_flux_rms_norm_weight_keys(state_dict: dict[str, Any]) -> int: """Add ComfyUI Flux RMSNorm `.scale` aliases for saved files that use `.weight`.""" alias_count = 0 replacements = { ".norm.key_norm.weight": ".norm.key_norm.scale", ".norm.query_norm.weight": ".norm.query_norm.scale", } for key, value in list(state_dict.items()): for source_suffix, target_suffix in replacements.items(): if not key.endswith(source_suffix): continue target_key = f"{key[: -len(source_suffix)]}{target_suffix}" if target_key in state_dict: continue state_dict[target_key] = value alias_count += 1 return alias_count def _install_model_state_dict_compatibility_wrappers() -> None: """Patch ComfyUI model loading for known cross-version saved-model key aliases.""" global _MODEL_STATE_DICT_COMPAT_WRAPPED if _MODEL_STATE_DICT_COMPAT_WRAPPED: return import comfy.sd original_load_diffusion_model_state_dict = comfy.sd.load_diffusion_model_state_dict def compatible_load_diffusion_model_state_dict( sd: dict[str, Any], *args: Any, **kwargs: Any, ) -> Any: """Load diffusion models after adding aliases while preserving ComfyUI's API.""" alias_count = _alias_flux_rms_norm_weight_keys(sd) if alias_count: logger.info( "Added %d Flux RMSNorm .scale aliases for a diffusion model state_dict saved with .weight keys.", alias_count, ) return original_load_diffusion_model_state_dict(sd, *args, **kwargs) comfy.sd.load_diffusion_model_state_dict = ( compatible_load_diffusion_model_state_dict ) _MODEL_STATE_DICT_COMPAT_WRAPPED = True def _rewrite_modal_asset_references(value: Any) -> Any: """Recursively replace mirrored asset markers with container-local absolute file paths.""" if isinstance(value, str): return _materialize_remote_asset_path(value) if isinstance(value, list): return [_rewrite_modal_asset_references(item) for item in value] if isinstance(value, dict): return { str(key): _rewrite_modal_asset_references(item) for key, item in value.items() } return value @contextmanager def _patched_folder_paths_absolute_lookup() -> Iterator[None]: """Teach ComfyUI folder lookups to accept absolute assets across overlapping callers.""" import folder_paths global _FOLDER_PATHS_PATCH_DEPTH global _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH global _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH_OR_RAISE with _FOLDER_PATHS_PATCH_LOCK: if _FOLDER_PATHS_PATCH_DEPTH == 0: original_get_full_path = folder_paths.get_full_path original_get_full_path_or_raise = folder_paths.get_full_path_or_raise _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH = original_get_full_path _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH_OR_RAISE = ( original_get_full_path_or_raise ) def patched_get_full_path(folder_name: str, filename: str) -> str | None: """Return an absolute file or delegate to ComfyUI's original lookup.""" resolved_filename = _resolve_runtime_asset_path(filename) if os.path.isabs(resolved_filename) and Path(resolved_filename).is_file(): return resolved_filename return original_get_full_path(folder_name, resolved_filename) def patched_get_full_path_or_raise(folder_name: str, filename: str) -> str: """Raise with the original message when no absolute or folder match exists.""" full_path = patched_get_full_path(folder_name, filename) if full_path is None: raise FileNotFoundError( f"Model in folder '{folder_name}' with filename '{filename}' not found." ) return full_path folder_paths.get_full_path = patched_get_full_path folder_paths.get_full_path_or_raise = patched_get_full_path_or_raise _FOLDER_PATHS_PATCH_DEPTH += 1 logger.debug( "Entered absolute folder-path lookup patch depth=%d.", _FOLDER_PATHS_PATCH_DEPTH, ) try: yield finally: with _FOLDER_PATHS_PATCH_LOCK: _FOLDER_PATHS_PATCH_DEPTH -= 1 logger.debug( "Exited absolute folder-path lookup patch depth=%d.", _FOLDER_PATHS_PATCH_DEPTH, ) if _FOLDER_PATHS_PATCH_DEPTH == 0: original_get_full_path = _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH original_get_full_path_or_raise = ( _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH_OR_RAISE ) if original_get_full_path is None or original_get_full_path_or_raise is None: raise RuntimeError("Absolute folder-path lookup patch lost its originals.") folder_paths.get_full_path = original_get_full_path folder_paths.get_full_path_or_raise = original_get_full_path_or_raise _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH = None _FOLDER_PATHS_ORIGINAL_GET_FULL_PATH_OR_RAISE = None def _ensure_comfy_runtime_initialized(custom_nodes_root: Path | None) -> None: """Initialize ComfyUI's built-in and external node registries for remote execution.""" global _COMFY_RUNTIME_BASE_INITIALIZED custom_nodes_root_key = ( str(custom_nodes_root.resolve()) if custom_nodes_root is not None else None ) with _COMFY_RUNTIME_INIT_LOCK: with _timed_phase( "ensure_comfy_runtime_initialized", custom_nodes=custom_nodes_root_key or "none", ): _ensure_comfyui_support_packages() _ensure_default_custom_nodes_dir() _ensure_headless_prompt_server_instance() nodes_module = _load_nodes_module() if not _COMFY_RUNTIME_BASE_INITIALIZED: if custom_nodes_root is not None: _register_custom_nodes_root(custom_nodes_root) logger.info( "Initializing remote ComfyUI node registry with built-in extras%s.", " and extracted custom nodes" if custom_nodes_root is not None else "", ) with _timed_phase( "init_extra_nodes", custom_nodes=bool(custom_nodes_root is not None), api_nodes=True, ): asyncio.run( nodes_module.init_extra_nodes( init_custom_nodes=custom_nodes_root is not None, init_api_nodes=True, ) ) _install_model_state_dict_compatibility_wrappers() _install_loader_cache_wrappers() _register_modal_sync_runtime_nodes(nodes_module) _COMFY_RUNTIME_BASE_INITIALIZED = True if custom_nodes_root_key is not None: _COMFY_RUNTIME_CUSTOM_NODE_ROOTS.add(custom_nodes_root_key) return if ( custom_nodes_root_key is None or custom_nodes_root_key in _COMFY_RUNTIME_CUSTOM_NODE_ROOTS ): logger.info( "Reusing initialized remote ComfyUI runtime for custom_nodes=%s without re-running custom node import.", custom_nodes_root_key or "", ) _install_model_state_dict_compatibility_wrappers() _install_loader_cache_wrappers() _register_modal_sync_runtime_nodes(nodes_module) return _register_custom_nodes_root(custom_nodes_root) logger.info( "Loading extracted remote custom nodes from %s.", custom_nodes_root ) with _timed_phase( "init_external_custom_nodes", custom_nodes=custom_nodes_root_key ): asyncio.run(nodes_module.init_external_custom_nodes()) _install_model_state_dict_compatibility_wrappers() _install_loader_cache_wrappers() _register_modal_sync_runtime_nodes(nodes_module) _COMFY_RUNTIME_CUSTOM_NODE_ROOTS.add(custom_nodes_root_key) def _register_modal_sync_runtime_nodes(nodes_module: Any) -> None: """Register nodes shipped in the deployment image without custom-node sync.""" from llm_profiles import MODAL_LLM_NODE_ID from modal_llm_node import ModalLLM existing_node = nodes_module.NODE_CLASS_MAPPINGS.get(MODAL_LLM_NODE_ID) if existing_node is not None and existing_node is not ModalLLM: logger.info( "Preserving custom-node registration for %s instead of replacing it.", MODAL_LLM_NODE_ID, ) return nodes_module.NODE_CLASS_MAPPINGS[MODAL_LLM_NODE_ID] = ModalLLM display_mappings = getattr(nodes_module, "NODE_DISPLAY_NAME_MAPPINGS", None) if isinstance(display_mappings, dict): display_mappings[MODAL_LLM_NODE_ID] = "Modal LLM" logger.info("Registered deployment-owned remote node %s.", MODAL_LLM_NODE_ID) def _prompt_missing_node_class_types( prompt: Mapping[str, Any], node_mapping: Mapping[str, type[Any]], ) -> list[str]: """Return sorted prompt class types that are absent from the active node registry.""" missing_class_types: set[str] = set() for prompt_node in prompt.values(): if not isinstance(prompt_node, Mapping): continue class_type = prompt_node.get("class_type") if isinstance(class_type, str) and class_type not in node_mapping: missing_class_types.add(class_type) return sorted(missing_class_types) def _reload_external_custom_nodes_for_missing_classes( custom_nodes_root: Path | None, ) -> None: """Re-run external custom-node import once when a prompt references missing node classes.""" if custom_nodes_root is None: return custom_nodes_root_key = str(custom_nodes_root.resolve()) with _COMFY_RUNTIME_INIT_LOCK: _register_custom_nodes_root(custom_nodes_root) logger.warning( "Re-running external custom-node import for %s because the active prompt referenced unregistered node classes.", custom_nodes_root_key, ) nodes_module = _load_nodes_module() with _timed_phase( "init_external_custom_nodes_retry", custom_nodes=custom_nodes_root_key ): asyncio.run(nodes_module.init_external_custom_nodes()) _install_loader_cache_wrappers() _COMFY_RUNTIME_CUSTOM_NODE_ROOTS.add(custom_nodes_root_key) def _iter_missing_class_candidate_files( custom_nodes_root: Path, class_type: str, *, max_candidates: int = 5, ) -> Iterator[Path]: """Yield Python files in the extracted bundle that mention one missing class type.""" yielded_count = 0 for candidate_path in sorted(custom_nodes_root.rglob("*.py")): if yielded_count >= max_candidates: return try: if class_type not in candidate_path.read_text( encoding="utf-8", errors="ignore" ): continue except OSError: continue yielded_count += 1 yield candidate_path def _custom_node_package_for_candidate_file( custom_nodes_root: Path, candidate_file: Path ) -> str: """Return the top-level extracted custom-node package name for one candidate file.""" try: relative_path = candidate_file.relative_to(custom_nodes_root) except ValueError: return str(candidate_file) if not relative_path.parts: return str(candidate_file) return relative_path.parts[0] def _missing_node_class_diagnostics( missing_class_types: Sequence[str], custom_nodes_root: Path | None, custom_nodes_bundle_path: str | None, ) -> str: """Return a concise diagnostic summary for missing prompt node classes.""" if custom_nodes_root is None: if custom_nodes_bundle_path: return ( "Payload requested custom_nodes_bundle=" f"{custom_nodes_bundle_path!r}, but it was not available in Modal worker storage." ) return "No custom_nodes_bundle path was present in the remote payload." if not custom_nodes_root.exists(): return f"Extracted custom_nodes root does not exist: {custom_nodes_root}." diagnostics: list[str] = [f"extracted_custom_nodes_root={custom_nodes_root}"] for class_type in missing_class_types: candidate_files = list( _iter_missing_class_candidate_files(custom_nodes_root, class_type) ) if not candidate_files: diagnostics.append( f"{class_type}: no matching Python file found in extracted bundle" ) continue rendered_candidates = [ f"{path.relative_to(custom_nodes_root)} (package={_custom_node_package_for_candidate_file(custom_nodes_root, path)})" for path in candidate_files ] diagnostics.append(f"{class_type}: found candidates {rendered_candidates}") return "; ".join(diagnostics) def _ensure_prompt_node_classes_registered( *, component_id: str, prompt: Mapping[str, Any], custom_nodes_root: Path | None, custom_nodes_bundle_path: str | None = None, ) -> Mapping[str, type[Any]]: """Return the active node mapping or raise a clear error for missing prompt node types.""" nodes_module = _load_nodes_module() resolved_node_mapping = nodes_module.NODE_CLASS_MAPPINGS missing_class_types = _prompt_missing_node_class_types( prompt, resolved_node_mapping ) if missing_class_types and custom_nodes_root is not None: logger.warning( "Remote prompt component=%s references missing node classes after initial custom-node import: %s", component_id, missing_class_types, ) _reload_external_custom_nodes_for_missing_classes(custom_nodes_root) resolved_node_mapping = nodes_module.NODE_CLASS_MAPPINGS missing_class_types = _prompt_missing_node_class_types( prompt, resolved_node_mapping ) if missing_class_types: raise RemoteSubgraphExecutionError( "Remote subgraph references node classes that are not registered in the Modal worker: " f"{missing_class_types}. Ensure custom-node sync is enabled and the required custom-node package " "imports successfully inside Modal. " f"Diagnostics: {_missing_node_class_diagnostics(missing_class_types, custom_nodes_root, custom_nodes_bundle_path)}" ) return resolved_node_mapping def _load_execution_module() -> Any: """Import the ComfyUI execution module lazily.""" _ensure_comfyui_support_packages() import execution return execution def _load_nodes_module() -> Any: """Import the ComfyUI nodes module lazily.""" import nodes return nodes def _prompt_executor_ram_thresholds( cache_ram_values: list[float], ) -> tuple[float, float]: """Return current ComfyUI active and inactive RAM-cache thresholds in GiB.""" model_management = importlib.import_module("comfy.model_management") active_threshold = min(10.0, max(2.0, model_management.total_ram * 0.10 / 1024.0)) inactive_threshold = min(128.0, model_management.total_ram / 1024.0) if cache_ram_values: active_threshold = cache_ram_values[0] if len(cache_ram_values) > 1: inactive_threshold = cache_ram_values[1] return active_threshold, inactive_threshold def _prompt_executor_cache_config(execution: Any) -> tuple[Any, dict[str, float]]: """Return cache settings compatible with legacy and current ComfyUI CLI shapes.""" from comfy.cli_args import args cache_ram = args.cache_ram if isinstance(cache_ram, list): active_threshold = 0.0 inactive_threshold = 0.0 if not args.cache_classic and not args.cache_none and args.cache_lru <= 0: active_threshold, inactive_threshold = _prompt_executor_ram_thresholds( cache_ram ) cache_type = execution.CacheType.RAM_PRESSURE if args.cache_classic: cache_type = execution.CacheType.CLASSIC elif args.cache_lru > 0: cache_type = execution.CacheType.LRU elif args.cache_none: cache_type = execution.CacheType.NONE return cache_type, { "lru": args.cache_lru, "ram": active_threshold, "ram_inactive": inactive_threshold, } cache_type = execution.CacheType.CLASSIC if args.cache_lru > 0: cache_type = execution.CacheType.LRU elif cache_ram > 0: cache_type = execution.CacheType.RAM_PRESSURE elif args.cache_none: cache_type = execution.CacheType.NONE return cache_type, {"lru": args.cache_lru, "ram": cache_ram} def _serialize_prompt_executor_cache_scope( cache_type: Any, cache_args: dict[str, Any], custom_nodes_root: Path | None, ) -> str: """Return a stable cache scope key for reusable PromptExecutor instances.""" return json.dumps( { "cache_type": str(cache_type), "cache_args": cache_args, "custom_nodes_root": str(custom_nodes_root.resolve()) if custom_nodes_root is not None else None, }, sort_keys=True, default=str, ) def _reset_prompt_executor_request_state(executor: Any, prompt_server: Any) -> None: """Prepare a reusable PromptExecutor for a fresh request without discarding its caches.""" executor.server = prompt_server executor.status_messages = [] executor.success = True executor.history_result = {} prompt_server.client_id = None prompt_server.last_node_id = None def _get_or_create_prompt_executor_state( execution: Any, prompt_server: Any, cache_type: Any, cache_args: dict[str, Any], custom_nodes_root: Path | None, ) -> _ReusablePromptExecutorState: """Return the warm-container PromptExecutor state for a cache scope, creating it once.""" state_key = _serialize_prompt_executor_cache_scope( cache_type, cache_args, custom_nodes_root ) with _PROMPT_EXECUTOR_STATES_LOCK: existing_state = _PROMPT_EXECUTOR_STATES.get(state_key) if existing_state is not None: _emit_cloud_info("Prompt executor cache hit scope=%s", state_key) return existing_state _emit_cloud_info("Prompt executor cache miss scope=%s", state_key) executor = execution.PromptExecutor( prompt_server, cache_type=cache_type, cache_args=cache_args, ) state = _ReusablePromptExecutorState(executor=executor, lock=threading.Lock()) _PROMPT_EXECUTOR_STATES[state_key] = state return state def _execute_prompt_executor_compat( executor: Any, *, prompt: dict[str, Any], prompt_id: str, extra_data: dict[str, Any], execute_outputs: list[str], ) -> None: """Execute a ComfyUI prompt across synchronous and asynchronous executor APIs.""" execution_result = executor.execute( prompt=prompt, prompt_id=prompt_id, extra_data=extra_data, execute_outputs=execute_outputs, ) if inspect.isawaitable(execution_result): asyncio.run(execution_result) def _install_metadata_safe_dynamic_prompt_wrapper(execution: Any) -> None: """Let hidden PROMPT inputs see metadata-safe graphs instead of hydrated tensors.""" with _DYNAMIC_PROMPT_WRAPPER_LOCK: dynamic_prompt_class = getattr(execution, "DynamicPrompt", None) if dynamic_prompt_class is None: raise RemoteSubgraphExecutionError( "The ComfyUI execution module does not expose DynamicPrompt." ) if bool(getattr(dynamic_prompt_class, "_comfy_modal_metadata_safe", False)): return class MetadataSafeDynamicPrompt(dynamic_prompt_class): """DynamicPrompt variant with a separate hidden-input metadata graph.""" _comfy_modal_metadata_safe = True def __init__(self, original_prompt: dict[str, Any]) -> None: """Capture the calling thread's metadata prompt before execution starts.""" super().__init__(original_prompt) self._comfy_modal_metadata_prompt = getattr( _PROMPT_METADATA_STATE, "prompt", None, ) def get_original_prompt(self) -> dict[str, Any]: """Return the JSON-safe graph exposed through ComfyUI's hidden PROMPT input.""" if self._comfy_modal_metadata_prompt is not None: return self._comfy_modal_metadata_prompt return super().get_original_prompt() execution.DynamicPrompt = MetadataSafeDynamicPrompt logger.info( "Installed metadata-safe DynamicPrompt wrapper for hydrated remote boundary inputs." ) @contextmanager def _temporary_prompt_metadata(prompt: dict[str, Any]) -> Iterator[None]: """Expose one JSON-safe hidden PROMPT graph to this execution thread.""" had_previous_prompt = hasattr(_PROMPT_METADATA_STATE, "prompt") previous_prompt = getattr(_PROMPT_METADATA_STATE, "prompt", None) _PROMPT_METADATA_STATE.prompt = prompt try: yield finally: if had_previous_prompt: _PROMPT_METADATA_STATE.prompt = previous_prompt else: delattr(_PROMPT_METADATA_STATE, "prompt") def _copy_json_safe_prompt_metadata(prompt: dict[str, Any]) -> dict[str, Any]: """Copy and validate the graph exposed to metadata-writing custom nodes.""" metadata_prompt = copy.deepcopy(prompt) try: json.dumps(metadata_prompt) except (TypeError, ValueError) as exc: raise RemoteSubgraphExecutionError( "Remote subgraph prompt metadata was not JSON-compatible before boundary hydration." ) from exc return metadata_prompt def _node_output_cache_store() -> Any | None: """Return the shared Modal Dict used for persisted transport-safe node outputs.""" if modal is None: return None return node_output_cache_store() def _node_output_cache_key_preview( cache_key: str | None, *, max_chars: int = 32 ) -> str: """Return a short human-readable prefix of one persisted node-cache key.""" if cache_key is None: return "" return cache_key[:max_chars] def _node_output_cache_value_preview(value: Any, *, max_chars: int = 160) -> str: """Return a truncated repr for node-cache debug logging.""" try: rendered = repr(value) except Exception as exc: # pragma: no cover - defensive logging path. rendered = f"" if len(rendered) <= max_chars: return rendered return f"{rendered[:max_chars]}..." def _tensor_cache_key_digest(value: Any) -> dict[str, Any]: """Return a stable digest payload for one tensor used inside a cache key.""" from safetensors.torch import save tensor = value.detach().contiguous().cpu() tensor_bytes = save({"value": tensor}) return { "kind": "tensor", "dtype": str(tensor.dtype), "shape": list(tensor.shape), "sha256": hashlib.sha256(tensor_bytes).hexdigest(), } async def _node_output_cache_store_get(cache_store: Any, cache_key: str) -> Any: """Return one persisted node-cache record, preferring Modal's async Dict interface.""" aio_get = getattr(getattr(cache_store, "get", None), "aio", None) if callable(aio_get): return await aio_get(cache_key) return cache_store.get(cache_key) async def _node_output_cache_store_put( cache_store: Any, cache_key: str, record: dict[str, Any], ) -> None: """Persist one node-cache record without blocking an active event loop.""" aio_put = getattr(getattr(cache_store, "put", None), "aio", None) if callable(aio_put): await aio_put(cache_key, record) return cache_store[cache_key] = record def _is_input_signature_cache_key_set(cache_key_set: Any) -> bool: """Return whether one cache-key set uses ComfyUI input-signature semantics.""" return all( hasattr(cache_key_set, attribute) for attribute in ( "dynprompt", "is_changed_cache", "get_ordered_ancestry", "include_node_id_in_input", ) ) def _include_unique_id_in_input_signature(class_type: str) -> bool: """Return whether ComfyUI includes the unique node id in this input signature.""" from comfy_execution.caching import include_unique_id_in_input return bool(include_unique_id_in_input(class_type)) def _build_node_output_cache_immediate_signature( cache_key_set: Any, *, dynprompt: Any, node_id: str, ancestor_order_mapping: dict[str, int], is_changed_value: Any, ) -> list[Any]: """Return one raw ComfyUI input-signature fragment before `to_hashable()` runs.""" if not dynprompt.has_node(node_id): return [float("NaN")] node = dynprompt.get_node(node_id) class_type = node["class_type"] class_def = _load_nodes_module().NODE_CLASS_MAPPINGS[class_type] signature: list[Any] = [class_type, is_changed_value] if ( cache_key_set.include_node_id_in_input() or (hasattr(class_def, "NOT_IDEMPOTENT") and class_def.NOT_IDEMPOTENT) or _include_unique_id_in_input_signature(class_type) ): signature.append(node_id) inputs = node["inputs"] boundary_input_signatures = node.get(_BOUNDARY_INPUT_SIGNATURES_KEY) for key in sorted(inputs.keys()): input_value = inputs[key] ancestor_socket = _cache_signature_link_output_index(input_value) ancestor_id = str(input_value[0]) if ancestor_socket is not None else None if ancestor_socket is not None and ancestor_id in ancestor_order_mapping: ancestor_index = int(ancestor_order_mapping[ancestor_id]) signature.append((key, ("ANCESTOR", ancestor_index, ancestor_socket))) else: boundary_signature = None if isinstance(boundary_input_signatures, dict): candidate_signature = boundary_input_signatures.get(str(key)) if candidate_signature is not None: boundary_signature = candidate_signature if boundary_signature is not None: signature.append((key, ("BOUNDARY_SOURCE", boundary_signature))) else: signature.append((key, input_value)) return signature def _cache_signature_link_output_index(value: Any) -> int | None: """Return a prompt-link output index when `value` is safe to treat as graph wiring.""" if not _is_link(value): return None output_index = _normalize_link_output_index(value[1]) if isinstance(output_index, bool): return None try: return int(output_index) except (TypeError, ValueError): return None async def _build_node_output_cache_signature_from_key_set_async( cache_key_set: Any, node_id: str, ) -> Any: """Return one distributed cache signature derived from a live ComfyUI cache-key set.""" if not _is_input_signature_cache_key_set(cache_key_set): return cache_key_set.get_data_key(node_id) dynprompt = cache_key_set.dynprompt ancestors, order_mapping = cache_key_set.get_ordered_ancestry(dynprompt, node_id) signature = [ _build_node_output_cache_immediate_signature( cache_key_set, dynprompt=dynprompt, node_id=node_id, ancestor_order_mapping=order_mapping, is_changed_value=await cache_key_set.is_changed_cache.get(node_id), ) ] for ancestor_id in ancestors: signature.append( _build_node_output_cache_immediate_signature( cache_key_set, dynprompt=dynprompt, node_id=str(ancestor_id), ancestor_order_mapping=order_mapping, is_changed_value=await cache_key_set.is_changed_cache.get(ancestor_id), ) ) return signature def _build_node_output_cache_signature_from_key_set_sync( cache_key_set: Any, node_id: str, ) -> Any | None: """Return one distributed cache signature using cached `is_changed` values only.""" if not _is_input_signature_cache_key_set(cache_key_set): return cache_key_set.get_data_key(node_id) cached_is_changed = getattr(cache_key_set.is_changed_cache, "is_changed", None) if not isinstance(cached_is_changed, dict): return None dynprompt = cache_key_set.dynprompt ancestors, order_mapping = cache_key_set.get_ordered_ancestry(dynprompt, node_id) all_node_ids = [str(node_id), *[str(ancestor_id) for ancestor_id in ancestors]] missing_node_ids = [ candidate for candidate in all_node_ids if candidate not in cached_is_changed ] if missing_node_ids: _emit_cloud_info( "Node output cache signature rebuild node=%s result=skip reason=missing-is-changed values=%s", node_id, missing_node_ids, ) return None return [ _build_node_output_cache_immediate_signature( cache_key_set, dynprompt=dynprompt, node_id=candidate, ancestor_order_mapping=order_mapping, is_changed_value=cached_is_changed[candidate], ) for candidate in all_node_ids ] def _canonicalize_node_output_cache_key_part( value: Any, *, path: str = "root", ) -> Any | None: """Return a JSON-stable representation of one CacheKeySetInputSignature fragment.""" value_type_name = type(value).__name__ if value_type_name == "Unhashable": _emit_cloud_info( "Node output cache canonicalization path=%s result=unhashable reason=comfy-unhashable-marker type=%s value=%s", path, value_type_name, _node_output_cache_value_preview(value), ) return None if value is None or isinstance(value, bool | int | str): return value if isinstance(value, float): if math.isnan(value): return {"kind": "float", "value": "nan"} if math.isinf(value): return {"kind": "float", "value": "inf" if value > 0 else "-inf"} return value if isinstance(value, bytes): return { "kind": "bytes", "value": base64.b64encode(value).decode("ascii"), } try: import torch except ModuleNotFoundError: torch = None if torch is not None and isinstance(value, torch.Tensor): return _tensor_cache_key_digest(value) if isinstance(value, tuple): items = [] for index, item in enumerate(value): child_path = f"{path}[{index}]" canonical_item = _canonicalize_node_output_cache_key_part( item, path=child_path, ) if canonical_item is None: _emit_cloud_info( "Node output cache canonicalization path=%s result=unhashable reason=tuple-child child_path=%s parent_type=%s parent_value=%s", path, child_path, value_type_name, _node_output_cache_value_preview(value), ) return None items.append(canonical_item) return {"kind": "tuple", "items": items} if isinstance(value, list): items = [] for index, item in enumerate(value): child_path = f"{path}[{index}]" canonical_item = _canonicalize_node_output_cache_key_part( item, path=child_path, ) if canonical_item is None: _emit_cloud_info( "Node output cache canonicalization path=%s result=unhashable reason=list-child child_path=%s parent_type=%s parent_value=%s", path, child_path, value_type_name, _node_output_cache_value_preview(value), ) return None items.append(canonical_item) return {"kind": "list", "items": items} if isinstance(value, dict): items: list[dict[str, Any]] = [] for key in sorted(value): rendered_key = _node_output_cache_value_preview(key, max_chars=48) key_path = f"{path}.key[{rendered_key}]" value_path = f"{path}[{rendered_key}]" canonical_key = _canonicalize_node_output_cache_key_part( key, path=key_path, ) canonical_value = _canonicalize_node_output_cache_key_part( value[key], path=value_path, ) if canonical_key is None: _emit_cloud_info( "Node output cache canonicalization path=%s result=unhashable reason=dict-key child_path=%s parent_type=%s parent_value=%s", path, key_path, value_type_name, _node_output_cache_value_preview(value), ) return None if canonical_value is None: _emit_cloud_info( "Node output cache canonicalization path=%s result=unhashable reason=dict-value key=%s child_path=%s parent_type=%s parent_value=%s", path, rendered_key, value_path, value_type_name, _node_output_cache_value_preview(value), ) return None items.append({"key": canonical_key, "value": canonical_value}) return {"kind": "dict", "items": items} if isinstance(value, frozenset): canonical_items: list[Any] = [] for index, item in enumerate( sorted( value, key=lambda item: _node_output_cache_value_preview(item, max_chars=120), ) ): child_path = f"{path}{{{index}}}" canonical_item = _canonicalize_node_output_cache_key_part( item, path=child_path, ) if canonical_item is None: _emit_cloud_info( "Node output cache canonicalization path=%s result=unhashable reason=frozenset-child child_path=%s parent_type=%s parent_value=%s", path, child_path, value_type_name, _node_output_cache_value_preview(value), ) return None canonical_items.append(canonical_item) canonical_items.sort( key=lambda item: json.dumps( item, sort_keys=True, separators=(",", ":"), ) ) return {"kind": "frozenset", "items": canonical_items} _emit_cloud_info( "Node output cache canonicalization path=%s result=unhashable reason=unsupported-type type=%s value=%s", path, value_type_name, _node_output_cache_value_preview(value), ) return None def _node_output_cache_key(signature: Any) -> str | None: """Return the persisted Modal Dict key for one ComfyUI cache signature.""" canonical_signature = _canonicalize_node_output_cache_key_part(signature) if canonical_signature is None: return None signature_payload = json.dumps( canonical_signature, sort_keys=True, separators=(",", ":"), ).encode("utf-8") signature_digest = hashlib.sha256(signature_payload).hexdigest() return f"{_NODE_OUTPUT_CACHE_KEY_PREFIX}{signature_digest}" async def _node_output_cache_key_from_key_set_async( cache_key_set: Any, node_id: str, ) -> str | None: """Return the persisted Modal Dict key for one live ComfyUI cache-key-set node.""" return _node_output_cache_key( await _build_node_output_cache_signature_from_key_set_async( cache_key_set, node_id, ) ) def _node_output_cache_key_from_key_set_sync( cache_key_set: Any, node_id: str, ) -> str | None: """Return the persisted Modal Dict key for one executed ComfyUI cache-key-set node.""" signature = _build_node_output_cache_signature_from_key_set_sync( cache_key_set, node_id ) if signature is None: return None return _node_output_cache_key(signature) def _estimate_node_output_cache_value_size_bytes( value: Any, *, byte_limit: int, ) -> int | None: """Return a best-effort raw-size estimate for one transport-safe value.""" if byte_limit < 0: return None if value is None or isinstance(value, bool): return 1 if isinstance(value, int): return 8 if isinstance(value, float): return 8 if isinstance(value, str): return len(value.encode("utf-8")) if isinstance(value, bytes): return len(value) try: import torch except ModuleNotFoundError: torch = None if torch is not None and isinstance(value, torch.Tensor): return int(value.numel()) * int(value.element_size()) if isinstance(value, tuple | list): total_size = 0 for item in value: item_size = _estimate_node_output_cache_value_size_bytes( item, byte_limit=byte_limit ) if item_size is None: return None total_size += item_size if total_size > byte_limit: return total_size return total_size if isinstance(value, dict): total_size = 0 for key, item in value.items(): total_size += len(str(key).encode("utf-8")) if total_size > byte_limit: return total_size item_size = _estimate_node_output_cache_value_size_bytes( item, byte_limit=byte_limit ) if item_size is None: return None total_size += item_size if total_size > byte_limit: return total_size return total_size return None def _serialize_node_output_cache_entry( cache_entry: Any, *, max_bytes: int, ) -> dict[str, Any] | None: """Return a persisted node-cache record when the outputs are safe and small enough.""" if max_bytes <= 0: return None outputs_size = _estimate_node_output_cache_value_size_bytes( list(getattr(cache_entry, "outputs", [])), byte_limit=max_bytes, ) if outputs_size is None or outputs_size > max_bytes: return None try: serialized_outputs = serialize_node_outputs( tuple(getattr(cache_entry, "outputs", [])) ) except TypeError: return None ui_payload: Any | None = None ui_value = getattr(cache_entry, "ui", None) if ui_value is not None: ui_size = _estimate_node_output_cache_value_size_bytes( ui_value, byte_limit=max_bytes ) if ui_size is not None and ui_size <= max_bytes: try: ui_payload = serialize_value(ui_value) except TypeError: ui_payload = None return { "version": _NODE_OUTPUT_CACHE_RECORD_VERSION, "outputs_zlib": zlib.compress(serialized_outputs), "outputs_size_bytes": outputs_size, "ui": ui_payload, } def _deserialize_node_output_cache_entry( execution: Any, record: Any, ) -> Any | None: """Return a ComfyUI CacheEntry reconstructed from one persisted Modal Dict record.""" if not isinstance(record, dict): return None if int(record.get("version", -1)) != _NODE_OUTPUT_CACHE_RECORD_VERSION: return None compressed_outputs = record.get("outputs_zlib") if not isinstance(compressed_outputs, (bytes, bytearray)): return None try: outputs = list( deserialize_node_outputs(zlib.decompress(bytes(compressed_outputs))) ) except (TypeError, ValueError, zlib.error): return None ui_payload = record.get("ui") try: ui_value = deserialize_value(ui_payload) if ui_payload is not None else None except TypeError: ui_value = None return execution.CacheEntry(ui=ui_value, outputs=outputs) async def _await_maybe(value: Any) -> Any: """Await an asynchronous compatibility result or return a synchronous value.""" if inspect.isawaitable(value): return await value return value def _prompt_executor_cache_get_sync(outputs_cache: Any, node_id: str) -> Any | None: """Read one prepared cache entry without leaking a coroutine into synchronous code.""" local_getter = getattr(outputs_cache, "get_local", None) if callable(local_getter): return local_getter(node_id) cache_entry = outputs_cache.get(node_id) if not inspect.isawaitable(cache_entry): return cache_entry try: asyncio.get_running_loop() except RuntimeError: return asyncio.run(cache_entry) if inspect.iscoroutine(cache_entry): cache_entry.close() raise RuntimeError( "ComfyUI exposed an asynchronous outputs cache without the synchronous get_local API." ) async def _restore_persisted_node_output_cache_entries( execution: Any, executor: Any, *, prompt_id: str, prompt: dict[str, Any], cache_store: Any, required_materialized_node_ids: Iterable[str] | None = None, restored_cache_keys_by_node_id: dict[str, str] | None = None, ) -> list[str]: """Hydrate PromptExecutor output-cache misses from the shared Modal Dict.""" outputs_cache = executor.caches.outputs dynamic_prompt = execution.DynamicPrompt(prompt) is_changed_cache = execution.IsChangedCache( prompt_id, dynamic_prompt, outputs_cache ) await _await_maybe( outputs_cache.set_prompt(dynamic_prompt, prompt.keys(), is_changed_cache) ) outputs_cache.clean_unused() return await _restore_persisted_node_output_cache_entries_into_prepared_cache( execution, outputs_cache, prompt=prompt, cache_store=cache_store, required_materialized_node_ids=required_materialized_node_ids, restored_cache_keys_by_node_id=restored_cache_keys_by_node_id, ) def _node_output_cache_ancestor_ids(cache_key_set: Any, node_id: str) -> set[str]: """Return the prompt ancestor ids used by one ComfyUI input-signature cache key.""" if not _is_input_signature_cache_key_set(cache_key_set): return set() dynprompt = cache_key_set.dynprompt if not dynprompt.has_node(node_id): return set() ancestors, _order_mapping = cache_key_set.get_ordered_ancestry(dynprompt, node_id) return {str(ancestor_id) for ancestor_id in ancestors} async def _restore_persisted_node_output_cache_entries_into_prepared_cache( execution: Any, outputs_cache: Any, *, prompt: dict[str, Any], cache_store: Any, required_materialized_node_ids: Iterable[str] | None = None, restored_cache_keys_by_node_id: dict[str, str] | None = None, ) -> list[str]: """Hydrate one already-prepared PromptExecutor outputs cache from the shared Modal Dict.""" restored_node_ids: list[str] = [] pending_lookup_tasks: list[asyncio.Task[_NodeOutputCacheLookupResult]] = [] required_node_ids = { str(node_id) for node_id in (required_materialized_node_ids or []) if str(node_id) in prompt } local_node_ids: set[str] = set() async def lookup_node(node_id: str) -> _NodeOutputCacheLookupResult: """Resolve one distributed cache candidate without mutating the live outputs cache.""" cache_key = await _node_output_cache_key_from_key_set_async( outputs_cache.cache_key_set, node_id ) if cache_key is None: return _NodeOutputCacheLookupResult( node_id=node_id, cache_key=None, raw_record=None, cache_entry=None, ) raw_record = await _node_output_cache_store_get(cache_store, cache_key) return _NodeOutputCacheLookupResult( node_id=node_id, cache_key=cache_key, raw_record=raw_record, cache_entry=_deserialize_node_output_cache_entry(execution, raw_record), ) for node_id in prompt: if await _await_maybe(outputs_cache.get(node_id)) is not None: _emit_cloud_info( "Node output cache lookup node=%s result=local-hit", node_id, ) local_node_ids.add(str(node_id)) continue pending_lookup_tasks.append(asyncio.create_task(lookup_node(str(node_id)))) if not pending_lookup_tasks: return restored_node_ids lookup_results = await asyncio.gather(*pending_lookup_tasks) restorable_node_ids = { lookup_result.node_id for lookup_result in lookup_results if lookup_result.cache_key is not None and lookup_result.cache_entry is not None } available_node_ids = local_node_ids | restorable_node_ids for lookup_result in lookup_results: node_id = lookup_result.node_id cache_key = lookup_result.cache_key if cache_key is None: _emit_cloud_info( "Node output cache lookup node=%s key_prefix=%s result=skip reason=key-unhashable", node_id, _node_output_cache_key_preview(cache_key), ) continue raw_record = lookup_result.raw_record cache_entry = lookup_result.cache_entry if cache_entry is None: result = "miss" if raw_record is not None: result = "miss-invalid" _emit_cloud_info( "Node output cache lookup node=%s key_prefix=%s result=%s", node_id, _node_output_cache_key_preview(cache_key), result, ) continue missing_required_ancestors = sorted( required_node_ids & _node_output_cache_ancestor_ids(outputs_cache.cache_key_set, node_id) - available_node_ids ) if missing_required_ancestors: _emit_cloud_info( "Node output cache lookup node=%s key_prefix=%s result=skip reason=missing-required-boundary-ancestors ancestors=%s", node_id, _node_output_cache_key_preview(cache_key), missing_required_ancestors, ) continue await _await_maybe(outputs_cache.set(node_id, cache_entry)) _emit_cloud_info( "Node output cache lookup node=%s key_prefix=%s result=hit", node_id, _node_output_cache_key_preview(cache_key), ) if restored_cache_keys_by_node_id is not None: restored_cache_keys_by_node_id[str(node_id)] = cache_key restored_node_ids.append(str(node_id)) return restored_node_ids def _install_prompt_executor_persisted_cache_restore( execution: Any, executor: Any, *, component_id: str, prompt: dict[str, Any], cache_store: Any, required_materialized_node_ids: Iterable[str] | None = None, ) -> _PersistedNodeCacheRestoreState: """Patch one executor so persisted-cache restore runs after its live `set_prompt()` call.""" restored_node_ids: list[str] = [] restored_cache_keys_by_node_id: dict[str, str] = {} outputs_cache = executor.caches.outputs original_set_prompt = outputs_cache.set_prompt async def wrapped_set_prompt( dynprompt: Any, node_ids: Any, is_changed_cache: Any ) -> None: await original_set_prompt(dynprompt, node_ids, is_changed_cache) with _timed_phase("restore_persisted_node_cache", component=component_id): restored_cache_keys_by_node_id.clear() restored_node_ids[ : ] = await _restore_persisted_node_output_cache_entries_into_prepared_cache( execution, outputs_cache, prompt=prompt, cache_store=cache_store, required_materialized_node_ids=required_materialized_node_ids, restored_cache_keys_by_node_id=restored_cache_keys_by_node_id, ) outputs_cache.set_prompt = wrapped_set_prompt def restore_original_method() -> None: outputs_cache.set_prompt = original_set_prompt return _PersistedNodeCacheRestoreState( restored_node_ids=restored_node_ids, restored_cache_keys_by_node_id=restored_cache_keys_by_node_id, restore_original_method=restore_original_method, ) def _emit_restored_node_cache_events( status_callback: Callable[[dict[str, Any]], None] | None, restored_node_ids: Sequence[str], ) -> None: """Publish one status event per node whose outputs were restored from the persisted cache.""" if status_callback is None: return for node_id in restored_node_ids: safe_node_id = str(node_id) status_callback( { "event_type": "node_cached", "node_id": safe_node_id, "display_node_id": safe_node_id, "real_node_id": safe_node_id, } ) def _boundary_output_node_ids( boundary_outputs: Iterable[Mapping[str, Any]] ) -> set[str]: """Return node ids whose local cache entries must exist for boundary collection.""" return { str(boundary_output.get("node_id")) for boundary_output in boundary_outputs if boundary_output.get("node_id") is not None } async def _persist_node_output_cache_entries( executor: Any, *, prompt: dict[str, Any], cache_store: Any, restored_cache_keys_by_node_id: dict[str, str] | None = None, ) -> list[str]: """Persist eligible PromptExecutor cache entries into the shared Modal Dict.""" max_bytes = get_settings().node_output_cache_max_bytes if max_bytes <= 0: return [] outputs_cache = executor.caches.outputs cache_key_set = getattr(outputs_cache, "cache_key_set", None) if cache_key_set is None: return [] persisted_node_ids: list[str] = [] for node_id in prompt: cache_entry = await _await_maybe(outputs_cache.get(node_id)) if cache_entry is None: _emit_cloud_info( "Node output cache write node=%s result=skip reason=no-local-cache-entry", node_id, ) continue cache_key = _node_output_cache_key_from_key_set_sync( cache_key_set, str(node_id) ) if cache_key is None: _emit_cloud_info( "Node output cache write node=%s key_prefix=%s result=skip reason=key-unhashable", node_id, _node_output_cache_key_preview(cache_key), ) continue restored_cache_key = None if restored_cache_keys_by_node_id is not None: restored_cache_key = restored_cache_keys_by_node_id.get(str(node_id)) if restored_cache_key == cache_key: _emit_cloud_info( "Node output cache write node=%s key_prefix=%s result=skip reason=restored-hit", node_id, _node_output_cache_key_preview(cache_key), ) continue record = _serialize_node_output_cache_entry(cache_entry, max_bytes=max_bytes) if record is None: _emit_cloud_info( "Node output cache write node=%s key_prefix=%s result=skip reason=ineligible-or-oversize", node_id, _node_output_cache_key_preview(cache_key), ) continue await _node_output_cache_store_put(cache_store, cache_key, record) _emit_cloud_info( "Node output cache write node=%s key_prefix=%s result=write outputs_size_bytes=%s", node_id, _node_output_cache_key_preview(cache_key), record.get("outputs_size_bytes"), ) persisted_node_ids.append(str(node_id)) return persisted_node_ids def _invoke_original_node( node_class: type[Any], node_data: dict[str, Any], kwargs: dict[str, Any], ) -> tuple[Any, ...]: """Execute an original V1 or V3 node class and normalize its outputs.""" class_type = node_data["class_type"] logger.info("Executing remote node %s", class_type) if hasattr(node_class, "GET_SCHEMA"): node_output = node_class.execute(**kwargs) if hasattr(node_output, "result"): result = node_output.result return tuple(result) if result is not None else tuple() return tuple(node_output) instance = node_class() function_name = getattr(node_class, "FUNCTION", "execute") function = getattr(instance, function_name) result = function(**kwargs) if result is None: return tuple() if isinstance(result, tuple): return result if isinstance(result, list): return tuple(result) return (result,) def execute_node_locally( node_data: dict[str, Any], kwargs_payload: bytes | bytearray | str | dict[str, Any], node_mapping: dict[str, type[Any]] | None = None, cancellation_event: threading.Event | None = None, interrupt_store: Any | None = None, interrupt_flag_key: str | None = None, ) -> bytes: """Execute a single target node in-process and return serialized outputs.""" outputs = _execute_node_locally_raw( node_data, kwargs_payload, node_mapping=node_mapping, cancellation_event=cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ) return serialize_node_outputs(outputs) def _execute_node_locally_raw( node_data: dict[str, Any], kwargs_payload: bytes | bytearray | str | dict[str, Any], node_mapping: dict[str, type[Any]] | None = None, cancellation_event: threading.Event | None = None, interrupt_store: Any | None = None, interrupt_flag_key: str | None = None, ) -> tuple[Any, ...]: """Execute a single target node in-process and return raw node outputs.""" custom_nodes_root = _extract_custom_nodes_bundle( node_data.get("custom_nodes_bundle") ) _ensure_comfy_runtime_initialized(custom_nodes_root) kwargs = _rewrite_modal_asset_references(deserialize_node_inputs(kwargs_payload)) component_id = str( node_data.get("component_id") or node_data.get("class_type") or "single-node" ) if node_mapping is not None: class_type = node_data["class_type"] if class_type not in node_mapping: raise KeyError(f"Remote node class {class_type!r} is not registered.") with ( _patched_folder_paths_absolute_lookup(), _temporary_remote_interrupt_monitor( component_id, cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ), ): return _invoke_original_node(node_mapping[class_type], node_data, kwargs) with _temporary_node_mapping(node_mapping): resolved_node_mapping = _load_nodes_module().NODE_CLASS_MAPPINGS class_type = node_data["class_type"] if class_type not in resolved_node_mapping: raise KeyError(f"Remote node class {class_type!r} is not registered.") with ( _patched_folder_paths_absolute_lookup(), _temporary_remote_interrupt_monitor( component_id, cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ), ): return _invoke_original_node( resolved_node_mapping[class_type], node_data, kwargs ) def _remote_session_ref_cache_signature(value: Any) -> Any | None: """Return cache-key metadata for any remote-session refs nested in `value`.""" if is_remote_session_bridge_ref_payload(value): return { "kind": "remote_session_bridge_ref", "bridge_key": value.get("bridge_key"), "node_id": value.get("node_id"), "output_index": value.get("output_index"), } if is_remote_session_value_ref_payload(value): return { "kind": "remote_session_value_ref", "session_id": value.get("session_id"), "node_id": value.get("node_id"), "output_index": value.get("output_index"), } if isinstance(value, list): items = [_remote_session_ref_cache_signature(item) for item in value] if any(item is not None for item in items): return {"kind": "list", "items": items} return None if isinstance(value, tuple): items = [_remote_session_ref_cache_signature(item) for item in value] if any(item is not None for item in items): return {"kind": "tuple", "items": items} return None if isinstance(value, Mapping): items = { str(key): _remote_session_ref_cache_signature(item) for key, item in value.items() } filtered_items = {key: item for key, item in items.items() if item is not None} if filtered_items: return {"kind": "mapping", "items": filtered_items} return None def _boundary_input_cache_signature( *, source_signature: Any, cache_value: Any, ) -> Any | None: """Return a cache signature for one boundary input and its unresolved source value.""" ref_signature = _remote_session_ref_cache_signature(cache_value) if ref_signature is None: if isinstance(source_signature, str) and source_signature: return source_signature return None return { "source_signature": source_signature if isinstance(source_signature, str) else None, "remote_session_refs": ref_signature, } def _apply_boundary_inputs( prompt: dict[str, Any], boundary_input_specs: list[dict[str, Any]], hydrated_inputs: dict[str, Any], cache_signature_inputs: dict[str, Any] | None = None, ) -> None: """Inject hydrated local boundary inputs into a remote subgraph prompt.""" for boundary_input in boundary_input_specs: proxy_input_name = str(boundary_input["proxy_input_name"]) if proxy_input_name not in hydrated_inputs: raise KeyError(f"Missing hydrated boundary input {proxy_input_name!r}.") value = hydrated_inputs[proxy_input_name] io_type = ( str(boundary_input["io_type"]) if boundary_input.get("io_type") is not None else None ) for target in boundary_input.get("targets", []): node_id = str(target["node_id"]) input_name = str(target["input_name"]) prompt_node = prompt[node_id] prompt_node["inputs"][input_name] = _normalize_prompt_input_value( value, io_type=io_type, ) cache_signature = _boundary_input_cache_signature( source_signature=boundary_input.get("source_signature"), cache_value=( cache_signature_inputs.get(proxy_input_name) if cache_signature_inputs is not None and proxy_input_name in cache_signature_inputs else value ), ) if cache_signature is not None: boundary_signatures = prompt_node.setdefault( _BOUNDARY_INPUT_SIGNATURES_KEY, {} ) if isinstance(boundary_signatures, dict): boundary_signatures[input_name] = cache_signature def _collapse_cache_slot(slot_values: Any, is_list: bool) -> Any: """Convert a PromptExecutor cache slot back into a node-style output value.""" if is_list: return slot_values if not isinstance(slot_values, list): return slot_values if len(slot_values) == 1: return slot_values[0] return slot_values def _extract_prompt_executor_error(executor: Any) -> str: """Extract a useful failure message from a PromptExecutor run.""" for event, data in reversed(executor.status_messages): if event == "execution_error": return _format_prompt_executor_error_payload(data) if event == "execution_interrupted": return "Remote subgraph execution was interrupted." return "Remote subgraph execution failed." def _format_prompt_executor_error_payload(data: Any) -> str: """Return a richer human-readable PromptExecutor failure message when available.""" if not isinstance(data, dict): return "Remote subgraph execution failed." message = str(data.get("exception_message") or "Remote subgraph execution failed.") node_id = data.get("node_id") node_type = data.get("node_type") current_inputs = data.get("current_inputs") if node_id is None and node_type is None and not current_inputs: return message details: list[str] = [message] if node_id is not None or node_type is not None: details.append(f"node_id={node_id!r} node_type={node_type!r}") if current_inputs: details.append(f"current_inputs={current_inputs!r}") return " | ".join(details) def _extract_prompt_executor_error_payload(executor: Any) -> dict[str, Any] | None: """Return the most recent PromptExecutor execution_error payload when present.""" for event, data in reversed(executor.status_messages): if event == "execution_error" and isinstance(data, dict): return data return None def _summarize_suspicious_prompt_inputs(prompt: dict[str, Any]) -> list[str]: """Return compact descriptions of prompt inputs that still look list-wrapped.""" findings: list[str] = [] for node_id, node_info in sorted(prompt.items()): inputs = node_info.get("inputs") or {} for input_name, input_value in inputs.items(): if isinstance(input_value, list) and len(input_value) == 1: findings.append(f"{node_id}.{input_name}={input_value!r}") continue if ( isinstance(input_value, list) and len(input_value) == 2 and isinstance(input_value[0], str) and isinstance(input_value[1], list) ): findings.append(f"{node_id}.{input_name}={input_value!r}") return findings def _node_input_types( node_class: type[Any], live_inputs: dict[str, Any] | None = None, ) -> dict[str, Any]: """Return one node class's input schema finalized for the live prompt inputs.""" input_types_callable = getattr(node_class, "INPUT_TYPES", None) if not callable(input_types_callable): return {} raw_input_types = input_types_callable() if not isinstance(raw_input_types, dict): return {} has_v3_dynamic_inputs = any( isinstance(input_config, tuple) and bool(input_config) and isinstance(input_config[0], str) and input_config[0].startswith("COMFY_") and input_config[0].endswith("_V3") for section_name in ("required", "optional") for input_config in ( raw_input_types.get(section_name, {}).values() if isinstance(raw_input_types.get(section_name), dict) else () ) ) if not has_v3_dynamic_inputs: return raw_input_types from comfy_api.latest import _io finalized_input_types, _, _ = _io.get_finalized_class_inputs( raw_input_types, live_inputs or {}, ) logger.debug( "Finalized V3 input schema for %s against prompt inputs %s.", node_class.__name__, sorted(str(input_name) for input_name in (live_inputs or {})), ) return finalized_input_types def _node_input_type_map( node_class: type[Any], live_inputs: dict[str, Any] | None = None, ) -> dict[str, str]: """Return one node class's finalized input types keyed by prompt input name.""" input_types = _node_input_types(node_class, live_inputs) input_type_map: dict[str, str] = {} for section_name in ("required", "optional", "hidden"): section = input_types.get(section_name) if not isinstance(section, dict): continue for input_name, input_config in section.items(): if not isinstance(input_config, tuple) or not input_config: continue declared_type = input_config[0] if isinstance(declared_type, str): input_type_map[str(input_name)] = declared_type return input_type_map def _node_required_input_names( node_class: type[Any], live_inputs: dict[str, Any] | None = None, ) -> set[str]: """Return required input names after expanding V3 dynamic prompt inputs.""" required_inputs = _node_input_types(node_class, live_inputs).get("required") if not isinstance(required_inputs, dict): return set() return {str(input_name) for input_name in required_inputs} def _coerce_primitive_prompt_input_value( *, node_id: str, class_type: str, input_name: str, declared_type: str, input_value: Any, ) -> Any: """Coerce one primitive prompt literal using ComfyUI's `validate_inputs` semantics.""" literal_value = ( input_value.get("__value__") if isinstance(input_value, dict) and "__value__" in input_value else input_value ) if isinstance(literal_value, list): return input_value try: if declared_type == "INT": return int(literal_value) if declared_type == "FLOAT": return float(literal_value) if declared_type == "STRING": return str(literal_value) if declared_type == "BOOLEAN": return bool(literal_value) except (OverflowError, TypeError, ValueError) as exc: raise RemoteSubgraphExecutionError( "Remote subgraph input could not be coerced to the declared primitive socket type." f" node_id={node_id!r} node_type={class_type!r}" f" input_name={input_name!r} declared_type={declared_type!r}" f" received_value={literal_value!r}" ) from exc return input_value def _coerce_prompt_primitive_input_values( prompt: dict[str, Any], node_mapping: dict[str, type[Any]], ) -> None: """Mutate prompt literals in-place to match ComfyUI's primitive widget coercion.""" for node_id, prompt_node in sorted(prompt.items()): class_type = str(prompt_node.get("class_type")) node_class = node_mapping.get(class_type) if node_class is None: continue inputs = prompt_node.get("inputs") or {} input_type_map = _node_input_type_map(node_class, inputs) if not input_type_map: continue for input_name, input_value in list(inputs.items()): declared_type = input_type_map.get(str(input_name)) if declared_type not in _PRIMITIVE_WIDGET_INPUT_TYPES: continue if ( isinstance(input_value, list) and len(input_value) == 2 and isinstance(input_value[0], str) ): continue coerced_value = _coerce_primitive_prompt_input_value( node_id=str(node_id), class_type=class_type, input_name=str(input_name), declared_type=declared_type, input_value=input_value, ) if coerced_value is not input_value: logger.debug( "Coerced remote primitive input %s.%s from %r to %r for type %s.", node_id, input_name, input_value, coerced_value, declared_type, ) inputs[input_name] = coerced_value def _validate_prompt_input_shapes( prompt: dict[str, Any], node_mapping: dict[str, type[Any]], boundary_input_specs: list[dict[str, Any]] | None = None, ) -> None: """Reject prompt inputs that still look invalid for primitive widget sockets.""" boundary_targets = { (str(target.get("node_id")), str(target.get("input_name"))) for boundary_input in (boundary_input_specs or []) for target in boundary_input.get("targets", []) if target.get("node_id") is not None and target.get("input_name") is not None } for node_id, prompt_node in sorted(prompt.items()): class_type = str(prompt_node.get("class_type")) node_class = node_mapping.get(class_type) if node_class is None: continue inputs = prompt_node.get("inputs") or {} input_type_map = _node_input_type_map(node_class, inputs) if not input_type_map: continue for input_name, input_value in inputs.items(): declared_type = input_type_map.get(str(input_name)) if declared_type not in _PRIMITIVE_WIDGET_INPUT_TYPES: continue if ( isinstance(input_value, list) and len(input_value) == 2 and isinstance(input_value[0], str) ): continue if (str(node_id), str(input_name)) in boundary_targets: continue literal_value = ( input_value.get("__value__") if isinstance(input_value, dict) and "__value__" in input_value else input_value ) if isinstance(literal_value, list): raise RemoteSubgraphExecutionError( "Remote subgraph input has an invalid list value for a primitive socket." f" node_id={node_id!r} node_type={class_type!r}" f" input_name={input_name!r} declared_type={declared_type!r}" f" received_value={literal_value!r}" ) def _validate_required_prompt_inputs( prompt: dict[str, Any], node_mapping: dict[str, type[Any]], ) -> None: """Reject remote prompt nodes that are missing declared required inputs.""" for node_id, prompt_node in sorted(prompt.items()): class_type = str(prompt_node.get("class_type")) node_class = node_mapping.get(class_type) if node_class is None: continue inputs = prompt_node.get("inputs") or {} missing_inputs = sorted( _node_required_input_names(node_class, inputs) - set(inputs.keys()) ) if not missing_inputs: continue raise RemoteSubgraphExecutionError( "Remote subgraph prompt is missing required node inputs before execution." f" node_id={node_id!r} node_type={class_type!r}" f" missing_inputs={missing_inputs!r} available_inputs={sorted(str(key) for key in inputs)!r}" ) def _log_prompt_executor_failure_details( *, component_id: str, prompt: dict[str, Any], normalized_payload: dict[str, Any], executor: Any, ) -> None: """Emit high-signal diagnostics for one remote PromptExecutor failure.""" error_payload = _extract_prompt_executor_error_payload(executor) suspicious_inputs = _summarize_suspicious_prompt_inputs(prompt) logger.error( "Remote PromptExecutor failed for component=%s execute_node_ids=%s boundary_outputs=%s suspicious_inputs=%s error_payload=%s", component_id, normalized_payload.get("execute_node_ids", []), [ { "node_id": boundary_output.get("node_id"), "output_index": boundary_output.get("output_index"), } for boundary_output in normalized_payload.get("boundary_outputs", []) ], suspicious_inputs, error_payload, ) def _resolve_required_subgraph_nodes( prompt: dict[str, Any], execute_node_ids: list[str], ) -> list[str]: """Return the dependency closure needed to execute the requested subgraph nodes.""" required: set[str] = set() pending = list(execute_node_ids) logger.info( "Resolving dependency closure for remote execute targets: %s", execute_node_ids ) while pending: node_id = str(pending.pop()) if node_id not in prompt: logger.warning( "Skipping missing remote execute target %s while resolving dependency closure.", node_id, ) continue if node_id in required: continue required.add(node_id) for input_value in (prompt[node_id].get("inputs") or {}).values(): if _is_link(input_value): pending.append(str(input_value[0])) resolved = sorted(required) logger.info("Resolved remote dependency closure: %s", resolved) return resolved def _is_link(value: Any) -> bool: """Return whether a prompt input value is a ComfyUI link.""" return ( isinstance(value, list) and len(value) == 2 and all(not isinstance(item, dict) for item in value) ) def _normalize_link_output_index(value: Any) -> Any: """Unwrap a singleton list around a prompt-link output index when present.""" while isinstance(value, list) and len(value) == 1: value = value[0] return value def _unwrap_wrapped_prompt_link(value: Any) -> Any: """Collapse nested singleton wrappers around one serialized prompt link when present.""" candidate = value while isinstance(candidate, list) and len(candidate) == 1: candidate = candidate[0] if _is_link(candidate): return [candidate[0], _normalize_link_output_index(candidate[1])] return value def _normalize_prompt_input_value(value: Any, io_type: str | None = None) -> Any: """Unwrap transport-added singleton wrappers only for scalar-like prompt input values.""" wrapped_link = _unwrap_wrapped_prompt_link(value) if wrapped_link is not value: return wrapped_link while ( isinstance(value, list) and len(value) == 1 and ( io_type in _PRIMITIVE_WIDGET_INPUT_TYPES or value[0] is None or isinstance(value[0], bool | int | float | str) ) ): value = value[0] if isinstance(value, list) and len(value) == 2 and isinstance(value[0], str): return [value[0], _normalize_link_output_index(value[1])] if value is None or isinstance(value, bool | int | float | str): return value return value def _normalize_subgraph_payload(payload: dict[str, Any]) -> dict[str, Any]: """Return a subgraph payload with canonical prompt-link and output-index shapes.""" normalized_payload = copy.deepcopy(payload) for node_info in normalized_payload.get("subgraph_prompt", {}).values(): inputs = node_info.get("inputs") or {} for input_name, input_value in list(inputs.items()): inputs[input_name] = _normalize_prompt_input_value(input_value) for boundary_output in normalized_payload.get("boundary_outputs", []): if "node_id" in boundary_output and isinstance( boundary_output["node_id"], list ): boundary_output["node_id"] = _normalize_prompt_input_value( boundary_output["node_id"] ) if "output_index" in boundary_output: boundary_output["output_index"] = _normalize_link_output_index( boundary_output["output_index"] ) normalized_payload["execute_node_ids"] = [ _normalize_prompt_input_value(node_id) for node_id in normalized_payload.get("execute_node_ids", []) ] return normalized_payload def _trim_subgraph_payload_to_required_nodes(payload: dict[str, Any]) -> dict[str, Any]: """Trim a subgraph payload down to the dependency closure of its execute targets.""" trimmed_payload = copy.deepcopy(payload) prompt = trimmed_payload.get("subgraph_prompt", {}) if not isinstance(prompt, dict): return trimmed_payload prompt_node_ids = {str(node_id) for node_id in prompt} requested_execute_node_ids = [ str(node_id) for node_id in trimmed_payload.get("execute_node_ids", []) ] available_execute_node_ids = [ node_id for node_id in requested_execute_node_ids if node_id in prompt_node_ids ] dropped_execute_node_ids = [ node_id for node_id in requested_execute_node_ids if node_id not in prompt_node_ids ] if dropped_execute_node_ids: logger.warning( "Dropping remote execute targets absent from subgraph prompt for component=%s: %s", payload.get("component_id"), dropped_execute_node_ids, ) required_node_ids = set( _resolve_required_subgraph_nodes( prompt=prompt, execute_node_ids=available_execute_node_ids, ) ) if not required_node_ids: return trimmed_payload original_node_ids = list(prompt.keys()) trimmed_payload["subgraph_prompt"] = { str(node_id): prompt[node_id] for node_id in original_node_ids if str(node_id) in required_node_ids } trimmed_payload["boundary_inputs"] = [ { **copy.deepcopy(boundary_input), "targets": [ copy.deepcopy(target) for target in boundary_input.get("targets", []) if str(target.get("node_id")) in required_node_ids ], } for boundary_input in trimmed_payload.get("boundary_inputs", []) if any( str(target.get("node_id")) in required_node_ids for target in boundary_input.get("targets", []) ) ] trimmed_payload["boundary_outputs"] = [ copy.deepcopy(boundary_output) for boundary_output in trimmed_payload.get("boundary_outputs", []) if str(boundary_output.get("node_id")) in required_node_ids ] trimmed_payload["component_node_ids"] = [ str(node_id) for node_id in trimmed_payload.get("component_node_ids", []) if str(node_id) in required_node_ids ] trimmed_payload["execute_node_ids"] = [ str(node_id) for node_id in trimmed_payload.get("execute_node_ids", []) if str(node_id) in required_node_ids ] trimmed_payload["mapped_execute_node_ids"] = [ str(node_id) for node_id in trimmed_payload.get("mapped_execute_node_ids", []) if str(node_id) in required_node_ids ] trimmed_payload["static_execute_node_ids"] = [ str(node_id) for node_id in trimmed_payload.get("static_execute_node_ids", []) if str(node_id) in required_node_ids ] logger.info( "Trimmed remote subgraph payload %s from %d prompt nodes to %d required nodes.", payload.get("component_id"), len(original_node_ids), len(trimmed_payload["subgraph_prompt"]), ) return trimmed_payload def _execute_subgraph_prompt( payload: dict[str, Any], hydrated_inputs: dict[str, Any], custom_nodes_root: Path | None, status_callback: Callable[[dict[str, Any]], None] | None = None, cancellation_event: threading.Event | None = None, interrupt_store: Any | None = None, interrupt_flag_key: str | None = None, ) -> tuple[Any, ...]: """Execute a remote component prompt and return its exported outputs.""" component_id = str(payload.get("component_id", "modal-subgraph")) normalized_payload = _trim_subgraph_payload_to_required_nodes( _normalize_subgraph_payload(payload) ) session_handle = _payload_remote_session_handle(normalized_payload) resolution_stats = _RemoteSessionBridgeResolutionStats() loader_cache_before = _loader_cache_metric_snapshot() resolved_inputs = _resolve_remote_session_inputs( dict(hydrated_inputs), component_id=component_id, target_session_handle=session_handle, custom_nodes_root=custom_nodes_root, cancellation_event=cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, resolution_stats=resolution_stats, ) _log_remote_session_resolution_summary( component_id=component_id, resolution_stats=resolution_stats, loader_cache_before=loader_cache_before, loader_cache_after=_loader_cache_metric_snapshot(), ) short_circuit_outputs = _short_circuit_restored_session_output_subgraph( payload=normalized_payload, hydrated_inputs=hydrated_inputs, session_handle=session_handle, resolution_stats=resolution_stats, ) if short_circuit_outputs is not None: logger.info( "Skipping prompt_executor_execute for component=%s because all %d session-backed outputs were restored into session_id=%s.", component_id, len(short_circuit_outputs), session_handle.session_id if session_handle is not None else None, ) return short_circuit_outputs if session_handle is not None: logger.info( "Executing cloud subgraph component=%s with remote_session session_id=%s prompt_id=%s owner_component_id=%s.", component_id, session_handle.session_id, session_handle.prompt_id, session_handle.owner_component_id, ) with _timed_phase("prepare_subgraph_prompt", component=component_id): prompt = _rewrite_modal_asset_references( copy.deepcopy(normalized_payload["subgraph_prompt"]) ) metadata_prompt = _copy_json_safe_prompt_metadata(prompt) _apply_boundary_inputs( prompt=prompt, boundary_input_specs=list(normalized_payload.get("boundary_inputs", [])), hydrated_inputs=resolved_inputs, cache_signature_inputs=hydrated_inputs, ) with _timed_phase("load_execution_module", component=component_id): execution = _load_execution_module() _install_metadata_safe_dynamic_prompt_wrapper(execution) cache_type, cache_args = _prompt_executor_cache_config(execution) custom_nodes_bundle_path = normalized_payload.get("custom_nodes_bundle") resolved_node_mapping = _ensure_prompt_node_classes_registered( component_id=component_id, prompt=prompt, custom_nodes_root=custom_nodes_root, custom_nodes_bundle_path=( custom_nodes_bundle_path if isinstance(custom_nodes_bundle_path, str) else None ), ) _coerce_prompt_primitive_input_values(prompt, resolved_node_mapping) _validate_prompt_input_shapes( prompt, resolved_node_mapping, list(normalized_payload.get("boundary_inputs", [])), ) _validate_required_prompt_inputs(prompt, resolved_node_mapping) with ( _temporary_node_mapping(None), _patched_folder_paths_absolute_lookup(), _temporary_remote_interrupt_monitor( component_id, cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ), _temporary_progress_hook( prompt_server := _TracingPromptServer( component_id, prompt, status_callback=status_callback, ) ), ): with _timed_phase("create_prompt_executor", component=component_id): executor_state = _get_or_create_prompt_executor_state( execution=execution, prompt_server=prompt_server, cache_type=cache_type, cache_args=cache_args, custom_nodes_root=custom_nodes_root, ) cache_store = _node_output_cache_store() with executor_state.lock: _reset_prompt_executor_request_state(executor_state.executor, prompt_server) restore_state: _PersistedNodeCacheRestoreState | None = None if ( cache_store is not None and get_settings().node_output_cache_max_bytes > 0 ): restore_state = _install_prompt_executor_persisted_cache_restore( execution, executor_state.executor, component_id=component_id, prompt=prompt, required_materialized_node_ids=_boundary_output_node_ids( normalized_payload.get("boundary_outputs", []) ), cache_store=cache_store, ) prompt_server.configure_boundary_output_stream( boundary_outputs=list(normalized_payload.get("boundary_outputs", [])), lookup_cache_entry=lambda node_id: _prompt_executor_cache_get_sync( executor_state.executor.caches.outputs, node_id, ), ) try: with _timed_phase( "prompt_executor_execute", component=component_id, execute_nodes=list(normalized_payload.get("execute_node_ids", [])), ): with _temporary_prompt_metadata(metadata_prompt): _execute_prompt_executor_compat( executor_state.executor, prompt=prompt, prompt_id=str(payload.get("prompt_id") or component_id), extra_data=copy.deepcopy( normalized_payload.get("extra_data") or {} ), execute_outputs=list( normalized_payload.get("execute_node_ids", []) ), ) finally: if restore_state is not None: restore_state.restore_original_method() executor = executor_state.executor restored_node_ids = ( restore_state.restored_node_ids if restore_state is not None else [] ) if restored_node_ids: _emit_cloud_info( "Restored %d persisted node cache entries for component=%s: %s", len(restored_node_ids), component_id, restored_node_ids, ) _emit_restored_node_cache_events(status_callback, restored_node_ids) if not executor.success: _log_prompt_executor_failure_details( component_id=component_id, prompt=prompt, normalized_payload=normalized_payload, executor=executor, ) raise RemoteSubgraphExecutionError(_extract_prompt_executor_error(executor)) if cache_store is not None and get_settings().node_output_cache_max_bytes > 0: with _timed_phase("persist_node_cache", component=component_id): persisted_node_ids = asyncio.run( _persist_node_output_cache_entries( executor, prompt=prompt, cache_store=cache_store, restored_cache_keys_by_node_id=( restore_state.restored_cache_keys_by_node_id if restore_state is not None else None ), ), ) if persisted_node_ids: _emit_cloud_info( "Persisted %d node cache entries for component=%s: %s", len(persisted_node_ids), component_id, persisted_node_ids, ) outputs: list[Any] = [] with _timed_phase( "collect_boundary_outputs", component=component_id, output_count=len(normalized_payload.get("boundary_outputs", [])), ): for boundary_output in normalized_payload.get("boundary_outputs", []): node_id = str(boundary_output["node_id"]) output_index = int(boundary_output["output_index"]) cache_entry = _prompt_executor_cache_get_sync( executor.caches.outputs, node_id, ) if cache_entry is None: raise RemoteSubgraphExecutionError( f"Remote subgraph did not produce cache entry for node {node_id}." ) if output_index >= len(cache_entry.outputs): raise RemoteSubgraphExecutionError( f"Remote subgraph output index {output_index} is missing for node {node_id}." ) output_value = _collapse_cache_slot( slot_values=cache_entry.outputs[output_index], is_list=bool(boundary_output.get("is_list", False)), ) if bool(boundary_output.get("session_output")): if session_handle is None: raise RemoteSessionStateError( "Session-backed boundary outputs require payload.remote_session." ) bridge_record = _build_remote_session_bridge_record( payload=normalized_payload, hydrated_inputs=hydrated_inputs, node_id=node_id, output_index=output_index, io_type=str(boundary_output.get("io_type") or "*"), output_value=output_value, ) _store_remote_session_bridge_record(bridge_record) _store_remote_session_bridge_value( bridge_record.bridge_key, output_value ) live_ref = remote_session_store().put_bridge_output( session_handle, bridge_key=bridge_record.bridge_key, node_id=node_id, output_index=output_index, value=output_value, ) output_value = RemoteSessionBridgeRef( bridge_key=bridge_record.bridge_key, node_id=node_id, output_index=output_index, session_id=live_ref.session_id, ).to_payload() outputs.append(output_value) return tuple(outputs) def _short_circuit_restored_session_output_subgraph( *, payload: dict[str, Any], hydrated_inputs: dict[str, Any], session_handle: RemoteSessionHandle | None, resolution_stats: _RemoteSessionBridgeResolutionStats, ) -> tuple[Any, ...] | None: """Return session-backed outputs directly when bridge restoration already satisfied them all.""" boundary_outputs = list(payload.get("boundary_outputs", [])) if session_handle is None or not boundary_outputs: return None if resolution_stats.input_ref_count <= 0 or resolution_stats.replay_count > 0: return None if any( not bool(boundary_output.get("session_output")) for boundary_output in boundary_outputs ): return None restored_outputs: list[Any] = [] for boundary_output in boundary_outputs: node_id = str(boundary_output["node_id"]) output_index = int(boundary_output["output_index"]) try: output_value = remote_session_store().get_output( RemoteSessionValueRef( session_id=session_handle.session_id, node_id=node_id, output_index=output_index, ) ) except RemoteSessionStateError: return None bridge_record = _build_remote_session_bridge_record( payload=payload, hydrated_inputs=hydrated_inputs, node_id=node_id, output_index=output_index, io_type=str(boundary_output.get("io_type") or "*"), output_value=output_value, ) _store_remote_session_bridge_record(bridge_record) _store_remote_session_bridge_value(bridge_record.bridge_key, output_value) live_ref = remote_session_store().put_bridge_output( session_handle, bridge_key=bridge_record.bridge_key, node_id=node_id, output_index=output_index, value=output_value, ) restored_outputs.append( RemoteSessionBridgeRef( bridge_key=bridge_record.bridge_key, node_id=node_id, output_index=output_index, session_id=live_ref.session_id, ).to_payload() ) return tuple(restored_outputs) def execute_subgraph_locally( payload: dict[str, Any], kwargs_payload: bytes | bytearray | str | dict[str, Any], status_callback: Callable[[dict[str, Any]], None] | None = None, cancellation_event: threading.Event | None = None, interrupt_store: Any | None = None, interrupt_flag_key: str | None = None, ) -> bytes: """Execute a rewritten remote component in-process and return serialized outputs.""" component_id = str(payload.get("component_id", "modal-subgraph")) session_handle = _payload_remote_session_handle(payload) with _timed_phase("execute_subgraph_locally", component=component_id): custom_nodes_root = _extract_custom_nodes_bundle( payload.get("custom_nodes_bundle") ) _ensure_comfy_runtime_initialized(custom_nodes_root) with _timed_phase("deserialize_boundary_inputs", component=component_id): hydrated_inputs = deserialize_node_inputs(kwargs_payload) logger.info( "Executing cloud-local subgraph component=%s hydrated_inputs=%d session_id=%s clear_remote_session=%s.", component_id, len(hydrated_inputs), session_handle.session_id if session_handle is not None else None, bool(payload.get("clear_remote_session")), ) try: with _timed_phase("subgraph_worker_roundtrip", component=component_id): with ThreadPoolExecutor(max_workers=1) as executor: future = executor.submit( _execute_subgraph_prompt, payload, hydrated_inputs, custom_nodes_root, status_callback, cancellation_event, interrupt_store, interrupt_flag_key, ) outputs = future.result() finally: if bool(payload.get("clear_remote_session")) and session_handle is not None: logger.info( "Clearing remote session after cloud component=%s session_id=%s.", component_id, session_handle.session_id, ) remote_session_store().clear_session(session_handle) with _timed_phase("serialize_boundary_outputs", component=component_id): return serialize_node_outputs(outputs) def _mapped_phase_definition( payload: dict[str, Any], phase_key: str ) -> dict[str, Any] | None: """Return one explicit mapped phase definition when queue-time planning provided it.""" phase_payload = payload.get(phase_key) if isinstance(phase_payload, dict): return phase_payload return None def _shared_subgraph_payload_fields(payload: dict[str, Any]) -> dict[str, Any]: """Return the payload fields shared by every explicit mapped phase.""" shared_fields = { "prompt_id": payload.get("prompt_id"), "extra_data": copy.deepcopy(payload.get("extra_data") or {}), "requires_volume_reload": bool(payload.get("requires_volume_reload", True)), "volume_reload_marker": payload.get("volume_reload_marker"), "uploaded_volume_paths": list(payload.get("uploaded_volume_paths", [])), "terminate_container_on_error": bool( payload.get("terminate_container_on_error", True) ), "custom_nodes_bundle": payload.get("custom_nodes_bundle"), } snapshot_profile_key = payload.get("snapshot_profile_key") if isinstance(snapshot_profile_key, str) and snapshot_profile_key.strip(): shared_fields["snapshot_profile_key"] = snapshot_profile_key.strip() remote_session = payload.get("remote_session") if remote_session is not None: shared_fields["remote_session"] = copy.deepcopy(remote_session) if bool(payload.get("clear_remote_session")): shared_fields["clear_remote_session"] = True return shared_fields def _build_phase_subgraph_payload( payload: dict[str, Any], phase_key: str, component_id: str, ) -> dict[str, Any]: """Return one explicit static or mapped subgraph payload.""" phase_definition = _mapped_phase_definition(payload, phase_key) if phase_definition is None: raise KeyError(f"Mapped payload is missing phase definition {phase_key!r}.") return { "payload_kind": "subgraph", "component_id": component_id, **_shared_subgraph_payload_fields(payload), "component_node_ids": [ str(node_id) for node_id in phase_definition.get("component_node_ids", []) if str(node_id) ], "subgraph_prompt": copy.deepcopy(phase_definition.get("subgraph_prompt", {})), "boundary_inputs": copy.deepcopy(phase_definition.get("boundary_inputs", [])), "boundary_outputs": copy.deepcopy(phase_definition.get("boundary_outputs", [])), "execute_node_ids": [ str(node_id) for node_id in phase_definition.get("execute_node_ids", []) if str(node_id) ], } def _split_phase_outputs( phase_outputs: tuple[Any, ...], boundary_outputs: list[dict[str, Any]], internal_output_names: set[str], ) -> tuple[dict[str, Any], tuple[Any, ...]]: """Split one phase result tuple into bridge values and external outputs.""" internal_outputs: dict[str, Any] = {} external_outputs: list[Any] = [] for boundary_output, output_value in zip( boundary_outputs, phase_outputs, strict=True ): output_name = str(boundary_output.get("proxy_output_name") or "") if output_name in internal_output_names: internal_outputs[output_name] = output_value continue external_outputs.append(output_value) return internal_outputs, tuple(external_outputs) def _aggregate_mapped_phase_outputs( per_item_outputs: list[tuple[Any, ...]], payload: dict[str, Any], ) -> tuple[Any, ...]: """Join ordered mapped-phase outputs back into one proxy result tuple.""" if not per_item_outputs: raise ValueError("Mapped execution produced no per-item outputs to aggregate.") output_count = len(per_item_outputs[0]) if any(len(item_outputs) != output_count for item_outputs in per_item_outputs): raise RemoteSubgraphExecutionError( "Mapped remote execution produced inconsistent output arity." ) aggregated_outputs: list[Any] = [] boundary_outputs = list(payload.get("boundary_outputs", [])) for output_index in range(output_count): boundary_output = ( boundary_outputs[output_index] if output_index < len(boundary_outputs) else {} ) aggregated_outputs.append( _merge_static_or_mapped_values( [item_outputs[output_index] for item_outputs in per_item_outputs], io_type=str(boundary_output.get("io_type", "*")), is_list=bool(boundary_output.get("is_list", False)), scheduler_is_list=bool(boundary_output.get("scheduler_is_list", False)), ) ) return tuple(aggregated_outputs) def _merge_static_or_mapped_values( values: list[Any], *, io_type: str, is_list: bool, scheduler_is_list: bool, ) -> Any: """Join mapped per-item outputs using the shared transport serializer rules.""" from serialization import join_mapped_values_for_scheduler return join_mapped_values_for_scheduler( values, io_type=io_type, is_list=is_list, scheduler_is_list=scheduler_is_list, ) def _merge_static_and_mapped_outputs( *, static_outputs: tuple[Any, ...], mapped_outputs: tuple[Any, ...], payload: dict[str, Any], ) -> tuple[Any, ...]: """Reassemble one mapped component's static and mapped outputs in proxy order.""" combined_outputs: list[Any] = [] static_output_index = 0 mapped_output_index = 0 for boundary_output in payload.get("boundary_outputs", []): if bool(boundary_output.get("mapped_output")): if mapped_output_index >= len(mapped_outputs): raise RemoteSubgraphExecutionError( "Mapped remote execution returned fewer mapped outputs than expected." ) combined_outputs.append(mapped_outputs[mapped_output_index]) mapped_output_index += 1 continue if static_output_index >= len(static_outputs): raise RemoteSubgraphExecutionError( "Mapped remote execution returned fewer static outputs than expected." ) combined_outputs.append(static_outputs[static_output_index]) static_output_index += 1 if static_output_index != len(static_outputs) or mapped_output_index != len( mapped_outputs ): raise RemoteSubgraphExecutionError( "Mapped remote execution produced extra outputs that did not match the declared boundary outputs." ) return tuple(combined_outputs) def _execute_mapped_subgraph_payload( payload: dict[str, Any], hydrated_inputs: dict[str, Any], custom_nodes_root: Path | None, status_callback: Callable[[dict[str, Any]], None] | None = None, cancellation_event: threading.Event | None = None, interrupt_store: Any | None = None, interrupt_flag_key: str | None = None, ) -> tuple[Any, ...]: """Execute one mapped payload inside a single remote runtime process.""" mapped_input = payload.get("mapped_input") or {} mapped_input_name = str(mapped_input.get("proxy_input_name") or "") if not mapped_input_name: raise RemoteSubgraphExecutionError( "Mapped remote payloads must define mapped_input.proxy_input_name." ) if mapped_input_name not in hydrated_inputs: raise KeyError( f"Mapped remote payload input {mapped_input_name!r} was not provided." ) from serialization import split_mapped_value mapped_items = split_mapped_value( hydrated_inputs[mapped_input_name], str(mapped_input.get("io_type", "*")), ) if not mapped_items: raise ValueError("Mapped remote execution requires at least one input item.") broadcast_inputs = dict(hydrated_inputs) broadcast_inputs.pop(mapped_input_name, None) static_to_mapped_boundaries = list(payload.get("static_to_mapped_boundaries", [])) bridge_output_names = { str(boundary_spec.get("proxy_name") or "") for boundary_spec in static_to_mapped_boundaries if str(boundary_spec.get("proxy_name") or "") } static_outputs: tuple[Any, ...] = () if payload.get("static_phase") is not None: static_phase_payload = _build_phase_subgraph_payload( payload, "static_phase", f"{payload.get('component_id', 'modal-subgraph')}::static", ) if static_phase_payload.get("execute_node_ids"): static_phase_outputs = _execute_subgraph_prompt( static_phase_payload, dict(broadcast_inputs), custom_nodes_root, status_callback=status_callback, cancellation_event=cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ) bridge_inputs, static_outputs = _split_phase_outputs( static_phase_outputs, list(static_phase_payload.get("boundary_outputs", [])), bridge_output_names, ) broadcast_inputs.update(bridge_inputs) if status_callback is not None: status_callback( { "event_type": "node_progress", "node_id": str(payload.get("component_id") or "modal-subgraph"), "display_node_id": str(payload.get("component_id") or "modal-subgraph"), "value": 0.0, "max": float(len(mapped_items)), "aggregate_only": True, } ) per_item_outputs: list[tuple[Any, ...]] = [] for item_index, item_value in enumerate(mapped_items): last_lane_node_id: str | None = None lane_id = str(payload.get("mapped_progress_lane_id") or item_index) def publish_item_status(progress_state: dict[str, Any]) -> None: """Attach mapped-lane metadata to one per-item progress event.""" nonlocal last_lane_node_id if status_callback is None: return event_type = str(progress_state.get("event_type", "")) if event_type == "node_progress": reported_node_id = progress_state.get( "real_node_id" ) or progress_state.get("node_id") if reported_node_id is not None: last_lane_node_id = str(reported_node_id) status_callback( { **progress_state, "lane_id": lane_id, "item_index": item_index, } ) return if event_type in {"executed", "preview", "boundary_output"}: status_callback({**progress_state, "item_index": item_index}) item_payload = _build_phase_subgraph_payload( payload, "mapped_phase", f"{payload.get('component_id', 'modal-subgraph')}::item:{item_index}", ) item_inputs = dict(broadcast_inputs) item_inputs[mapped_input_name] = item_value per_item_outputs.append( _execute_subgraph_prompt( item_payload, item_inputs, custom_nodes_root, status_callback=publish_item_status, cancellation_event=cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ) ) if status_callback is not None: status_callback( { "event_type": "node_progress", "node_id": last_lane_node_id or str(payload.get("component_id") or "modal-subgraph"), "display_node_id": last_lane_node_id or str(payload.get("component_id") or "modal-subgraph"), "value": 0.0, "max": 1.0, "lane_id": lane_id, "item_index": item_index, "clear": True, } ) status_callback( { "event_type": "node_progress", "node_id": str(payload.get("component_id") or "modal-subgraph"), "display_node_id": str( payload.get("component_id") or "modal-subgraph" ), "value": float(item_index + 1), "max": float(len(mapped_items)), "aggregate_only": True, } ) mapped_phase_payload = _build_phase_subgraph_payload( payload, "mapped_phase", f"{payload.get('component_id', 'modal-subgraph')}::mapped", ) mapped_outputs = _aggregate_mapped_phase_outputs( per_item_outputs, {"boundary_outputs": list(mapped_phase_payload.get("boundary_outputs", []))}, ) return _merge_static_and_mapped_outputs( static_outputs=static_outputs, mapped_outputs=mapped_outputs, payload=payload, ) class _BoundedStreamEventBuffer: """Bound progress memory while preserving terminal stream events.""" def __init__(self, maxsize: int) -> None: """Initialize a bounded event queue and close signal.""" self._queue: queue.Queue[tuple[str, Any]] = queue.Queue(maxsize=max(4, maxsize)) self._closed = threading.Event() self._dropped_progress_events = 0 self._dropped_lock = threading.Lock() @property def dropped_progress_events(self) -> int: """Return how many stale progress events were coalesced away.""" with self._dropped_lock: return self._dropped_progress_events @property def queue_size(self) -> int: """Return the approximate number of currently buffered events.""" return self._queue.qsize() def publish_progress(self, payload: Any) -> None: """Publish the newest progress event without exceeding the queue bound.""" event = ("progress", payload) while not self._closed.is_set(): try: self._queue.put_nowait(event) return except queue.Full: try: discarded_event = self._queue.get_nowait() except queue.Empty: continue if discarded_event[0] != "progress": self._queue.put_nowait(discarded_event) return with self._dropped_lock: self._dropped_progress_events += 1 def publish_terminal(self, event_kind: str, payload: Any) -> bool: """Publish a result, error, or completion unless the consumer closed.""" while not self._closed.is_set(): try: self._queue.put((event_kind, payload), timeout=0.1) return True except queue.Full: continue return False def get(self) -> tuple[str, Any]: """Wait for and return the next buffered stream event.""" return self._queue.get() def close(self) -> None: """Release any producer waiting after the consumer stops.""" self._closed.set() def _abandon_streamed_remote_invocation( *, payload: Mapping[str, Any], running_record: RemoteInvocationRecord | None, cancellation_event: threading.Event | None, event_buffer: _BoundedStreamEventBuffer, worker_thread: threading.Thread, ) -> None: """Cancel unfinished compute and make its invocation record retryable.""" component_id = str(payload.get("component_id") or "payload") if cancellation_event is not None: cancellation_event.set() event_buffer.close() worker_thread.join(timeout=max(0.0, _REMOTE_INVOCATION_ABANDON_JOIN_SECONDS)) abandoned_error = RemoteInvocationAbandonedError( f"Remote invocation stream for component {component_id!r} closed before completion." ) if running_record is not None: _fail_remote_invocation(running_record, abandoned_error) logger.warning( "Abandoned remote invocation stream component=%s invocation_id=%s worker_stopped=%s; the invocation is retryable.", component_id, running_record.invocation_id if running_record is not None else "none", not worker_thread.is_alive(), ) def _stream_remote_payload_events( payload: dict[str, Any], kwargs_payload: bytes | bytearray | str | dict[str, Any], cancellation_event: threading.Event | None = None, interrupt_store: Any | None = None, interrupt_flag_key: str | None = None, ) -> Iterator[dict[str, Any]]: """Yield progress and result events for one remote payload execution.""" event_buffer = _BoundedStreamEventBuffer(get_settings().stream_event_queue_maxsize) task_id = os.getenv("MODAL_TASK_ID") component_id = str(payload.get("component_id") or "payload") invocation_id = str(payload.get("invocation_id") or "none") def publish_status(progress_state: dict[str, Any]) -> None: """Queue a progress envelope for the remote caller.""" event_buffer.publish_progress(serialize_mapping(progress_state)) def execute_once() -> bytes: """Run the underlying payload once and return serialized outputs.""" if payload.get("payload_kind") == "canary": return _execute_canary_payload( payload, kwargs_payload, cancellation_event=cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ) if payload.get("payload_kind") == "mapped_subgraph": custom_nodes_root = _extract_custom_nodes_bundle( payload.get("custom_nodes_bundle") ) _ensure_comfy_runtime_initialized(custom_nodes_root) hydrated_inputs = deserialize_node_inputs(kwargs_payload) return serialize_node_outputs( _execute_mapped_subgraph_payload( payload, hydrated_inputs, custom_nodes_root, status_callback=publish_status, cancellation_event=cancellation_event, interrupt_store=interrupt_store, interrupt_flag_key=interrupt_flag_key, ) ) if payload.get("payload_kind") == "subgraph": execute_subgraph_kwargs: dict[str, Any] = { "status_callback": publish_status } if ( "cancellation_event" in inspect.signature(execute_subgraph_locally).parameters ): execute_subgraph_kwargs["cancellation_event"] = cancellation_event if ( "interrupt_store" in inspect.signature(execute_subgraph_locally).parameters ): execute_subgraph_kwargs["interrupt_store"] = interrupt_store if ( "interrupt_flag_key" in inspect.signature(execute_subgraph_locally).parameters ): execute_subgraph_kwargs["interrupt_flag_key"] = interrupt_flag_key return execute_subgraph_locally( payload, kwargs_payload, **execute_subgraph_kwargs, ) execute_node_kwargs: dict[str, Any] = {} if "cancellation_event" in inspect.signature(execute_node_locally).parameters: execute_node_kwargs["cancellation_event"] = cancellation_event if "interrupt_store" in inspect.signature(execute_node_locally).parameters: execute_node_kwargs["interrupt_store"] = interrupt_store if "interrupt_flag_key" in inspect.signature(execute_node_locally).parameters: execute_node_kwargs["interrupt_flag_key"] = interrupt_flag_key return execute_node_locally(payload, kwargs_payload, **execute_node_kwargs) object_store = _durable_object_store() def execute_payload() -> None: """Run compute in a worker thread while deferring Modal volume commits.""" pending_batch: DurableObjectCommitBatch | None = None try: with object_store.batch_commits(commit_on_exit=False) as pending_batch: outputs = _execute_payload_with_output_capture(payload, execute_once) except ( Exception ) as exc: # pragma: no cover - exercised through generator consumer tests. event_buffer.publish_terminal("error", (exc, pending_batch)) else: result_bytes = len(outputs) pending_object_write = bool(pending_batch and pending_batch.wrote_object) logger.info( "Remote stream worker produced result component=%s invocation_id=%s task_id=%s " "result_bytes=%d pending_object_write=%s buffer_queue_size=%d.", component_id, invocation_id, task_id or "none", result_bytes, pending_object_write, event_buffer.queue_size, ) publish_started_at = time.monotonic() published = event_buffer.publish_terminal("result", (outputs, pending_batch)) logger.info( "Finished publishing remote stream result to event buffer in %.3fs component=%s " "invocation_id=%s task_id=%s published=%s result_bytes=%d buffer_queue_size=%d.", time.monotonic() - publish_started_at, component_id, invocation_id, task_id or "none", published, result_bytes, event_buffer.queue_size, ) finally: event_buffer.publish_terminal("done", None) worker_thread = threading.Thread( target=execute_payload, name=f"modal-stream-{payload.get('component_id', 'payload')}", daemon=True, ) if task_id: yield {"kind": "remote_logs", "task_id": task_id} running_record, completed_result = _begin_remote_invocation(payload) if completed_result is not None: yield {"kind": "result", "outputs": completed_result} return worker_thread.start() invocation_finalized = False try: while True: event_kind, event_payload = event_buffer.get() if event_kind == "progress": yield {"kind": "progress", **event_payload} continue if event_kind == "result": outputs, pending_batch = event_payload serialized_outputs = coerce_serialized_node_outputs(outputs) logger.info( "Remote stream consumer received buffered result component=%s invocation_id=%s " "task_id=%s result_bytes=%d pending_object_write=%s buffer_queue_size=%d.", component_id, invocation_id, task_id or "none", len(serialized_outputs), bool(pending_batch and pending_batch.wrote_object), event_buffer.queue_size, ) if running_record is not None: _complete_remote_invocation( running_record, serialized_outputs, pending_batch=pending_batch, ) elif pending_batch is not None: object_store.commit_batch(pending_batch) invocation_finalized = True yield_started_at = time.monotonic() logger.info( "Yielding remote stream result to Modal transport component=%s invocation_id=%s " "task_id=%s result_bytes=%d buffer_queue_size=%d.", component_id, invocation_id, task_id or "none", len(serialized_outputs), event_buffer.queue_size, ) try: yield {"kind": "result", "outputs": serialized_outputs} finally: logger.info( "Remote stream result yield released after %.3fs component=%s invocation_id=%s " "task_id=%s result_bytes=%d buffer_queue_size=%d.", time.monotonic() - yield_started_at, component_id, invocation_id, task_id or "none", len(serialized_outputs), event_buffer.queue_size, ) continue if event_kind == "error": error, pending_batch = event_payload if pending_batch is not None: object_store.commit_batch(pending_batch) if running_record is not None: _fail_remote_invocation(running_record, error) invocation_finalized = True raise error if event_kind == "done": return finally: if invocation_finalized: event_buffer.close() worker_thread.join(timeout=1.0) else: _abandon_streamed_remote_invocation( payload=payload, running_record=running_record, cancellation_event=cancellation_event, event_buffer=event_buffer, worker_thread=worker_thread, ) if event_buffer.dropped_progress_events: logger.info( "Coalesced %d stale remote progress event(s) for component=%s to keep the stream buffer bounded.", event_buffer.dropped_progress_events, payload.get("component_id"), ) def _prewarm_snapshot_state( *, gpu_snapshot_enabled: bool, snapshot_profile_key: str = "", ) -> None: """Run snapshot-safe initialization before Modal captures a memory snapshot.""" with _timed_phase( "prewarm_snapshot_state", gpu_snapshot=gpu_snapshot_enabled, snapshot_profile=snapshot_profile_key or None, ): _ensure_comfyui_support_packages() normalized_snapshot_profile_key = snapshot_profile_key.strip() if gpu_snapshot_enabled and normalized_snapshot_profile_key: _ensure_comfy_runtime_initialized(None) _load_execution_module() loader_prewarm_plans = _load_loader_snapshot_profile( normalized_snapshot_profile_key ) if loader_prewarm_plans: _execute_loader_prewarm_plans( component_id=f"snapshot-profile:{normalized_snapshot_profile_key}", loader_prewarm_plans=loader_prewarm_plans, custom_nodes_root=None, ) _emit_cloud_info( "Completed GPU-snapshot ComfyUI prewarm before snapshot capture." ) return if gpu_snapshot_enabled: _emit_cloud_info( "Skipping GPU-snapshot ComfyUI prewarm before snapshot capture because no snapshot profile was provided." ) else: _emit_cloud_info( "Skipping full ComfyUI runtime prewarm during CPU-only snapshot to avoid accidental CUDA initialization." ) def _reload_compile_cache_volume(volume: Any | None) -> bool: """Refresh persistent compiler artifacts before a runtime opens its caches.""" if volume is None: return False reload_method = getattr(volume, "reload", None) if not callable(reload_method): logger.warning("Modal compile-cache Volume does not expose reload().") return False with _timed_phase("llm_compile_cache_reload"): try: reload_method() except RuntimeError as exc: if _is_modal_volume_open_files_error(exc): _log_compile_cache_memory_maps() raise return True def _mapped_process_files_under( volume_root: Path, *, proc_root: Path = Path("/proc"), ) -> tuple[tuple[int, str], ...]: """Return process ids and files memory-mapped beneath one filesystem root.""" try: resolved_root = volume_root.resolve(strict=True) process_directories = tuple(proc_root.iterdir()) except OSError: return () mapped_files: set[tuple[int, str]] = set() for process_directory in process_directories: if not process_directory.name.isdecimal(): continue try: maps_text = (process_directory / "maps").read_text( encoding="utf-8", errors="replace", ) except OSError: continue for line in maps_text.splitlines(): fields = line.split(maxsplit=5) if len(fields) != 6 or not fields[5].startswith("/"): continue mapped_path = fields[5].removesuffix(" (deleted)") try: Path(mapped_path).relative_to(resolved_root) except ValueError: continue mapped_files.add((int(process_directory.name), mapped_path)) return tuple(sorted(mapped_files)) def _log_compile_cache_memory_maps() -> None: """Log native mappings that explain a busy compile-cache Volume reload.""" mapped_files = _mapped_process_files_under(_REMOTE_LLM_COMPILE_CACHE_ROOT) if not mapped_files: logger.warning( "Modal compile-cache Volume reload reported open files, but no " "memory-mapped cache files were visible in /proc." ) return logger.error( "Modal compile-cache Volume reload is blocked by %d memory-mapped " "native cache file(s): %s", len(mapped_files), [ {"pid": process_id, "path": mapped_path} for process_id, mapped_path in mapped_files[:8] ], ) def _prewarm_restored_runtime(compile_cache_volume: Any | None = None) -> None: """Run post-restore initialization that should be ready before serving requests.""" with _timed_phase("prewarm_restored_runtime"): _reload_compile_cache_volume(compile_cache_volume) _ensure_comfy_runtime_initialized(None) _load_execution_module() def _should_reload_modal_volume(payload: dict[str, Any]) -> bool: """Return whether this request needs the mounted Modal volume reloaded.""" if _payload_volume_paths(payload) and not _payload_volume_paths_visible(payload): return True if not bool(payload.get("requires_volume_reload", True)): return False if _payload_uploaded_volume_paths_visible(payload): reload_marker = _modal_volume_reload_marker(payload) if reload_marker is not None: _record_modal_volume_reload_marker(reload_marker) return False reload_marker = _modal_volume_reload_marker(payload) if reload_marker is None: return True return not _has_seen_modal_volume_reload_marker(reload_marker) def _modal_volume_reload_marker(payload: dict[str, Any]) -> str | None: """Return the per-request Modal volume reload marker attached to this payload.""" marker = payload.get("volume_reload_marker") if marker is None: return None marker_text = str(marker).strip() return marker_text or None def _has_seen_modal_volume_reload_marker(reload_marker: str) -> bool: """Return whether this container already reloaded the volume for this marker.""" with _MODAL_VOLUME_RELOAD_MARKERS_LOCK: return reload_marker in _MODAL_VOLUME_RELOAD_MARKER_SET def _record_modal_volume_reload_marker(reload_marker: str) -> None: """Remember that this container has already reloaded the volume for one marker.""" global _MODAL_VOLUME_RELOAD_MARKERS with _MODAL_VOLUME_RELOAD_MARKERS_LOCK: if reload_marker in _MODAL_VOLUME_RELOAD_MARKER_SET: return if _MODAL_VOLUME_RELOAD_MARKERS is None: _MODAL_VOLUME_RELOAD_MARKERS = queue.SimpleQueue() _MODAL_VOLUME_RELOAD_MARKER_SET.add(reload_marker) _MODAL_VOLUME_RELOAD_MARKERS.put(reload_marker) while ( len(_MODAL_VOLUME_RELOAD_MARKER_SET) > _MODAL_VOLUME_RELOAD_MARKER_CACHE_LIMIT ): expired_marker = _MODAL_VOLUME_RELOAD_MARKERS.get() _MODAL_VOLUME_RELOAD_MARKER_SET.discard(expired_marker) def _clear_warm_remote_caches() -> None: """Drop warm-container caches that may retain references to mounted volume files.""" with _PROMPT_EXECUTOR_STATES_LOCK: _PROMPT_EXECUTOR_STATES.clear() with _LOADER_CACHE_LOCK: _LOADER_OUTPUT_CACHE.clear() def _prepare_for_modal_volume_reload() -> None: """Release warm runtime state so a Modal volume reload can proceed safely.""" _clear_warm_remote_caches() try: import comfy.model_management as model_management except ModuleNotFoundError: gc.collect() return model_management.unload_all_models() model_management.cleanup_models() model_management.soft_empty_cache(True) gc.collect() def _is_modal_volume_open_files_error(exc: RuntimeError) -> bool: """Return whether a Modal volume reload failed because mounted files are still open.""" return "open files" in str(exc) def _sleep_before_modal_volume_reload_retry(delay_seconds: float) -> None: """Pause briefly so recently cancelled work can release mounted-volume file handles.""" if delay_seconds <= 0: return time.sleep(delay_seconds) def _iter_payload_input_strings(value: Any) -> Iterator[str]: """Yield string literals nested inside one serialized prompt input value.""" if isinstance(value, str): yield value return if isinstance(value, list): if len(value) == 2 and isinstance(value[0], str): return for item in value: yield from _iter_payload_input_strings(item) return if isinstance(value, dict): for nested_value in value.values(): yield from _iter_payload_input_strings(nested_value) def _payload_volume_paths(payload: dict[str, Any]) -> set[Path]: """Return mounted-volume paths referenced by this remote payload.""" remote_storage_root = Path(get_settings().remote_storage_root).resolve() referenced_paths: set[Path] = set() custom_nodes_bundle = payload.get("custom_nodes_bundle") if isinstance(custom_nodes_bundle, str): bundle_path = Path(_materialize_remote_asset_path(custom_nodes_bundle)) if bundle_path.is_absolute() and bundle_path.resolve().is_relative_to( remote_storage_root ): referenced_paths.add(bundle_path) prompt = payload.get("subgraph_prompt", {}) if not isinstance(prompt, dict): return referenced_paths for prompt_node in prompt.values(): if not isinstance(prompt_node, dict): continue inputs = prompt_node.get("inputs", {}) if not isinstance(inputs, dict): continue for input_value in inputs.values(): for candidate_path in _iter_payload_input_strings(input_value): materialized_path = _materialize_remote_asset_path(candidate_path) materialized_path_obj = Path(materialized_path) if ( materialized_path_obj.is_absolute() and materialized_path_obj.resolve().is_relative_to( remote_storage_root ) ): referenced_paths.add(materialized_path_obj) return referenced_paths def _payload_uploaded_volume_paths(payload: dict[str, Any]) -> set[Path]: """Return newly uploaded mounted-volume paths relevant to this payload.""" remote_storage_root = Path(get_settings().remote_storage_root).resolve() uploaded_paths: set[Path] = set() for candidate_path in payload.get("uploaded_volume_paths", []): if isinstance(candidate_path, str) and candidate_path.strip(): materialized_path = Path(_materialize_remote_asset_path(candidate_path)) if ( materialized_path.is_absolute() and materialized_path.resolve().is_relative_to(remote_storage_root) ): uploaded_paths.add(materialized_path) return uploaded_paths def _payload_uploaded_volume_paths_visible(payload: dict[str, Any]) -> bool: """Return whether every newly uploaded mounted-volume path is already visible.""" uploaded_paths = _payload_uploaded_volume_paths(payload) if not uploaded_paths: return False return all(_runtime_volume_path_visible(path) for path in uploaded_paths) def _runtime_volume_path_visible(volume_path: Path) -> bool: """Return whether a mounted path is available directly or through read-through storage.""" if volume_path.exists(): return True cache_path = _readthrough_cache_path(volume_path) return cache_path is not None and cache_path.exists() def _payload_volume_paths_visible(payload: dict[str, Any]) -> bool: """Return whether every mounted-volume path referenced by this payload is already visible.""" referenced_paths = _payload_volume_paths(payload) if not referenced_paths: return False return all(_runtime_volume_path_visible(path) for path in referenced_paths) def _download_committed_volume_path( volume: Any, volume_path: Path, cache_path: Path ) -> None: """Stream one committed Modal Volume file into the worker's ephemeral cache.""" remote_storage_root = Path(get_settings().remote_storage_root).resolve() relative_path = volume_path.resolve().relative_to(remote_storage_root).as_posix() read_file_into_fileobj = getattr(volume, "read_file_into_fileobj", None) read_file = getattr(volume, "read_file", None) if not callable(read_file_into_fileobj) and not callable(read_file): raise AttributeError( "The configured Modal Volume does not support committed file reads." ) cache_path.parent.mkdir(parents=True, exist_ok=True) descriptor, temporary_name = tempfile.mkstemp( prefix=f".{cache_path.name}.", suffix=".tmp", dir=cache_path.parent, ) os.close(descriptor) temporary_path = Path(temporary_name) try: with temporary_path.open("wb") as cache_file: if callable(read_file_into_fileobj): read_file_into_fileobj(relative_path, cache_file) else: assert callable(read_file) for chunk in read_file(relative_path): cache_file.write(chunk) os.replace(temporary_path, cache_path) finally: temporary_path.unlink(missing_ok=True) def _custom_nodes_manifest_dependency_paths( volume_path: Path, runtime_path: Path, ) -> set[Path]: """Return mounted-volume dependencies declared by one custom-node manifest.""" remote_storage_root = Path(get_settings().remote_storage_root).resolve() custom_nodes_root = remote_storage_root / "custom_nodes" if ( volume_path.suffix.lower() != ".json" or not volume_path.resolve().is_relative_to(custom_nodes_root) ): return set() try: manifest_payload = _load_custom_nodes_manifest(runtime_path) except RuntimeError: return set() dependency_paths: set[Path] = set() entry_payloads = manifest_payload.get("entries", []) if not isinstance(entry_payloads, list): return dependency_paths for entry_payload in entry_payloads: if not isinstance(entry_payload, dict): continue candidate_payloads = [entry_payload] asset_payloads = entry_payload.get("assets", []) if isinstance(asset_payloads, list): candidate_payloads.extend( asset_payload for asset_payload in asset_payloads if isinstance(asset_payload, dict) ) for candidate_payload in candidate_payloads: remote_path = candidate_payload.get("remote_path") if not isinstance(remote_path, str) or not remote_path.strip(): continue materialized_path = Path(_materialize_remote_asset_path(remote_path)) if _readthrough_cache_path(materialized_path) is not None: dependency_paths.add(materialized_path) return dependency_paths def _hydrate_missing_payload_volume_paths( volume: Any, payload: dict[str, Any] ) -> list[Path]: """Cache committed payload files that are absent from this worker's mounted snapshot.""" candidate_paths = _payload_volume_paths(payload) | _payload_uploaded_volume_paths( payload ) if not candidate_paths: return [] if not callable(getattr(volume, "read_file_into_fileobj", None)) and not callable( getattr(volume, "read_file", None) ): return [] hydrated_paths: list[Path] = [] pending_paths = sorted(candidate_paths) visited_paths: set[Path] = set() component_id = str(payload.get("component_id") or "modal-subgraph") while pending_paths: volume_path = pending_paths.pop(0) if volume_path in visited_paths: continue visited_paths.add(volume_path) runtime_path = Path(_resolve_runtime_asset_path(str(volume_path))) if not _runtime_volume_path_visible(volume_path): cache_path = _readthrough_cache_path(volume_path) if cache_path is None: continue try: with _timed_phase( "committed_volume_readthrough", component=component_id, path=volume_path.name, ): _download_committed_volume_path(volume, volume_path, cache_path) except FileNotFoundError: logger.warning( "Committed Modal Volume path %s was unavailable for component=%s; falling back to mounted-volume reload.", volume_path, component_id, ) continue hydrated_paths.append(cache_path) runtime_path = cache_path pending_paths.extend( sorted( _custom_nodes_manifest_dependency_paths(volume_path, runtime_path) - visited_paths ) ) if hydrated_paths: _emit_cloud_info( "Hydrated %d missing committed volume file(s) through read-through storage for component=%s.", len(hydrated_paths), component_id, ) return hydrated_paths def _log_payload_volume_reload_diagnostics( component_id: str, payload: dict[str, Any] | None, *, context: str, ) -> None: """Log the mounted-volume paths relevant to one reload decision or failure.""" if payload is None: return uploaded_paths = sorted( str(path) for path in _payload_uploaded_volume_paths(payload) ) referenced_paths = sorted(str(path) for path in _payload_volume_paths(payload)) logger.info( "Modal volume reload diagnostics for component=%s context=%s uploaded_paths=%s referenced_paths=%s visible_uploaded=%s visible_referenced=%s.", component_id, context, uploaded_paths, referenced_paths, _payload_uploaded_volume_paths_visible(payload), _payload_volume_paths_visible(payload), ) def _reload_modal_volume_for_request( volume: Any, component_id: str, reload_marker: str | None = None, payload: dict[str, Any] | None = None, ) -> None: """Reload the Modal volume, retrying briefly while warm state releases open files.""" with _timed_phase("modal_volume_reload", component=component_id): diagnostics_logged = False for attempt_index, retry_delay_seconds in enumerate( _MODAL_VOLUME_RELOAD_OPEN_FILE_RETRY_DELAYS_SECONDS, start=1, ): if attempt_index > 1: _sleep_before_modal_volume_reload_retry(retry_delay_seconds) try: volume.reload() if reload_marker is not None: _record_modal_volume_reload_marker(reload_marker) if attempt_index > 1: _emit_cloud_info( "Modal volume reload succeeded for component=%s after %d attempt(s).", component_id, attempt_index, ) return except RuntimeError as exc: if not _is_modal_volume_open_files_error(exc): raise if payload is not None and not diagnostics_logged: _log_payload_volume_reload_diagnostics( component_id, payload, context="open_files_retry", ) diagnostics_logged = True if attempt_index == len( _MODAL_VOLUME_RELOAD_OPEN_FILE_RETRY_DELAYS_SECONDS ): if payload is not None and _payload_volume_paths_visible(payload): _emit_cloud_info( "Modal volume reload still reported open files for component=%s after %d attempt(s), " "but all referenced mounted-volume paths are already visible. Proceeding without reload.", component_id, attempt_index, ) if reload_marker is not None: _record_modal_volume_reload_marker(reload_marker) return raise _emit_cloud_info( "Modal volume reload hit open files for component=%s on attempt %d/%d; clearing warm caches and retrying after %.2fs.", component_id, attempt_index, len(_MODAL_VOLUME_RELOAD_OPEN_FILE_RETRY_DELAYS_SECONDS), _MODAL_VOLUME_RELOAD_OPEN_FILE_RETRY_DELAYS_SECONDS[attempt_index], ) _prepare_for_modal_volume_reload() def _emit_modal_volume_reload_skip(component_id: Any, payload: dict[str, Any]) -> None: """Log why a request did not need a Modal volume reload.""" if _payload_uploaded_volume_paths_visible(payload): _emit_cloud_info( "Skipping modal_volume_reload for component=%s because all uploaded mounted-volume paths are already visible in this container.", component_id, ) _log_payload_volume_reload_diagnostics( str(component_id), payload, context="skip_visible_uploaded_paths", ) return reload_marker = _modal_volume_reload_marker(payload) if reload_marker is not None and _has_seen_modal_volume_reload_marker( reload_marker ): _emit_cloud_info( "Skipping modal_volume_reload for component=%s because this container already reloaded marker=%s.", component_id, reload_marker, ) _log_payload_volume_reload_diagnostics( str(component_id), payload, context="skip_reload_marker_seen", ) return _emit_cloud_info( "Skipping modal_volume_reload for component=%s because no new assets were uploaded for this request.", component_id, ) _log_payload_volume_reload_diagnostics( str(component_id), payload, context="skip_no_new_assets", ) def _prepare_warm_container_for_request( volume: Any, payload: dict[str, Any], compile_cache_volume: Any | None = None, ) -> dict[str, Any]: """Prime one RemoteEngine container for a request before the first real execution payload arrives.""" component_id = str(payload.get("component_id") or "modal-warmup") reload_marker = _modal_volume_reload_marker(payload) _hydrate_missing_payload_volume_paths(volume, payload) needs_volume_reload = _should_reload_modal_volume(payload) with _timed_phase("remote_engine_warmup", component=component_id): if needs_volume_reload: _reload_modal_volume_for_request( volume, component_id, reload_marker=reload_marker, payload=payload, ) else: _emit_modal_volume_reload_skip(component_id, payload) custom_nodes_bundle = payload.get("custom_nodes_bundle") custom_nodes_root: Path | None = None if isinstance(custom_nodes_bundle, str) and custom_nodes_bundle.strip(): custom_nodes_root = _extract_custom_nodes_bundle(custom_nodes_bundle) if custom_nodes_root is not None: _register_custom_nodes_root(custom_nodes_root) loader_prewarm_plans = payload.get("loader_prewarm_plans") if isinstance(loader_prewarm_plans, list) and loader_prewarm_plans: _execute_loader_prewarm_plans( component_id=component_id, loader_prewarm_plans=loader_prewarm_plans, custom_nodes_root=custom_nodes_root, ) llm_prewarm_plans = payload.get("llm_prewarm_plans") llm_prewarm_results: list[dict[str, Any]] = [] if isinstance(llm_prewarm_plans, list) and llm_prewarm_plans: llm_prewarm_results = _execute_llm_prewarm_plans( component_id=component_id, prompt_id=( str(payload["prompt_id"]) if payload.get("prompt_id") is not None else None ), llm_prewarm_plans=llm_prewarm_plans, compile_cache_volume=compile_cache_volume, ) return { "component_id": component_id, "task_id": os.getenv("MODAL_TASK_ID"), "warmup_slot_index": ( int(payload["warmup_slot_index"]) if payload.get("warmup_slot_index") is not None else None ), "reloaded_volume": needs_volume_reload, "llm_prewarm_results": llm_prewarm_results, } def _loader_prewarm_plan_key(plan: Mapping[str, Any]) -> str | None: """Return the stable worker-local dedupe key for one loader prewarm plan.""" signature = plan.get("signature") if signature is None: return None normalized_signature = str(signature).strip() return normalized_signature or None def _build_loader_prewarm_payload( *, component_id: str, plan_index: int, plan: Mapping[str, Any], ) -> dict[str, Any]: """Build one synthetic single-node subgraph payload for loader warmup.""" plan_node_id = str(plan.get("node_id") or f"loader-{plan_index}") prompt_id = plan.get("prompt_id") return { "payload_kind": "subgraph", "component_id": f"{component_id}::loader-prewarm:{plan_node_id}", "prompt_id": (str(prompt_id) if prompt_id is not None else None), "component_node_ids": [plan_node_id], "subgraph_prompt": copy.deepcopy(dict(plan["subgraph_prompt"])), "boundary_inputs": [], "boundary_outputs": [], "execute_node_ids": list(plan.get("execute_node_ids") or [plan_node_id]), "extra_data": {}, } def _execute_loader_prewarm_plans( *, component_id: str, loader_prewarm_plans: list[dict[str, Any]], custom_nodes_root: Path | None, ) -> None: """Execute synthetic one-node loader workflows so fresh workers preload heavyweight models.""" if not get_settings().enable_loader_prewarm: return _ensure_comfy_runtime_initialized(custom_nodes_root) executable_plans: list[tuple[int, Mapping[str, Any], str | None]] = [] skipped_plan_count = 0 for plan_index, plan in enumerate(loader_prewarm_plans): if not isinstance(plan, Mapping): continue plan_key = _loader_prewarm_plan_key(plan) if plan_key is not None: with _LOADER_PREWARM_PLAN_KEYS_LOCK: if plan_key in _LOADER_PREWARM_PLAN_KEYS: skipped_plan_count += 1 continue _LOADER_PREWARM_PLAN_KEYS.add(plan_key) executable_plans.append((plan_index, plan, plan_key)) def execute_plan( plan_entry: tuple[int, Mapping[str, Any], str | None] ) -> None: """Execute one reserved loader plan and make failures retryable.""" plan_index, plan, plan_key = plan_entry started_at = time.perf_counter() try: _execute_subgraph_prompt( _build_loader_prewarm_payload( component_id=component_id, plan_index=plan_index, plan=plan, ), hydrated_inputs={}, custom_nodes_root=custom_nodes_root, ) except Exception: if plan_key is not None: with _LOADER_PREWARM_PLAN_KEYS_LOCK: _LOADER_PREWARM_PLAN_KEYS.discard(plan_key) raise logger.info( "Completed loader prewarm component=%s class_type=%s plan_index=%d elapsed_seconds=%.3f.", component_id, plan.get("class_type"), plan_index, time.perf_counter() - started_at, ) worker_count = min( len(executable_plans), max(1, int(get_settings().loader_prewarm_workers)), ) if worker_count > 1: logger.info( "Running %d independent loader prewarms with bounded concurrency=%d component=%s.", len(executable_plans), worker_count, component_id, ) with ThreadPoolExecutor( max_workers=worker_count, thread_name_prefix="modal-loader-prewarm", ) as executor: futures = [ executor.submit(execute_plan, plan_entry) for plan_entry in executable_plans ] for future in futures: future.result() else: for plan_entry in executable_plans: execute_plan(plan_entry) executed_plan_count = len(executable_plans) if executed_plan_count or skipped_plan_count: logger.info( "Warm container loader prewarm finished for component=%s executed=%d skipped=%d.", component_id, executed_plan_count, skipped_plan_count, ) def _llm_prewarm_model_profile(plan: Mapping[str, Any]) -> str: """Return the staged model profile from one rewritten LLM warmup plan.""" prompt_node = plan.get("prompt_node") if isinstance(prompt_node, Mapping): inputs = prompt_node.get("inputs") if isinstance(inputs, Mapping): model_profile = inputs.get("model_profile") if isinstance(model_profile, str) and model_profile.strip(): return model_profile.strip() model_profile = plan.get("model_profile") if not isinstance(model_profile, str) or not model_profile.strip(): raise ValueError("LLM prewarm plan requires a fixed model_profile.") return model_profile.strip() def _llm_compile_manifest_path(signature: str) -> Path: """Return the content-addressed completion marker for one JIT warmup plan.""" cache_root = Path( os.getenv("TRITON_CACHE_DIR", str(_REMOTE_LLM_COMPILE_CACHE_ROOT)) ).parent return cache_root / "manifests" / f"{signature}.json" def _write_llm_compile_manifest( *, signature: str, model_profile: str, result: Mapping[str, Any], ) -> Path: """Atomically publish successful representative-warmup metadata.""" manifest_path = _llm_compile_manifest_path(signature) manifest_path.parent.mkdir(parents=True, exist_ok=True) temporary_path = manifest_path.with_suffix(f".{os.getpid()}.tmp") temporary_path.write_text( json.dumps( { "signature": signature, "model_profile": model_profile, "runtime_fingerprint": os.getenv( "COMFY_MODAL_RUNTIME_FINGERPRINT", "" ), "completed_at": time.time(), "result": dict(result), }, sort_keys=True, ), encoding="utf-8", ) temporary_path.replace(manifest_path) return manifest_path def _execute_llm_prewarm_plans( *, component_id: str, prompt_id: str | None, llm_prewarm_plans: list[dict[str, Any]], compile_cache_volume: Any | None, ) -> list[dict[str, Any]]: """Load resident LLMs, exercise representative shapes, and commit JIT caches.""" from modal_llm_runtime import prewarm_modal_llm_profile results: list[dict[str, Any]] = [] for plan in llm_prewarm_plans: if not isinstance(plan, Mapping): continue plan_signature = str(plan.get("signature") or "").strip() if not plan_signature: raise ValueError("LLM prewarm plan requires a stable signature.") model_profile = _llm_prewarm_model_profile(plan) signature = hashlib.sha256( json.dumps( { "model_profile": model_profile, "plan_signature": plan_signature, "runtime_fingerprint": os.getenv( "COMFY_MODAL_RUNTIME_FINGERPRINT", "" ), }, sort_keys=True, ).encode("utf-8") ).hexdigest() manifest_path = _llm_compile_manifest_path(signature) representative_request_count = ( 1 if manifest_path.exists() else max(1, int(plan.get("representative_request_count") or 3)) ) with _LLM_PREWARM_PLAN_KEYS_LOCK: already_resident = signature in _LLM_PREWARM_PLAN_KEYS _LLM_PREWARM_PLAN_KEYS.add(signature) if already_resident: logger.info( "Skipping duplicate resident LLM prewarm profile=%s component=%s.", model_profile, component_id, ) continue try: compile_checkpoint = _LLMCompileMissCheckpoint( profiles=(model_profile,), signal_size=_triton_compile_miss_signal_size(), listener_engine_pids=_triton_compile_listener_engine_pids(), ) with _timed_phase( "llm_representative_prewarm", component=component_id, profile=model_profile, requests=representative_request_count, ): result = prewarm_modal_llm_profile( model_profile=model_profile, representative_request_count=representative_request_count, workflow_execution_id=prompt_id, ) manifest_path = _write_llm_compile_manifest( signature=signature, model_profile=model_profile, result=result, ) compile_cache_committed = _commit_actual_llm_compile_cache( compile_checkpoint, compile_cache_volume, ) results.append( { **result, "manifest_path": str(manifest_path), "manifest_cache_hit": representative_request_count == 1, "compile_cache_committed": compile_cache_committed, } ) except Exception: with _LLM_PREWARM_PLAN_KEYS_LOCK: _LLM_PREWARM_PLAN_KEYS.discard(signature) raise return results def _llm_profiles_in_payload(payload: Mapping[str, Any]) -> tuple[str, ...]: """Collect ModalLLM profiles in the executable subgraph dependency closure.""" if payload.get("payload_kind") not in {"subgraph", "mapped_subgraph"}: return () subgraph_prompt = payload.get("subgraph_prompt") execute_node_ids = payload.get("execute_node_ids") if not isinstance(subgraph_prompt, Mapping) or not isinstance( execute_node_ids, (list, tuple) ): return () prompt = {str(node_id): node for node_id, node in subgraph_prompt.items()} profiles: set[str] = set() visited: set[str] = set() pending = [str(node_id) for node_id in execute_node_ids] while pending: node_id = pending.pop() if node_id in visited: continue visited.add(node_id) prompt_node = prompt.get(node_id) if not isinstance(prompt_node, Mapping): continue inputs = prompt_node.get("inputs") if prompt_node.get("class_type") == "ModalLLM" and isinstance( inputs, Mapping ): profile = inputs.get("model_profile") if isinstance(profile, str) and profile.strip(): profiles.add(profile.strip()) if not isinstance(inputs, Mapping): continue for input_value in inputs.values(): if _is_link(input_value): pending.append(str(input_value[0])) return tuple(sorted(profiles)) @dataclass(frozen=True) class _LLMCompileMissCheckpoint: """Capture the genuine Triton miss signal before one LLM subgraph executes.""" profiles: tuple[str, ...] signal_size: int listener_engine_pids: tuple[int, ...] def _triton_compile_miss_signal_size() -> int: """Read the EngineCore compile-miss signal shared through container storage.""" runtime_module = importlib.import_module("modal_llm_runtime") signal_reader = getattr(runtime_module, "triton_compile_miss_signal_size", None) if not callable(signal_reader): raise RuntimeError( "Modal LLM runtime does not expose triton_compile_miss_signal_size()." ) return int(signal_reader()) def _triton_compile_listener_engine_pids() -> tuple[int, ...]: """Return live EngineCore processes with cache-aware Triton telemetry.""" runtime_module = importlib.import_module("modal_llm_runtime") listener_reader = getattr( runtime_module, "triton_compile_listener_engine_pids", None, ) if not callable(listener_reader): raise RuntimeError( "Modal LLM runtime does not expose " "triton_compile_listener_engine_pids()." ) return tuple(int(pid) for pid in listener_reader()) def _llm_compile_miss_checkpoint( payload: Mapping[str, Any], ) -> _LLMCompileMissCheckpoint | None: """Capture the current miss signal for an executable ModalLLM subgraph.""" profiles = _llm_profiles_in_payload(payload) if not profiles: return None return _LLMCompileMissCheckpoint( profiles=profiles, signal_size=_triton_compile_miss_signal_size(), listener_engine_pids=_triton_compile_listener_engine_pids(), ) def _commit_actual_llm_compile_cache( checkpoint: _LLMCompileMissCheckpoint | None, compile_cache_volume: Any | None, ) -> bool: """Commit the compile-cache Volume after a genuine Triton disk-cache miss.""" if checkpoint is None or compile_cache_volume is None: return False listener_engine_pids = _triton_compile_listener_engine_pids() if not listener_engine_pids: logger.warning( "Skipping LLM compile-cache commit because no live vLLM EngineCore " "reported the cache-aware Triton listener profiles=%s " "listener_pids_before=%s.", checkpoint.profiles, checkpoint.listener_engine_pids, ) return False signal_size = _triton_compile_miss_signal_size() if signal_size < checkpoint.signal_size: raise RuntimeError( "Triton compile-miss signal shrank during LLM execution: " f"before={checkpoint.signal_size} after={signal_size}." ) if signal_size == checkpoint.signal_size: logger.info( "Skipping LLM compile-cache commit because every Triton lookup hit " "the persistent cache profiles=%s signal_size=%d listener_pids=%s.", checkpoint.profiles, signal_size, listener_engine_pids, ) return False commit_method = getattr(compile_cache_volume, "commit", None) if not callable(commit_method): raise RuntimeError("Modal compile-cache Volume does not expose commit().") with _timed_phase( "llm_actual_compile_cache_commit", profiles=checkpoint.profiles, miss_signal_bytes=signal_size - checkpoint.signal_size, ): commit_method() return True configure_cloud_session_bridge_hooks( CloudSessionBridgeHooks( clone_loader_cache_value=_clone_loader_cache_value, emit_cloud_info=_emit_cloud_info, execute_node_locally_raw=_execute_node_locally_raw, execute_subgraph_prompt=_execute_subgraph_prompt, is_link=_is_link, normalize_prompt_input_value=_normalize_prompt_input_value, resolve_required_subgraph_nodes=_resolve_required_subgraph_nodes, ) ) configure_cloud_prompt_server_hooks( CloudPromptServerHooks( collapse_cache_slot=_collapse_cache_slot, emit_cloud_info=_emit_cloud_info, meaningful_progress_values=_meaningful_progress_values, ) ) if modal is not None: # pragma: no branch - remote entrypoint configuration. settings = globals().get("__comfy_modal_settings_override__") or get_settings() __comfy_modal_gpu__ = settings.modal_gpu __comfy_modal_app_name__ = modal_deployment_app_name(settings) __comfy_modal_secret_name__ = str( getattr(settings, "modal_secret_name", DEFAULT_MODAL_SECRET_NAME) ).strip() _guard_against_existing_modal_app(settings, modal) app = modal.App(__comfy_modal_app_name__) modal_secret = _modal_secret_from_settings(settings, modal) vol = modal.Volume.from_name(settings.volume_name, create_if_missing=True) llm_compile_cache_vol = modal.Volume.from_name( getattr( settings, "llm_compile_cache_volume_name", f"{settings.volume_name}-llm-compile-cache", ), create_if_missing=True, ) interrupt_flags = modal.Dict.from_name( settings.interrupt_dict_name, create_if_missing=True, ) node_output_cache = modal.Dict.from_name( settings.node_output_cache_dict_name, create_if_missing=True, ) session_bridge_cache = modal.Dict.from_name( settings.session_bridge_dict_name, create_if_missing=True, ) invocation_records = modal.Dict.from_name( settings.invocation_dict_name, create_if_missing=True, ) snapshot_profiles = modal.Dict.from_name( settings.snapshot_profile_dict_name, create_if_missing=True, ) register_cloud_runtime_stores( session_bridge_cache=session_bridge_cache, invocation_records=invocation_records, volume=vol, snapshot_profiles=snapshot_profiles, node_output_cache=node_output_cache, interrupt_flags=interrupt_flags, ) custom_node_packages = _custom_node_runtime_packages(settings.custom_nodes_dir) torch_build = _select_remote_torch_build(settings.modal_gpu) runtime_identity = build_remote_runtime_identity( repo_root=_REPO_ROOT, comfyui_root=settings.comfyui_root, custom_nodes_dir=settings.custom_nodes_dir, settings=settings, ) logger.info( "Building Modal runtime fingerprint=%s protocol=%d python=%s.", runtime_identity.fingerprint, _REMOTE_APP_PROTOCOL_VERSION, REMOTE_PYTHON_VERSION, ) logger.info( "Selected Modal PyTorch build gpu=%s cuda=%s install_layers=%s.", settings.modal_gpu, torch_build.cuda_version, torch_build.install_layers, ) image = ( modal.Image.debian_slim(python_version=REMOTE_PYTHON_VERSION) .apt_install(*_comfyui_apt_packages()) .pip_install(*_comfyui_runtime_packages()) ) image = _install_custom_node_packages(image, custom_node_packages) image = _install_remote_torch_build(image, torch_build) image = _install_remote_accelerator_packages(image, settings.modal_gpu) image = image.env( _modal_image_environment(settings, runtime_identity.fingerprint) ) image = image.add_local_dir( _REPO_ROOT, remote_path="/root/comfyui_modal_sync_repo", ignore=_should_ignore_repo_path, ) if settings.comfyui_root is not None and settings.comfyui_root.exists(): image = image.add_local_dir( settings.comfyui_root, remote_path=str(_REMOTE_COMFYUI_ROOT), ignore=_should_ignore_comfyui_path, ) logger.info( "Including local ComfyUI checkout %s in Modal image at %s.", settings.comfyui_root, _REMOTE_COMFYUI_ROOT, ) else: logger.warning( "No local ComfyUI checkout was discovered; remote Modal execution may fail to import ComfyUI core modules." ) stager_image = ( modal.Image.debian_slim(python_version=REMOTE_PYTHON_VERSION) .env( _model_stager_image_environment( settings, runtime_identity.fingerprint, ) ) .pip_install(*_remote_huggingface_packages()) .run_commands(_remote_huggingface_validation_command()) .add_local_dir( _REPO_ROOT, remote_path="/root/comfyui_modal_sync_repo", ignore=_should_ignore_repo_path, ) ) @app.cls( image=stager_image, volumes={settings.remote_storage_root: vol}, secrets=[modal_secret], cpu=4.0, memory=16384, max_containers=1, scaledown_window=300, timeout=7200, ) @modal.concurrent(max_inputs=1) class ModelStager: """Resolve and stage pinned Hugging Face snapshots without consuming GPU time.""" def _stage_profiles( self, model_references: list[str], resolved_profiles: Mapping[str, Any] | None = None, progress_callback: Callable[[dict[str, Any]], None] | None = None, ) -> list[dict[str, Any]]: """Resolve and stage profiles while optionally publishing progress.""" staged_profiles = resolve_and_stage_model_references( model_references, settings.remote_storage_root, resolved_profiles=resolved_profiles, owner_id=f"modal:{os.getpid()}:{time.time_ns()}", progress_callback=( lambda progress: progress_callback( { "stage": progress.stage, "message": progress.message, "value": progress.value, "max": progress.maximum, "unit": progress.unit, "indeterminate": progress.indeterminate, "model_reference": progress.model_reference, } ) if progress_callback is not None else None ), ) results = [profile.to_dict() for profile in staged_profiles] if any( result["downloaded"] or result["manifest_created"] for result in results ): vol.commit() else: logger.info( "Skipping Modal Volume commit because all requested LLM " "profiles and weights were already durable." ) logger.info( "Modal LLM CPU resolution and staging completed for models=%s.", model_references, ) return results @modal.method() def stage_profiles( self, model_references: list[str], resolved_profiles: Mapping[str, Any] | None = None, ) -> list[dict[str, Any]]: """Resolve model references, stage snapshots, and return metadata.""" return self._stage_profiles(model_references, resolved_profiles) @modal.method() def stage_profiles_stream( self, model_references: list[str], resolved_profiles: Mapping[str, Any] | None = None, ) -> Iterator[dict[str, Any]]: """Stream CPU staging progress and finish with resolved profile data.""" progress_events: queue.Queue[dict[str, Any]] = queue.Queue() results: list[list[dict[str, Any]]] = [] errors: list[Exception] = [] def run_staging() -> None: """Run blocking Hugging Face work while the generator yields events.""" try: results.append( self._stage_profiles( model_references, resolved_profiles, progress_events.put, ) ) except Exception as error: errors.append(error) staging_thread = threading.Thread( target=run_staging, name="modal-llm-model-stager", daemon=True, ) staging_thread.start() while staging_thread.is_alive() or not progress_events.empty(): try: progress = progress_events.get(timeout=0.25) except queue.Empty: continue yield {"kind": "progress", **progress} staging_thread.join() if errors: raise errors[0] yield {"kind": "result", "results": results[0] if results else []} @modal.method() def runtime_version(self) -> dict[str, Any]: """Return deployment identity without allocating a GPU container.""" return { "protocol_version": _REMOTE_APP_PROTOCOL_VERSION, "app_name": __comfy_modal_app_name__, "runtime_fingerprint": os.environ.get( "COMFY_MODAL_RUNTIME_FINGERPRINT", "", ), "python_version": f"{sys.version_info.major}.{sys.version_info.minor}", } @app.cls( **_remote_engine_cls_options( settings, vol, image, modal_secret, llm_compile_cache_vol, ) ) @modal.concurrent(max_inputs=1) class RemoteEngine: """Modal runtime class that executes proxied ComfyUI payloads.""" snapshot_profile_key: str = modal.parameter(default="") gpu_snapshot_enabled: bool = modal.parameter(default=False) worker_affinity_key: str = modal.parameter(default="worker-pool:slot:0") @modal.enter(snap=True) def setup_snapshot_state(self) -> None: """Prepare snapshot-friendly runtime state before Modal captures memory.""" with _timed_phase("remote_engine_setup_snapshot"): _prewarm_snapshot_state( gpu_snapshot_enabled=bool(self.gpu_snapshot_enabled), snapshot_profile_key=self.snapshot_profile_key, ) logger.info( "RemoteEngine snapshot setup complete for snapshot_profile_key=%s gpu_snapshot_enabled=%s worker_affinity=%s.", self.snapshot_profile_key or None, bool(self.gpu_snapshot_enabled), self.worker_affinity_key, ) @modal.enter(snap=False) def setup_restored_runtime(self) -> None: """Prepare request-serving runtime state after a fresh boot or snapshot restore.""" with _timed_phase("remote_engine_setup_restored"): _prewarm_restored_runtime(llm_compile_cache_vol) logger.info( "RemoteEngine restored-runtime setup complete for snapshot_profile_key=%s.", self.snapshot_profile_key or None, ) @modal.method() def execute_payload( self, payload: dict[str, Any], kwargs_payload: bytes ) -> bytes: """Execute a proxied node or subgraph inside the Modal container.""" _observe_remote_workflow_for_llm_mode(payload) component_id = payload.get("component_id", "single-node") reload_marker = _modal_volume_reload_marker(payload) try: with _registered_remote_execution(payload) as execution_control: with _timed_phase( "remote_engine_execute_payload", component=component_id, payload_kind=payload.get("payload_kind"), ): _hydrate_missing_payload_volume_paths(vol, payload) if _should_reload_modal_volume(payload): _reload_modal_volume_for_request( vol, str(component_id), reload_marker=reload_marker, payload=payload, ) else: _emit_modal_volume_reload_skip(component_id, payload) def execute_once() -> bytes: """Execute the underlying payload once inside this request context.""" if payload.get("payload_kind") == "canary": return _execute_canary_payload( payload, kwargs_payload, cancellation_event=execution_control.cancellation_event, interrupt_store=interrupt_flags, interrupt_flag_key=execution_control.interrupt_flag_key, ) if payload.get("payload_kind") == "mapped_subgraph": custom_nodes_root = _extract_custom_nodes_bundle( payload.get("custom_nodes_bundle") ) _ensure_comfy_runtime_initialized(custom_nodes_root) hydrated_inputs = deserialize_node_inputs( kwargs_payload ) return serialize_node_outputs( _execute_mapped_subgraph_payload( payload, hydrated_inputs, custom_nodes_root, cancellation_event=execution_control.cancellation_event, interrupt_store=interrupt_flags, interrupt_flag_key=execution_control.interrupt_flag_key, ) ) if payload.get("payload_kind") == "subgraph": return execute_subgraph_locally( payload, kwargs_payload, cancellation_event=execution_control.cancellation_event, interrupt_store=interrupt_flags, interrupt_flag_key=execution_control.interrupt_flag_key, ) return execute_node_locally( payload, kwargs_payload, cancellation_event=execution_control.cancellation_event, interrupt_store=interrupt_flags, interrupt_flag_key=execution_control.interrupt_flag_key, ) compile_miss_checkpoint = _llm_compile_miss_checkpoint(payload) result = _execute_with_durable_invocation( payload, execute_once ) _commit_actual_llm_compile_cache( compile_miss_checkpoint, llm_compile_cache_vol, ) return result except Exception as exc: _maybe_schedule_container_termination_on_error(payload, exc) raise @modal.method() def warmup_for_request(self, payload: dict[str, Any]) -> dict[str, Any]: """Prime the current or a newly started Modal container for one prompt.""" return _prepare_warm_container_for_request( vol, payload, llm_compile_cache_vol, ) @modal.method() def keepalive_for_local_gap(self, payload: dict[str, Any]) -> dict[str, Any]: """Keep this affinity slot active while the workflow executes locally.""" logger.info( "Remote local-gap keepalive prompt=%s component=%s worker_affinity=%s.", payload.get("prompt_id"), payload.get("component_id"), self.worker_affinity_key, ) return { "component_id": str(payload.get("component_id") or "modal-keepalive"), "task_id": os.getenv("MODAL_TASK_ID"), "worker_affinity_key": self.worker_affinity_key, } @modal.method() def runtime_version(self) -> dict[str, Any]: """Return the deployed runtime identity expected by the local client.""" return { "protocol_version": _REMOTE_APP_PROTOCOL_VERSION, "app_name": __comfy_modal_app_name__, "runtime_fingerprint": os.environ.get( "COMFY_MODAL_RUNTIME_FINGERPRINT", "", ), "python_version": f"{sys.version_info.major}.{sys.version_info.minor}", "vllm_version": importlib.metadata.version("vllm"), } @modal.method() def execute_payload_stream( self, payload: dict[str, Any], kwargs_payload: bytes, ) -> Iterator[dict[str, Any]]: """Stream progress envelopes and a final serialized result for one payload.""" _observe_remote_workflow_for_llm_mode(payload) component_id = payload.get("component_id", "single-node") reload_marker = _modal_volume_reload_marker(payload) try: with _registered_remote_execution(payload) as execution_control: with _timed_phase( "remote_engine_execute_payload", component=component_id, payload_kind=payload.get("payload_kind"), ): _hydrate_missing_payload_volume_paths(vol, payload) if _should_reload_modal_volume(payload): _reload_modal_volume_for_request( vol, str(component_id), reload_marker=reload_marker, payload=payload, ) else: _emit_modal_volume_reload_skip(component_id, payload) compile_miss_checkpoint = _llm_compile_miss_checkpoint(payload) yield from _stream_remote_payload_events( payload, kwargs_payload, cancellation_event=execution_control.cancellation_event, interrupt_store=interrupt_flags, interrupt_flag_key=execution_control.interrupt_flag_key, ) _commit_actual_llm_compile_cache( compile_miss_checkpoint, llm_compile_cache_vol, ) except Exception as exc: _maybe_schedule_container_termination_on_error(payload, exc) raise else: app = None RemoteEngine = None