fix(huggingface): avoid cache writes during force search

core/sources/huggingface.py

@@ -317,7 +317,10 @@ def _fetch_author_index(author: str, headers: Dict[str, str], limit: int = 200):
 
 
 def _get_author_index(
-    author: str, headers: Dict[str, str], force_refresh: bool = False
+    author: str,
+    headers: Dict[str, str],
+    force_refresh: bool = False,
+    persist: bool = True,
 ) -> Optional[Dict[str, Any]]:
     cache_key = _author_index_cache_key(author, headers)
     can_persist = not headers.get("Authorization")
@@ -340,7 +343,7 @@ def _get_author_index(
         fresh_index = _fetch_author_index(author, headers=headers)
         if fresh_index:
             _author_index_cache[cache_key] = fresh_index
-            if can_persist:
+            if can_persist and persist:
                 _write_persistent_author_index(author, fresh_index)
             return fresh_index
 
@@ -1082,6 +1085,7 @@ def search_huggingface_for_file(
                     author,
                     headers={},
                     force_refresh=force_refresh,
+                    persist=not force_refresh,
                 )
                 cached_author_indexes[author] = index
                 if not index:
@@ -1224,6 +1228,7 @@ def search_huggingface_for_file(
                         author,
                         headers={},
                         force_refresh=force_refresh,
+                        persist=not force_refresh,
                     )
                 if index:
                     result = _find_matching_file_in_author_index(

tests/test_huggingface.py

@@ -8,6 +8,7 @@ from core.sources.huggingface import (
     HF_AUTHOR_FALLBACKS,
     _build_author_index_from_models,
     _fetch_author_index,
+    _get_author_index,
     _find_matching_file_in_author_index,
     _is_author_index_fresh,
     _read_persistent_author_indexes,
@@ -239,6 +240,106 @@ class HuggingFaceSourceTests(unittest.TestCase):
             self.assertTrue(content.endswith("\n"))
             self.assertEqual("Example", json.loads(content)["authors"]["Example"]["author"])
 
+    def test_force_search_author_index_refresh_does_not_persist(self):
+        fresh_index = {
+            "author": "Example",
+            "updated_at": 123,
+            "repo_count": 1,
+            "file_count": 1,
+            "hash_count": 1,
+            "repos": ["Example/repo"],
+            "files": [],
+        }
+        with tempfile.TemporaryDirectory() as tmpdir:
+            index_path = Path(tmpdir) / "huggingface-author-index.json"
+            with (
+                patch(
+                    "core.sources.huggingface.HF_AUTHOR_INDEX_CACHE_PATH",
+                    str(index_path),
+                ),
+                patch(
+                    "core.sources.huggingface._fetch_author_index",
+                    return_value=fresh_index,
+                ) as fetch_index,
+            ):
+                clear_search_cache()
+                result = _get_author_index(
+                    "Example",
+                    headers={},
+                    force_refresh=True,
+                    persist=False,
+                )
+
+            self.assertIs(fresh_index, result)
+            self.assertFalse(index_path.exists())
+            fetch_index.assert_called_once_with("Example", headers={})
+
+    def test_force_search_requests_non_persistent_author_index_refresh(self):
+        sha256 = "d" * 64
+        index = {
+            "author": "Comfy-Org",
+            "updated_at": 123,
+            "repo_count": 1,
+            "file_count": 1,
+            "hash_count": 1,
+            "repos": ["Comfy-Org/example"],
+            "files": [
+                {
+                    "repo_id": "Comfy-Org/example",
+                    "path": "model.safetensors",
+                    "filename": "model.safetensors",
+                    "size": 123,
+                    "sha256": sha256,
+                }
+            ],
+        }
+
+        clear_search_cache()
+        with patch(
+            "core.sources.huggingface._get_author_index",
+            return_value=index,
+        ) as get_index:
+            result = search_huggingface_for_file(
+                "model.safetensors",
+                sha256=sha256,
+                force_refresh=True,
+            )
+
+        self.assertIsNotNone(result)
+        self.assertFalse(get_index.call_args.kwargs["persist"])
+
+    def test_explicit_author_index_refresh_still_persists(self):
+        fresh_index = {
+            "author": "Example",
+            "updated_at": 123,
+            "repo_count": 1,
+            "file_count": 1,
+            "hash_count": 1,
+            "repos": ["Example/repo"],
+            "files": [],
+        }
+        with tempfile.TemporaryDirectory() as tmpdir:
+            index_path = Path(tmpdir) / "huggingface-author-index.json"
+            with (
+                patch(
+                    "core.sources.huggingface.HF_AUTHOR_INDEX_CACHE_PATH",
+                    str(index_path),
+                ),
+                patch(
+                    "core.sources.huggingface._fetch_author_index",
+                    return_value=fresh_index,
+                ),
+            ):
+                clear_search_cache()
+                result = _get_author_index(
+                    "Example",
+                    headers={},
+                    force_refresh=True,
+                )
+
+            self.assertIs(fresh_index, result)
+            self.assertTrue(index_path.exists())
+
     def test_parse_huggingface_url_valid_http(self):
         url = "https://huggingface.co/runwayml/stable-diffusion-v1-5/resolve/main/v1-5-pruned-emaonly.safetensors"
         result = parse_huggingface_url(url)