nodes/Azornes-Comfyui-Model-Resolver
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve MLFilterSwitch DOM handling

Browse Source 
Make MLFilterSwitch more robust by guarding against a missing filter button and caching the element reference before toggling active state. Use getAttribute('data-...') instead of dataset for consistent data access, and adjust child DIV indexing to account for a category header so active/inactive sections are selected correctly. Add comments and clearer variable names for maintainability.
This commit is contained in:
Dariusz L
2026-04-19 21:08:33 +02:00
parent 994d68d958
commit 718e01a491
1 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/linker.js
+13 -8
View File
@@ -4090,17 +4090,22 @@ app.registerExtension({
// Global helper functions for inline onclick handlers
window.MLFilterSwitch = function(filter) {
document.querySelectorAll('.ml-btn-filter').forEach(b => b.classList.remove('active'));
document.getElementById('filter-' + filter).classList.add('active');
const filterBtn = document.getElementById('filter-' + filter);
if (!filterBtn) return;
// Update button states
document.querySelectorAll('.ml-btn-filter').forEach(b => b.classList.remove('active'));
filterBtn.classList.add('active');
// Filter model sections
document.querySelectorAll('.ml-model-section').forEach(s => {
const hasActive = s.dataset.mlActive === 'true';
const hasInactive = s.dataset.mlInactive === 'true';
const hasActive = s.getAttribute('data-ml-active') === 'true';
const hasInactive = s.getAttribute('data-ml-inactive') === 'true';
// Get direct child divs (active and inactive sections)
const subSections = Array.from(s.children).filter(c => c.tagName === 'DIV');
const activeSection = subSections[0];
const inactiveSection = subSections[1];
// Get child divs: category header, active section, inactive section
const childDivs = Array.from(s.children).filter(c => c.tagName === 'DIV');
const activeSection = childDivs[1];
const inactiveSection = childDivs[2];
if (filter === 'all') {
s.style.display = 'block';