Commit Graph
179 Commits
Author SHA1 Message Date
Vito Sansevero f7d007d8c4 style: Fix line break in test assertion 2025-08-08 18:16:08 -07:00
Vito Sansevero 80045954a5 refactor(node): handle missing folder_paths module 2025-08-08 18:07:38 -07:00
Vito Sansevero 6f176e7b78 test: Refactor folder_paths mocking setup 2025-08-08 18:00:35 -07:00
Vito Sansevero 576efbba41 feat: complete embedding autocomplete implementation with all features
- Remove debug code and console.log statements
- Fix test suite to properly mock folder_paths module
- Update test expectations to match actual implementation
- Add comprehensive README documentation with feature list
- Add placeholder images for documentation screenshots
- Include diagnostic scripts for testing embedding paths
- All tests passing (338 passed, 2 skipped)

Features implemented:
- Autocomplete for embeddings, LoRAs, and custom tags
- Custom word list loading from URL (with security validation)
- Configurable triggers and settings
- Auto-insert comma, replace underscores, Tab/Enter selection
- Smart scrolling in suggestion list
- Secure content validation to prevent XSS attacks

Credits to pythongosssss/ComfyUI-Custom-Scripts for inspiration
2025-08-08 17:45:21 -07:00
Vito Sansevero 593bd4de79 fix: support both 'embedding:' and 'embeddings:' triggers
- Accept both singular and plural forms
- Common user expectation to use plural
- Regex pattern now matches embeddings?:
- Works with 120 loaded embeddings
2025-08-08 15:19:52 -07:00
Vito Sansevero a8fb5ddaa7 fix: use file_name property for embedding names
- Extract embedding names from file_name property
- Filter out null/undefined entries
- Successfully processes 120 embeddings with proper names
- Cleaner extraction logic based on actual API response structure
2025-08-08 15:17:49 -07:00
Vito Sansevero f67e619930 fix: properly extract embedding names from object items
- Add comprehensive object property checking
- Try multiple property names (name, filename, title, id, embedding_name)
- Log item structure to understand format
- Handle both string and object item formats
2025-08-08 15:14:37 -07:00
Vito Sansevero f9e2f5bcc5 fix: improve embedding pagination with api method
- Try api.getEmbeddings(page) for pagination
- Add better logging to see item format
- Gracefully fall back to first page if pagination fails
- Log sample items to understand structure
2025-08-08 15:09:45 -07:00
Vito Sansevero 2cfeab9e76 fix: handle paginated embeddings API response
- Detect and parse paginated response format (items array)
- Fetch all pages to get complete embeddings list (113 total)
- Support both paginated and object formats for compatibility
- Extract actual embedding names from items array
- Debug shows successful trigger detection for 'embedding:'
2025-08-08 15:06:31 -07:00
Vito Sansevero f5ce23ad12 fix: handle ComfyUI's embeddings object response format
- Parse embeddings from object keys instead of expecting array
- Remove file extensions from embedding names
- Add fallback method for LoRAs using /object_info API
- Delay widget attachment to catch dynamically created widgets
- Better detection of textarea widgets regardless of type
2025-08-08 15:03:40 -07:00
Vito Sansevero 05a9520436 debug: add comprehensive logging to diagnose autocomplete issues
- Add console logging to JS for resource fetching and widget attachment
- Add debug mode with window.kikoDebug for inspection
- Log Python API endpoint registration and file discovery
- Track widget creation and event handling
- Show first 5 items when loading resources
2025-08-08 15:00:28 -07:00
Vito Sansevero c1fcc4566b fix: improve embedding autocomplete detection and triggers
- Use ComfyUI's native api.getEmbeddings() for proper embedding detection
- Add dedicated /kikotools/autocomplete/loras endpoint for LoRA files
- Improve trigger detection for "embedding:" and "<lora:" patterns
- Context-aware suggestions based on trigger type
- Better insertion logic that maintains correct syntax
- Sort suggestions by relevance (exact match, starts with, alphabetical)
- Fix character matching patterns to include underscores and hyphens
2025-08-08 14:55:55 -07:00
Vito Sansevero 40b91fc44f feat: enhance embedding autocomplete with interactive test panel
- Add debug/test panel to the node with helpful usage hints
- Display counts of available embeddings and LoRAs
- Show sample items and status information
- Include clear instructions for triggering autocomplete
- Update display name with 🫶 branding
- Make node an OUTPUT_NODE to display information
2025-08-08 13:58:45 -07:00
Vito Sansevero 3e7734bbc3 feat: add KikoEmbeddingAutocomplete with settings registry system
- Implement centralized settings registry for all KikoTools
- Create KikoEmbeddingAutocomplete node with backend API
- Add frontend JavaScript autocomplete widget with ComfyUI integration
- Support for embeddings and LoRAs with smart filtering
- Configurable settings in ComfyUI UI with 🫶 branding
- Include keyboard navigation and real-time suggestions
2025-08-08 13:20:09 -07:00
Vito 17400d88f7 Merge pull request #30 from ComfyAssets/feature/kiko-film-grain
feat: add KikoFilmGrain node for realistic film grain effects
2025-08-07 18:50:48 -07:00
Vito Sansevero 0f79601065 feat: add KikoFilmGrain node for realistic film grain effects
- Implement film grain effect with customizable parameters (scale, strength, saturation, toe, seed)
- Use pure PyTorch operations for better GPU utilization (no OpenCV dependencies)
- Apply ITU-R BT.709 color space conversion for accurate grain distribution
- Implement screen blend mode for better highlight preservation
- Add channel-specific weighting matching real film characteristics (3x blue, 2x red)
- Preserve alpha channel when present
- Add comprehensive test suite (20 tests covering all functionality)
- Include documentation and example workflow
- Register node under ComfyAssets/image category

Improvements over reference implementation:
- More efficient memory management avoiding numpy/OpenCV conversions
- Better grain mixing algorithm with proper color science
- Improved performance through PyTorch-native operations
2025-08-07 18:42:37 -07:00
Vito Sansevero df60457929 chore: bump version to 1.0.12 in pyproject.toml 2025-08-07 08:01:18 -07:00
Vito 5d0e8194a1 Merge pull request #29 from ComfyAssets/fix/display-nodes-scrolling
Fix/display nodes scrolling
2025-08-07 08:00:50 -07:00
Vito Sansevero 218a208bf0 feat(display): add copy buttons as ComfyUI widgets
- Add copy buttons using addCustomWidget for proper integration
- Display Text: separate copy buttons for positive/negative prompts
- Display Any: single copy button for entire value
- Visual feedback shows "✓ Copied\!" for 1.5 seconds
- Buttons work with ComfyUI's widget system

Restores copy functionality while maintaining scrolling fixes
2025-08-07 07:25:21 -07:00
Vito Sansevero a7b612d799 fix(display): handle DOM not ready for appendChild operations
- Add proper null checks before appendChild calls
- Use requestAnimationFrame to ensure DOM elements exist
- Check both inputEl and parentNode before adding buttons
- Prevent "Cannot read properties of null" errors on load

Fixes workflow loading errors with display nodes
2025-08-07 07:05:09 -07:00
Vito Sansevero df3d4c19cb fix(display): use ComfyUI's native STRING widgets for proper scrolling
- Replace custom draw implementations with ComfyWidgets["STRING"]
- Fix cursor display issues (was showing + instead of text cursor)
- Enable native scrolling behavior for both Display Text and Display Any
- Maintain all existing features (copy buttons, split view for prompts)
- Add proper widget cleanup and state management
- Reference: ShowText implementation from ComfyUI-Custom-Scripts

Fixes scrolling and cursor issues in display nodes
2025-08-07 06:45:35 -07:00
Vito Sansevero 938d0d93de chore(pyproject): bump version to 1.0.11 2025-08-07 06:35:34 -07:00
Vito e65bf123b5 Merge pull request #28 from ComfyAssets/feat/add-comfyui-essentials-nodes
Feat/add comfyui essentials nodes
2025-08-07 06:25:36 -07:00
Vito Sansevero b348273d3a fix(tests): update GitHub Actions tests for emoji categories
- Fix RETURN_TYPES assertion for Sampler Combo (SCHEDULERS is a list)
- Update all CATEGORY assertions to support emoji-based categories
- Change from exact match to startswith('ComfyAssets/') for flexibility
- All tests now properly validate the new category system
2025-08-07 06:16:33 -07:00
Vito Sansevero cc1ffe2605 docs: correct emoji categories in README
- Update categories to match actual implementation:
  - Seed History: 🌱 Seeds (not 🎯 Advanced)
  - Sampler Combo: 🌀 Samplers (not ⚙️ Sampling)
  - Display Text/Any: 👁️ Display (not 📋 Text/🔍 Debug)
- Correct total unique categories count to 8
- All 16 nodes now correctly documented with their actual categories
2025-08-07 06:10:21 -07:00
Vito Sansevero ef30413e12 docs: add LoRA testing workflow screenshot and examples
- Add screenshot for xyz_helpers_lora_testing workflow
- Include LoRA testing workflow in Common Workflows section
- Show real-world usage with strength ranges and combinatorial mode
2025-08-07 05:45:10 -07:00
Vito Sansevero 5485aa8c19 feat(xyz-helpers): add ComfyUI_essentials nodes adaptation
BREAKING CHANGE: Node categories now use emoji-based organization

Add 6 new xyz-helper nodes adapted from comfyui-essentials-nodes:
- FluxSamplerParams: FLUX-optimized parameter generator with batch support
- LoRAFolderBatch: Batch process multiple LoRAs from folders
- PlotParameters: Visualize parameter effects with graphs
- SamplerSelectHelper: Intelligent sampler selection with recommendations
- SchedulerSelectHelper: Optimal scheduler selection for samplers
- TextEncodeSamplerParams: Combined text encoding and parameter management

Changes:
- Port and enhance nodes from comfyui-essentials (now in maintenance mode)
- Add comprehensive documentation with attribution to original author (cubiq)
- Create example workflows for xyz-helpers tools
- Update all node categories to use emoji-based organization
- Fix all unit tests to pass with new category system
- Update README with xyz-helpers section and attribution

Attribution: xyz-helpers adapted from github.com/cubiq/ComfyUI_essentials

All tests passing (318 pass, 2 skip)
2025-08-07 05:41:23 -07:00
Vito Sansevero a8ee5930ff chore: bump version to 1.0.10 in pyproject.toml 2025-08-04 10:36:11 -07:00
Vito Sansevero 9fd80793db feat(init): add ImageScaleDownByNode support 2025-08-04 10:35:54 -07:00
Vito Sansevero 972c487dd4 Add image_scale_down_by tool and display_any.js
- Add new image_scale_down_by tool for downscaling images/latents
- Add display_any.js web component for node display
- Include comprehensive unit tests for the new tool
2025-08-04 07:17:55 -07:00
Vito 1a3efd3802 Merge pull request #26 from ComfyAssets/alert-autofix-8
Potential fix for code scanning alert no. 8: Workflow does not contain permissions
2025-08-02 08:48:43 -07:00
VitoandCopilot Autofix powered by AI 34f54e515d Potential fix for code scanning alert no. 8: Workflow does not contain permissions
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-08-02 08:38:37 -07:00
Vito c844abea51 Merge pull request #25 from ComfyAssets/alert-autofix-1
Potential fix for code scanning alert no. 1: Workflow does not contain permissions
2025-08-02 08:22:06 -07:00
VitoandCopilot Autofix powered by AI 404a1efd61 Potential fix for code scanning alert no. 1: Workflow does not contain permissions
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-08-02 08:14:03 -07:00
Vito 4ae514dacf Merge pull request #24 from ComfyAssets/alert-autofix-10
Potential fix for code scanning alert no. 10: Workflow does not contain permissions
2025-08-02 08:12:04 -07:00
VitoandCopilot Autofix powered by AI 5efae8eeb8 Potential fix for code scanning alert no. 10: Workflow does not contain permissions
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-08-02 08:00:10 -07:00
Vito 85288c8fd8 Create SECURITY.md 2025-08-02 07:54:21 -07:00
Vito 7a97f7c2bc Create CODE_OF_CONDUCT.md 2025-08-02 07:50:25 -07:00
Vito a4692a286c Merge pull request #22 from ComfyAssets/dependabot/github_actions/softprops/action-gh-release-2
build(deps): bump softprops/action-gh-release from 1 to 2
2025-08-02 07:48:07 -07:00
Vito 72a3fea3cb Merge pull request #23 from ComfyAssets/dependabot/github_actions/actions/cache-4
build(deps): bump actions/cache from 3 to 4
2025-08-02 07:47:44 -07:00
Vito d5d4145a04 Merge pull request #21 from ComfyAssets/dependabot/github_actions/actions/setup-python-5
build(deps): bump actions/setup-python from 4 to 5
2025-08-02 07:46:49 -07:00
dependabot[bot] 0e288dd109 build(deps): bump actions/cache from 3 to 4
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-02 14:43:46 +00:00
dependabot[bot] c4882f894e build(deps): bump softprops/action-gh-release from 1 to 2
Bumps [softprops/action-gh-release](https://github.com/softprops/action-gh-release) from 1 to 2.
- [Release notes](https://github.com/softprops/action-gh-release/releases)
- [Changelog](https://github.com/softprops/action-gh-release/blob/master/CHANGELOG.md)
- [Commits](https://github.com/softprops/action-gh-release/compare/v1...v2)

---
updated-dependencies:
- dependency-name: softprops/action-gh-release
  dependency-version: '2'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-02 14:43:43 +00:00
dependabot[bot] 6cbe6e5ae6 build(deps): bump actions/setup-python from 4 to 5
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](https://github.com/actions/setup-python/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-08-02 14:43:40 +00:00
Vito Sansevero df20afb83e style(dependabot): fix indentation in config file 2025-08-02 07:42:56 -07:00
Vito 7d63e11e18 Create dependabot.yml 2025-08-02 07:40:43 -07:00
Vito a8364b5c57 Merge pull request #20 from ComfyAssets/feature/add-tools-toc
docs: add tools table of contents to README
2025-08-02 07:35:13 -07:00
Vito Sansevero 332a74225d docs: add tools table of contents to README
- Add comprehensive TOC table under Current Tools section
- Include tool names with emojis as clickable links
- Add brief descriptions for each tool
- Categorize tools by functionality (Image Processing, Debugging, etc.)
- Improve navigation and tool discovery for users
2025-08-02 07:31:06 -07:00
Vito d757b623d6 Merge pull request #19 from ComfyAssets/feature/add-readme-screenshots
docs: add screenshots and complete documentation for all nodes
2025-08-02 07:24:25 -07:00
Vito Sansevero 64e844ec42 style: fix code formatting with black
- Add missing newlines at end of files
- Fix whitespace and indentation issues
- Format long function calls properly
2025-08-02 07:20:40 -07:00