nodes/ComfyAssets-ComfyUI_PromptManager
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs(review): number the live-updates-paused deviation D120

Browse Source
This commit is contained in:
Vito Sansevero
2026-10-22 23:07:31 -07:00
parent 807cb32f58
commit 23887553bf
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
TESTING.md
+2 -2
View File
@@ -1643,7 +1643,7 @@ pending count (`GET /prompt_manager/review/items?limit=1`, its `total`).
Open and Tag follow it. When an unanswered decision's item leaves the queue in a
re-read, the decision was recorded: the page finishes as a recorded decision does (its
toast, back to Images), not with "decided elsewhere".
- **D-NEW-F2** (placeholder number; the concept has no live-update state): while the
- **D120** (the concept has no live-update state): while the
change stream is down, the heading carries the quiet status line "Live updates are
paused: changes made elsewhere appear once the connection returns." (`p.small
.review-live`, `role="status"`); the stream's next `ready` hides it.
@@ -1679,7 +1679,7 @@ first change at once and collapses the notices of the next 0.4 s into one traili
`change` (`COALESCE_SECONDS`), so a busy scan costs an open page one re-read per 0.4 s at
most. Shutdown (`on_shutdown`) ends every stream and answers a later one 503. A
reconnect the browser gives up on (a 503, or a proxy's error while ComfyUI restarts) is
opened again by the page after 3 s, doubling to 30 s, with D-NEW-F2's line shown while
opened again by the page after 3 s, doubling to 30 s, with D120's line shown while
the stream is down; its `ready` re-syncs the queue. The stream lives only while the tab is
visible: a hidden tab closes it and a visible one opens it again, and that `ready` reads
only when the queue changed meanwhile. A duplicate recording and a refused decision change
web/js/workspace/review.mjs
+3 -3
View File
@@ -18,7 +18,7 @@
* - The stream lives only while the tab is visible: a hidden tab closes it and a visible one opens it again, so
* background tabs hold no connection (I4); the reopened stream's `ready` reads only when the queue changed meanwhile.
* A stream the browser gave up on (a 503 or a proxy error on its reconnect) is opened again after 3 s, doubling to
* 30 s; while the stream is down the page says so in a quiet status line (D-NEW-F2, I3).
* 30 s; while the stream is down the page says so in a quiet status line (D120, I3).
* - A re-read refreshes each card whose media, target or availability changed (M6). Cards show the Images listing's
* thumbnail when the server knows one (M10).
* - The SAVED VIEWS row's count follows the total the page shows (`onTotal`), so a change costs no count read.
@@ -45,7 +45,7 @@ export const REVIEW_EVENTS_URL = '/prompt_manager/review/events';
// I3: reopening a stream the browser closed for good waits this long, doubling up to the maximum.
export const REOPEN_FIRST_MS = 3000;
export const REOPEN_MAX_MS = 30000;
// D-NEW-F2: the page's line while the change stream is down (the concept has no such state).
// D120: the page's line while the change stream is down (the concept has no such state).
export const NOT_LIVE = 'Live updates are paused: changes made elsewhere appear once the connection returns.';
const openEvents = url => new EventSource(window.ApiClient.resolveUrl(url));
@@ -136,7 +136,7 @@ export function mountReview(main, { api, scope, onDecision = () => {}, onTotal,
panel.append(panelTitle, filename, tagRow, contextField, warning, blocks, actions);
layout.append(grid, panel);
const live = el('p', NOT_LIVE, 'small review-live'); // D-NEW-F2: the change stream is down
const live = el('p', NOT_LIVE, 'small review-live'); // D120: the change stream is down
live.setAttribute('role', 'status');
live.hidden = true;
heading.description.after(live);