nodes/EricRorich-ComfyUI-face-shaper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
141 Commits 33 Branches 0 Tags
copilot/refactor-custom-node-ui-ordering
Commit Graph
141 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
copilot-swe-agent[bot]andEricRorich d19e68e041 Clean up debug_geometry remnants 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 18:36:41 +00:00
copilot-swe-agent[bot]andEricRorich 591f63a6e4 Refactor UI ordering and parameter naming 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 18:32:23 +00:00
copilot-swe-agent[bot] 4745dc3798 Initial plan 2026-01-09 18:21:53 +00:00
Rorich 68180731d5 Merge pull request #26 from EricRorich/copilot/sync-comfyui-face-shaper-svg 
Sync eye geometry with SVG, add independent eye rotation, remove chin
 2026-01-09 18:14:11 +01:00
copilot-swe-agent[bot]andEricRorich b11c4ccd17 Address code review feedback: clarify backward compatibility and parameter count 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 17:08:48 +00:00
copilot-swe-agent[bot]andEricRorich ba7da534fc Update README documentation for eye rotation and chin removal 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 17:06:16 +00:00
copilot-swe-agent[bot]andEricRorich 7772cb61ef Implement eye geometry update, eye rotation controls, and chin removal 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 17:03:28 +00:00
copilot-swe-agent[bot] 12eba102f0 Initial plan 2026-01-09 16:51:56 +00:00
Rorich e6708c13c0 Add files via upload 2026-01-09 17:47:54 +01:00
Rorich 0608b6abcc Merge pull request #25 from EricRorich/copilot/remove-ear-geometry-controls 
Remove ear geometry and controls from Face Shaper node
 2026-01-09 15:01:37 +01:00
copilot-swe-agent[bot]andEricRorich 1e80824a85 Final documentation improvements for validation scripts 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 13:55:09 +00:00
copilot-swe-agent[bot] 0e4d6f10bb Fix parameter count comment in validation script 2026-01-09 13:53:50 +00:00
copilot-swe-agent[bot]andEricRorich f8fa2ae5e8 Add validation scripts and summary documentation for ear removal 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 13:52:58 +00:00
copilot-swe-agent[bot]andEricRorich 1bcd246a63 Remove all ear geometry and controls from Face Shaper node 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 13:47:53 +00:00
copilot-swe-agent[bot] 77cdcbfbaf Initial plan 2026-01-09 13:40:29 +00:00
Rorich 667ada5655 Merge pull request #24 from EricRorich/copilot/fix-ear-rendering-and-reset-functionality 
Implement robust SVG path parsing for ears and fix comprehensive reset functionality
 2026-01-09 14:09:05 +01:00
copilot-swe-agent[bot]andEricRorich 09ae6ea0c3 Add comprehensive solution documentation - implementation complete 
- Part 1: Robust SVG path parsing with M/m, L/l, H/h, V/v, Z/z, C/c, Q/q support
- Part 2: Comprehensive reset functionality with all 58 parameters
- All 8 validation tests passing
- Full backward compatibility maintained
- Ready for production use

Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 13:04:11 +00:00
copilot-swe-agent[bot]andEricRorich d59270b3a8 Add comprehensive validation tests - all 8 tests passing 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 13:02:42 +00:00
copilot-swe-agent[bot]andEricRorich 5bcbde3397 Fix ear coordinates to match parsed SVG path184 exactly 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 13:00:33 +00:00
copilot-swe-agent[bot]andEricRorich a4f095e1c3 Implement robust SVG path parsing and update ear rendering with debug support 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 12:58:41 +00:00
copilot-swe-agent[bot] f2523a1396 Initial plan 2026-01-09 12:51:22 +00:00
Rorich 4a9d95959e Merge pull request #23 from EricRorich/copilot/update-ear-nose-geometry 
Update ear and nose geometry from SVG with correct viewBox normalization
 2026-01-09 13:34:46 +01:00
copilot-swe-agent[bot]andEricRorich 5aa372bbaf Complete geometry update - all tests pass, validation successful 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 12:28:28 +00:00
copilot-swe-agent[bot]andEricRorich 67194fa272 Update ear and nose geometry from SVG, fix validation tests 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 12:23:32 +00:00
copilot-swe-agent[bot] 4bb42d68c3 Initial plan 2026-01-09 12:16:32 +00:00
Rorich 89839b24d0 Add files via upload 2026-01-09 13:14:53 +01:00
Rorich 0ea740934d Merge pull request #22 from EricRorich/copilot/debug-geometry-and-fix-ears-nose 
Add debug mode and fix ear/nose geometry from updated SVG
 2026-01-09 13:10:51 +01:00
copilot-swe-agent[bot]andEricRorich a1267addff Add debug_geometry mode and update ears/nose geometry from UPDATED SVG 
- Task 0: Added debug_geometry boolean parameter (default False)
  - Prints point count and normalized bbox for ear_left, ear_right, nose
  - Marks nose tip points with red circles when enabled
- Task A: Updated ear coordinates from UPDATED SVG (path184, path185)
  - ear_left: 6 points, bbox minx=0.109375, maxx=0.203125 (left side ✓)
  - ear_right: 6 points, bbox minx=0.796875, maxx=0.890625 (right side ✓)
  - ViewBox normalization (270.93331x270.93331)
  - Transform pipeline intact
- Task B: Nose already correct from previous update (path46)
  - 11 points, bbox minx=0.428341, maxx=0.571659 (central ✓)
- Task C: Fixed nose_tip_pos_y with algorithmic selection
  - Sorts by ry descending, then abs(rx-0.5) ascending
  - Selects top 3 points (lowest and most central)
  - Applies nose_tip_pos_y offset only to these 3 points
  - Optional red markers when debug_geometry=True

Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 12:01:24 +00:00
copilot-swe-agent[bot] 1e9eacfe59 Initial plan 2026-01-09 11:51:51 +00:00
Rorich b48e888948 Merge pull request #21 from EricRorich/copilot/update-comfyui-face-shaper-please-work 
Sync ComfyUIFaceShaper with latest SVG: refresh ears, integrate nose tip
 2026-01-09 12:23:15 +01:00
copilot-swe-agent[bot]andEricRorich fb8f2ea01b Add comprehensive implementation summary documentation 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 11:20:18 +00:00
copilot-swe-agent[bot]andEricRorich 56507b0150 Address code review feedback - add coordinate comments and improve validation 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 11:18:03 +00:00
copilot-swe-agent[bot]andEricRorich fa80ebeb57 Add validation script and changes documentation 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 11:15:26 +00:00
copilot-swe-agent[bot]andEricRorich add5e02ddc Update test_implementation.py to match new API (removed nose_tip sizes) 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 11:13:33 +00:00
copilot-swe-agent[bot]andEricRorich 3de6dac93c Update ear geometry, remove obsolete nose_tip, integrate nose tip control 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-09 11:09:05 +00:00
copilot-swe-agent[bot] 8adbb7a635 Initial plan 2026-01-09 11:00:53 +00:00
Rorich 61abfa30e6 Merge pull request #20 from EricRorich/copilot/update-iris-offset-and-distortion 
Bake iris center offsets and add fov_mm lens distortion control
 2026-01-08 12:40:02 +01:00
copilot-swe-agent[bot] 6fdfdaf184 Remove temporary test file 2026-01-08 11:21:48 +00:00
copilot-swe-agent[bot]andEricRorich 30dbb8da78 Final verification complete - all tasks implemented successfully 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-08 11:21:07 +00:00
copilot-swe-agent[bot]andEricRorich 47e616990a Implement iris offset baking and fov_mm distortion control 
- Baked iris position offsets into FEMALE_FACE_IRISES base centers
  - Left iris: added -0.020 offset (from -0.040*0.5 multiplier)
  - Right iris: added +0.020 offset (from +0.040*0.5 multiplier)
  - iris_left_pos_x and iris_right_pos_x defaults remain at 0.0
  - Irises now render at correct SVG positions with default values

- Added fov_mm parameter for radial lens distortion
  - Default: 80.0 (no distortion), min: 16.0 (wide), max: 200.0 (telephoto)
  - Barrel distortion for fov_mm < 80 (negative k1)
  - Pincushion distortion for fov_mm > 80 (positive k1)
  - Applied uniformly after pixel conversion via apply_distortion()

- Updated settings list to include fov_mm (now 59 parameters)
- Updated web extension reset defaults to include fov_mm: 80.0
- Updated test_implementation.py for new parameter
- All tests pass successfully

Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-08 11:16:40 +00:00
copilot-swe-agent[bot] f1960c9a47 Initial plan 2026-01-08 11:06:56 +00:00
Rorich ff20c1e1d0 Merge pull request #19 from EricRorich/copilot/fix-ear-nose-geometry-rendering 
Fix ear_left, ear_right, and nose_tip rendering with correct SVG geometry
 2026-01-08 11:30:50 +01:00
copilot-swe-agent[bot]andEricRorich d13f700d14 Update tests to match corrected geometry (5 points for ears and nose_tip) 
- Updated test_implementation.py to expect 5 points instead of 6/11
- All tests now pass successfully
- Generated visual test images confirming proper rendering

Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-08 10:22:10 +00:00
copilot-swe-agent[bot]andEricRorich b710252784 Fix ear and nose_tip geometry and render order 
- Updated ear_left, ear_right, and nose_tip with correct SVG coordinates
- Extracted geometry from Face_Mask_female.svg layer11 (ears) and layer6 (nose_tip)
- Fixed render order: ears after head_outline and before cheeks, nose_tip after nose and before lips
- Added len>=2 guards for ear and nose_tip drawing
- All geometry now distinct from placeholder eye/nose coordinates

Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-08 10:18:47 +00:00
copilot-swe-agent[bot] eef254cb16 Initial plan 2026-01-08 10:04:19 +00:00
Rorich db56f18d60 Merge pull request #18 from EricRorich/copilot/add-svg-ears-nose-tip 
Add ears and nose tip SVG components with position and scale controls
 2026-01-08 10:57:29 +01:00
copilot-swe-agent[bot]andEricRorich f36ff107c0 Clarify parameter count and fix test comments 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-08 09:54:22 +00:00
copilot-swe-agent[bot]andEricRorich 0f69df4fad Add ears and nose tip geometry and controls to face shaper 
Co-authored-by: EricRorich <86147326+EricRorich@users.noreply.github.com>
 2026-01-08 09:50:26 +00:00
copilot-swe-agent[bot] 87ffd238b9 Initial plan 2026-01-08 09:42:06 +00:00
Rorich 3837c18c4b Add files via upload 2026-01-08 10:41:01 +01:00