nodes/Kosinkadink-ComfyUI-Advanced-ControlNet
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
386 Commits 12 Branches 0 Tags
refactor/v3-node-api
Commit Graph
386 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jedrzej Kosinski 0a0c10b25b Migrate all nodes to the V3 API 2026-07-17 19:06:02 -07:00
Jedrzej Kosinski 4b37dbd421 Merge pull request #254 from Kosinkadink/cleanup/remove-obsolete-frontend 
Remove obsolete frontend extensions
 2026-07-17 18:13:20 -07:00
Jedrzej Kosinski 84cbeab2e6 Remove obsolete frontend extensions 2026-07-17 16:11:14 -07:00
Jedrzej Kosinski d508fe9027 Merge pull request #253 from Kosinkadink/feature/anima-lllite-v2 
Support Anima LLLite v2 models
 2026-07-17 15:58:53 -07:00
Jedrzej KosinskiandAmp f900f14b0b Support Anima LLLite v2 models 
Amp-Thread-ID: https://ampcode.com/threads/T-019f7088-85bf-7703-87c3-f9c0ca5d711d
Co-authored-by: Amp <amp@ampcode.com>
 2026-07-17 15:44:56 -07:00
Jedrzej Kosinski e701735c50 Merge pull request #252 from Kosinkadink/chore/bump-version-1.5.8 
Bump version to 1.5.8
 2026-07-17 06:25:13 -07:00
Jedrzej Kosinski a0563a3fa0 Bump version to 1.5.8 2026-07-17 06:23:44 -07:00
Jedrzej Kosinski ba0795aaaa Merge pull request #249 from Kosinkadink/fix/sparsectrl-svd-dtype 
Fix dtype mismatch for SparseCtrl and SVD-ControlNet models
 2026-06-04 15:30:54 -07:00
Jedrzej KosinskiandAmp 9538b054cd Cast SparseCtrl/SVD control models to unet dtype after loading 
Setting controlnet_config["dtype"] alone is not enough: comfy's lazy/zero-copy
state_dict loading (Windows + aimdo path in disable_weight_init) assigns the
on-disk fp32 tensors directly as parameters and ignores the configured dtype.
With the disable_weight_init ops (no runtime weight casting), the control model
then runs fp32 weights against fp16 activations, raising "mat1 and mat2 must have
the same dtype, but got Half and Float" at the first time_embed Linear.

Explicitly cast the control model to unet_dtype after load_state_dict (mirroring
the motion model load and AnimateDiff-Evolved #573) so the weights always match
the activation dtype at runtime.

Verified end-to-end with v3_sd15_sparsectrl_rgb.ckpt on an fp16 SD1.5 model.

Amp-Thread-ID: https://ampcode.com/threads/T-019e947a-9fd3-76df-a847-5eb68d7f18de
Co-authored-by: Amp <amp@ampcode.com>
 2026-06-04 15:10:48 -07:00
Jedrzej KosinskiandAmp 71b536c47f Fix dtype mismatch for SparseCtrl and SVD-ControlNet models 
load_sparsectrl and load_svdcontrolnet never set controlnet_config["dtype"],
so the control model was built with dtype=None (float32) while the UNet runs
in fp16. This caused "mat1 and mat2 must have the same dtype, but got Half and
Float" at sampling time (notably for .pth/.ckpt SparseCtrl models).

Set controlnet_config["dtype"] = unet_dtype before building the model, matching
the existing ControlNet++ and CtrLoRA loaders and ComfyUI's own controlnet loader.

Fixes #574

Amp-Thread-ID: https://ampcode.com/threads/T-019e947a-9fd3-76df-a847-5eb68d7f18de
Co-authored-by: Amp <amp@ampcode.com>
 2026-06-04 14:26:17 -07:00
Jedrzej Kosinski b03791e456 Merge pull request #246 from Kosinkadink/fix/cast-bias-weight-offloadable 
fix: update cast_bias_weight to use offloadable=True in clean_groupnorm
 2026-03-29 18:39:38 -07:00
Jedrzej KosinskiandAmp fd0acd2b50 fix: update cast_bias_weight to use offloadable=True in clean_groupnorm 
Use ComfyUI's updated 3-return-value cast_bias_weight API with
offloadable=True and call uncast_bias_weight after use for proper
async-offload support.

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d3bef-9580-7798-aec3-7a009a0f62a4
 2026-03-29 18:37:59 -07:00
Jedrzej Kosinski 2bde95a468 Merge pull request #237 from Kosinkadink/develop 
Fixed device mismatch issue for ControlNet++, SparseCtrl, and SVDControlNet
 2025-08-06 13:01:11 -07:00
Jedrzej Kosinski c0b5d7378b version bump 2025-08-06 12:59:40 -07:00
Jedrzej Kosinski 79f8a8aa8b Fixed device mismatch issue for ControlNet++, SparseCtrl, and SVDControlNet 2025-08-06 12:59:25 -07:00
Jedrzej Kosinski f9a12257bd Merge pull request #236 from Kosinkadink/develop 
Fix other ControlNet types after recent ComfyUI controlnet change
 2025-08-05 13:45:35 -07:00
Jedrzej Kosinski 86bfde7eb6 version bump 2025-08-05 13:44:34 -07:00
Jedrzej Kosinski 0da13ac0e2 Updated the remaining context= controlnet code to use comfy.model_management.cast_to_device calls 2025-08-05 13:43:52 -07:00
Jedrzej Kosinski 4211b1bdc2 Merge branch 'main' into develop 2025-08-05 13:33:00 -07:00
Jedrzej Kosinski b1f358cd65 Merge pull request #235 from germanch90/main 
Apply fix for ControlNet conditioning to match changes from ComfyUI lowering VRAM usage
 2025-08-05 13:03:20 -07:00
German Chaverri f980ae7c7b Apply fix for ControlNet conditioning to match changes from ComfyUI 140ffc7fdc53e810030f060e421c1f528c2d2ab9 2025-08-05 11:00:08 -06:00
Jedrzej Kosinski da254b700d Merge pull request #223 from Kosinkadink/multigpu 
Get context-related info from ad_params in transformer_options
 2025-03-04 20:40:13 -06:00
Jedrzej Kosinski 5d7012e8ac version bump 2025-03-04 20:38:38 -06:00
Jedrzej Kosinski afc96718fb Merge branch 'main' into multigpu 2025-01-31 04:00:44 -06:00
Jedrzej Kosinski 3270044067 Merge branch 'main' into develop 2025-01-31 04:00:29 -06:00
Jedrzej Kosinski b66cd70c98 Merge pull request #219 from Kosinkadink/floatlongfix 
Fix RuntimeError: Float did not match Long when ComfyUI is outdated
 2025-01-31 03:59:55 -06:00
Jedrzej Kosinski 60a937144e Fixed BIGMAX_TENSOR to not be so big that it becomes an int64 instead of a float32, version bump 2025-01-31 03:59:05 -06:00
Jedrzej Kosinski 9cf9d310ba version bump 2025-01-31 03:55:17 -06:00
Jedrzej Kosinski 6edd91bddc Merge branch 'develop' of https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet into develop 2025-01-31 03:54:51 -06:00
Jedrzej Kosinski ab5dac03c6 Fixed BIGMAX_TENSOR to not be so big that it becomes an int64 instead of a float32 2025-01-31 03:54:39 -06:00
Jedrzej Kosinski b6f420c21e Merge branch 'main' into develop 2025-01-29 09:17:17 -06:00
Jedrzej Kosinski 7fbcf03843 Values related to ad_params now obtained through transformer_options in get_control_inject, no longer requiring ADE to manually set them 2025-01-29 09:16:39 -06:00
Jedrzej Kosinski 23563ece9b Merge pull request #218 from ComfyNodePRs/update-publish-yaml 
Update Github Action for Publishing to Comfy Registry
 2025-01-28 00:17:44 -06:00
snomiao 3a4d998002 chore(publish): update GitHub Actions workflow for node publishing 
- Add permissions for issue writing
- Update action version to v1 for publish-node-action
- Add condition to run job only for 'Kosinkadink' repository owner
 2025-01-20 21:27:13 +00:00
Jedrzej Kosinski 534e7949c8 Merge PR #217 from Kosinkadink/develop - version bump after LynnHo's PR merged 
version bump
 2025-01-11 00:20:47 -06:00
Jedrzej Kosinski 3d5600a41a version bump 2025-01-11 00:19:53 -06:00
Jedrzej Kosinski 91aea98007 Merge PR #216 from LynnHo/main - fix CtrLoRA latents preprocessing 
Fix CtrLoRA preprocessor
 2025-01-11 00:17:35 -06:00
LynnHo 008538346c Fix CtrLoRA preprocessor 2025-01-09 22:13:28 +08:00
Jedrzej Kosinski f7a42fe6dc Merge pull request #215 from Kosinkadink/develop 
Fixed backwards compatibility for new KF scheduling behavior, changes…
 2025-01-05 15:38:32 -06:00
Jedrzej Kosinski ab6526fa35 Fixed backwards compatibility for new KF scheduling behavior, changes "sigmas" to "sample_sigmas" to match incoming ComfyUI PR 2025-01-05 15:32:51 -06:00
Jedrzej Kosinski c4d9455052 Merge PR #214 from Kosinkadink/develop 
TimestepKeyframe fix
 2025-01-04 00:52:10 -06:00
Jedrzej Kosinski 52b2751025 Increment ACN DinkLink version due to need for transformer_options in prepare_current_timestep function 2025-01-04 00:36:21 -06:00
Jedrzej Kosinski b572c402a8 version bump 2024-12-30 17:01:54 -06:00
Jedrzej Kosinski b3b9a9d655 Merge branch 'main' into develop 2024-12-30 17:00:37 -06:00
Jedrzej Kosinski b4d2608cf4 Merge branch 'develop' of https://github.com/Kosinkadink/ComfyUI-Advanced-ControlNet into develop 2024-12-30 17:00:02 -06:00
Jedrzej Kosinski 787c841b6b Make TimestepKeyframes work consistently across separated sampling nodes/code 2024-12-30 16:59:53 -06:00
Jedrzej Kosinski 1d671d901b Merge PR #213 from Kosinkadink/develop 
Fix Load CtrLoRA Model node category + readme features
 2024-12-28 14:48:03 -06:00
Jedrzej Kosinski 8d230c98d2 Update README.md 2024-12-28 14:46:54 -06:00
Jedrzej Kosinski 840b3f9423 Add link to CtrLoRA repo on top of control_ctrlora.py file 2024-12-28 14:45:03 -06:00
Jedrzej Kosinski 393bca416d Fix Load CtrLoRA Model node being in the wrong category 2024-12-28 14:43:23 -06:00