Commit Graph
101 Commits
Author SHA1 Message Date
Jedrzej Kosinski 3111d481ff Merge pull request #55 from Kosinkadink/develop
Implemented Motion LoRAs with AnimateDiff LoRA Loader node + extra AnimateDiff Loader input
2023-09-25 10:47:08 -05:00
Jedrzej Kosinski 48d5044e78 Decreased minimum step of AnimateDiff LoRA Loader to 0.001 for finer grain of values 2023-09-25 10:42:31 -05:00
Jedrzej Kosinski 4243d40a88 Added Motion LoRA support, updated Loader node to support AnimateDiff LoRA Loader input 2023-09-25 10:28:38 -05:00
Jedrzej Kosinski 53159c3067 Merge pull request #54 from Kosinkadink/Kosinkadink-readme-patch1
Updated workflows on readme to be up to date with current nodes + best practices
2023-09-25 04:43:16 -05:00
Jedrzej Kosinski 03778a8ab9 Update README.md - finished updating existing workflows + bonus context workflows 2023-09-25 04:42:28 -05:00
Jedrzej Kosinski 1c5ff56b45 Update README.md - updating workflows to use updated nodes
Both new Loader, and  + comfyui_controlnet_aux nodes will be included in workflows instead of old ones.
2023-09-25 02:41:25 -05:00
Jedrzej Kosinski 9c16958593 Merge pull request #47 from Kosinkadink/bughunt-motionmodelpath
Use ComfyUI's built-in folder path management
2023-09-23 02:26:59 -05:00
Jedrzej Kosinski c902fd5827 changed folder handling to use ComfyUI's built-in framework 2023-09-23 01:58:40 -05:00
Jedrzej Kosinski d43768a3fd Merge pull request #43 from Kosinkadink/develop
Forgot to push this commit before merging
2023-09-22 18:14:50 -05:00
Jedrzej Kosinski a0448f994c Merge branch 'develop' of https://github.com/Kosinkadink/ComfyUI-AnimateDiff into develop 2023-09-22 18:13:50 -05:00
Jedrzej Kosinski 3dc07ea5e5 Added cloning to InjectionParams to fix resetting context info on parent model 2023-09-22 18:13:41 -05:00
Jedrzej Kosinski e50631b92a Merge pull request #42 from Kosinkadink/develop
Develop merge - major refactoring + bug fixes + workflow performance improvements
2023-09-22 17:54:51 -05:00
Jedrzej Kosinski 98f4c80a7b Update README.md - added message that samples after first two have not been reworked to use new node 2023-09-22 17:52:27 -05:00
Jedrzej Kosinski 9ca43b2db0 Update README.md - updated first two workflows, will finish the rest soon 2023-09-22 17:50:48 -05:00
Jedrzej Kosinski 8d58e992c9 Update README.md - beginning of revamp 2023-09-22 17:13:01 -05:00
Jedrzej Kosinski 97ea3561bd Updated AnimateDiff Loader to not require any latents passed in or out - latent count will be determined at sampling time 2023-09-22 16:38:57 -05:00
Jedrzej Kosinski 558d3782ac Changed max values in UniformContextOptions node, added comments to remind myself to review values if new motion modules are released 2023-09-22 14:59:36 -05:00
Jedrzej Kosinski 585831f8d1 Comment out unsued config code, remove log statements in eject code, fixed invalid model message 2023-09-22 14:55:28 -05:00
Jedrzej Kosinski ae532ec4bb Fixed unet attr being set/deleted from ModelPatcher instead of underlying unet, causing modules to never be ejected and ejected on top of one another on subsequent runs 2023-09-22 13:36:40 -05:00
Jedrzej Kosinski 4511db0f1c Removed 'uniform v2' scheduler from being able to be selected - has bugs that cause it not to work for certain combos of video lengths and context lengths and other settings 2023-09-22 13:11:57 -05:00
Jedrzej Kosinski 5e78d05235 Added new Loader node that takes in ContextOptions (for future-proofing workflows), Beta Schedule dropdown in Loader works now, fixed inconsistent unet injection causing bugs, returned unlimited_area_hack to old nodes to keep old workflows from breaking, marked old Loader node as deprecated (still work, though, just won't be supported with new features going forward) 2023-09-22 12:51:08 -05:00
Jedrzej Kosinski b4ad91d080 Massive consolidation refactor that fixes Loaders and Unloaders unnecessarily running (or not running), only remaining issue to solve is getting beta_schedule to be applied in injected loading code without errors on subsequent runs 2023-09-22 02:09:49 -05:00
Jedrzej Kosinski e80fde2f84 Progress towards adding a config file to choose if xformers should be used for VersatileAttention, beginning of rework to allow KSamplers to not have to redo all their work if settings did not change, beginning of work to support choosing beta schedule in AD Loaders instead of Checkpoint loader (still a useful node though) 2023-09-20 04:59:34 -05:00
Jedrzej Kosinski 86e7731aa7 Merge pull request #28 from AustinMroz/main
Possible fixes to uniform context window generator - available as "uniform v2" context scheduler
2023-09-19 16:40:06 -05:00
Austin Mroz 04ada0a898 Actually add uniform_v2 method lookup 2023-09-19 12:01:52 -05:00
Austin Mroz 26fd2aa977 Move potential fixes to a new uniform v2 sampler
Names can be changed later, but this still allows for easier testing of
what differences the proposed changes make.

It also provides an excuse to fix a grammatically incorrect comment
2023-09-19 01:38:47 -05:00
Austin Mroz 727f80bd09 Possible fixes to uniform context window generator
Prevent duplicate frames on highest context_stride
Modify closed_loop to cause a window break instead of modularly wrapping
2023-09-19 01:07:45 -05:00
Jedrzej Kosinski a88dbbc79d Merge pull request #27 from AustinMroz/main
ffmpeg: additional video formats and config system
2023-09-18 16:17:56 -05:00
Austin Mroz 582756ee75 Add additional video formats and config system
Allows for ffmpeg output settings to be set from a series of json config
files stored in video_formats. This allows for higher quality
output files with newer codecs (like av1), while still ensuring
compatibility with older ffmpeg versions

In addition to these changes, the logging of ffmpeg is better handled.
Error messages from ffmpeg itself are printed and logging from encoders
that was improperly filtered have been individually addressed.

While h265 has been included, most browsers will be unable to display
the resulting video.
2023-09-18 15:52:52 -05:00
Jedrzej Kosinski a494c5c3da Merge pull request #22 from kijai/main
Gif preview in AnimateDiff Combine -node, alongside other video formats
2023-09-18 14:46:54 -05:00
Jedrzej Kosinski 32f26bcf0a Merge pull request #26 from Kosinkadink/develop
Merging sliding context window functionality from develop (finally)
2023-09-18 14:38:43 -05:00
Jedrzej Kosinski f168a19eaa Update README.md - gifs too big, so gonna merge this to main and then get the other PR in 2023-09-18 14:34:33 -05:00
Jedrzej Kosinski e489feaf12 Update README.md - some initial changes, in progress 2023-09-18 14:07:55 -05:00
Jedrzej Kosinski ba84e40fec Injected error checking code around common ksampler functions so that users get a useful error message concerning xformers bug and how to fix it 2023-09-18 13:14:34 -05:00
Jedrzej Kosinski 6789e35256 Refactored context_schedule code to make it easier to add more schedulers later, moved manual testing code out and added manual_testing.py to .gitignore 2023-09-18 12:27:28 -05:00
Jedrzej Kosinski 571794e1e0 ControlNet support added for sliding contexts 2023-09-18 11:19:04 -05:00
kijai ff5fd3a9e4 Added changes made on top of this on the original main repo
This fixes the node scaling and combines everything to one node with format options.
2023-09-18 13:55:14 +03:00
kijai bbad90277d Merge remote-tracking branch 'upstream/develop' 2023-09-18 12:56:15 +03:00
Jedrzej Kosinski e60f1103eb Fixed context_stride minimum value (should be 1, not 0) 2023-09-18 00:47:48 -05:00
Jedrzej Kosinski 5d4d1a73e6 Changed AnimateDiffLoaderAdvanced defaults to sane values, node should behave like AnimateDiffLoader when sliding context criteria not met 2023-09-18 00:46:03 -05:00
Jedrzej Kosinski c03825c67e Crediting ashen for inpiration in sliding_context_sampling, added Empty Latent Image (Big Batch) node to go over 64 frame limit 2023-09-17 23:59:14 -05:00
Jedrzej Kosinski 1bf6cdfb2c Added SD1.5-based model check to improve err msg 2023-09-17 22:55:41 -05:00
Jedrzej Kosinski d552a26b4f Removed unused download code from OG repo 2023-09-17 22:31:30 -05:00
Jedrzej Kosinski fd0e025ab6 Initial sliding context window code - moved some injection code around, removed legacy injection code, implemented booleans properly 2023-09-17 22:06:14 -05:00
kijai 04e6806e41 Update nodes.py
Smoother pingpong loop
2023-09-16 21:07:52 +03:00
kijai fc6c05323d Add webm node preview
added video preview to the node, with pingpong loop option
2023-09-16 19:46:49 +03:00
kijai 17b98d73b7 Merge branch 'pr/23' 2023-09-16 18:20:47 +03:00
Austin Mroz e2109258d5 Add AnimateDiffCombineVideo node 2023-09-15 15:03:48 -05:00
kijai 5a58d819c7 Update gif_preview.js
Fix node/widget removal
2023-09-15 21:40:15 +03:00
kijai e21cb5987b First working gif preview
javascript code is pretty much directly from mtb node's "save gif" widget extension code
2023-09-15 21:19:05 +03:00