Sync with upstream

This commit is contained in:
blepping
2024-09-01 18:44:31 -06:00
2 changed files with 24 additions and 16 deletions
+20 -12
View File
@@ -10,7 +10,7 @@ import comfy.model_management
import comfy.model_patcher
import folder_paths
from .ops import GGMLTensor, GGMLOps, move_patch_to_cuda
from .ops import GGMLTensor, GGMLOps, move_patch_to_device
from .tools.convert import detect_arch
# Add a custom keys for files ending in .gguf
@@ -129,9 +129,6 @@ class GGUFModelPatcher(comfy.model_patcher.ModelPatcher):
if key not in self.patches:
return
weight = comfy.utils.get_attr(self.model, key)
inplace_update = self.weight_inplace_update or inplace_update
if key not in self.backup:
self.backup[key] = collections.namedtuple('Dimension', ['weight', 'inplace_update'])(weight.to(device=self.offload_device, copy=inplace_update), inplace_update)
try:
from comfy.lora import calculate_weight
@@ -141,16 +138,16 @@ class GGUFModelPatcher(comfy.model_patcher.ModelPatcher):
patches = self.patches[key]
qtype = getattr(weight, "tensor_type", None)
if qtype not in (None, gguf.GGMLQuantizationType.F32, gguf.GGMLQuantizationType.F16):
if device_to is not None:
out_weight = weight.to(device_to, copy=True)
else:
out_weight = weight.to(weight.device, copy=True) # make sure patches are copied
if self.patch_on_device:
patches = move_patch_to_cuda(patches, self.load_device)
out_weight = weight.to(device_to)
patches = move_patch_to_device(patches, self.load_device if self.patch_on_device else self.offload_device)
out_weight.patches.append((calculate_weight, patches, key))
else:
inplace_update = self.weight_inplace_update or inplace_update
if key not in self.backup:
self.backup[key] = collections.namedtuple('Dimension', ['weight', 'inplace_update'])(
weight.to(device=self.offload_device, copy=inplace_update), inplace_update
)
if device_to is not None:
temp_weight = comfy.model_management.cast_to_device(weight, device_to, torch.float32, copy=True)
else:
@@ -164,6 +161,17 @@ class GGUFModelPatcher(comfy.model_patcher.ModelPatcher):
else:
comfy.utils.set_attr_param(self.model, key, out_weight)
def unpatch_model(self, device_to=None, unpatch_weights=True):
if unpatch_weights:
for p in self.model.parameters():
qtype = getattr(p, "tensor_type", None)
patches = getattr(p, "patches", [])
if qtype in (None, gguf.GGMLQuantizationType.F32, gguf.GGMLQuantizationType.F16):
continue
if len(patches) > 0:
p.patches = []
return super().unpatch_model(device_to=None, unpatch_weights=unpatch_weights)
def load(self, *args, force_patch_weights=False, **kwargs):
# always call `patch_weight_to_device` even for lowvram
return super().load(*args, force_patch_weights=True, **kwargs)
+4 -4
View File
@@ -111,7 +111,7 @@ class GGMLLayer(torch.nn.Module):
patch_list = []
device = tensor.device
for function, patches, key in getattr(tensor, "patches", []):
patch_list += move_patch_to_cuda(patches, device)
patch_list += move_patch_to_device(patches, device)
# dequantize tensor while patches load
weight = dequantize_tensor(tensor, dtype, self.dequant_dtype)
@@ -189,12 +189,12 @@ class GGMLOps(comfy.ops.manual_cast):
weight, bias = self.cast_bias_weight(input)
return torch.nn.functional.group_norm(input, self.num_groups, weight, bias, self.eps)
def move_patch_to_cuda(item, device):
def move_patch_to_device(item, device):
if isinstance(item, torch.Tensor):
return item.to(device, non_blocking=True)
elif isinstance(item, tuple):
return tuple(move_patch_to_cuda(x, device) for x in item)
return tuple(move_patch_to_device(x, device) for x in item)
elif isinstance(item, list):
return [move_patch_to_cuda(x, device) for x in item]
return [move_patch_to_device(x, device) for x in item]
else:
return item