Make the icon background transparent
The mark shipped as an opaque 400x400 square, which reads as a hard tile on the Manager's pack card. The frontend's PackBanner draws the icon twice into a 7:3 box: once bg-cover plus blur(10px) at opacity-30 as a backdrop, once object-contain on top. bg-cover crops to the centre and zooms about 2.3x, so it samples mostly glow and lifts the surround to ~47, while the contained copy still shows the icon's own near-black corners at ~17. Measured off a card screenshot, that is a 26-34 level step at the tile edge; the same measurement on rgthree-comfy, whose icon is a transparent SVG, is 2-3 levels. Alpha now comes from luminance, which is the right derivation for artwork that is additive glow on near-black, and it removes the edge outright. Checked against a local reimplementation of PackBanner that reproduces the screenshot's tile corners exactly. The trade is that the pale mark washes out on ComfyUI's light theme. Taken deliberately: the dark theme is the common case, and it is what the comparable packs do. A dark backing disc was the alternative and reads as a grey blob on light instead. No version bump. The registry stores the icon URL rather than the bytes and the Manager hotlinks it, so replacing the file on main restyles every card; only a changed URL would need a republish. Also worth recording: Banner is deliberately still unset, because PackBanner resolves banner_url || icon, so a banner replaces the mark instead of sitting behind it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015p88qHFcfungDkCbG1n7z2
This commit is contained in:
co-authored by
Claude Opus 5
parent
998bf88ce1
commit
ebc7d3e061
@@ -125,18 +125,33 @@ existing version fails with `400 The node version already exists`.
|
||||
produces the exact archive that would be uploaded.
|
||||
|
||||
`assets/icon.png` is the registry icon, pointed at by `[tool.comfy] Icon` as a
|
||||
raw GitHub URL on `main`. The registry stores the *URL*, not the bytes, so the
|
||||
asset has to be on `main` before the version bump that references it — and
|
||||
because `icon` is node-level metadata written as a side effect of publishing a
|
||||
version, a changed icon only reaches the registry on the next bump. It is the
|
||||
shared `dreevelle` mark, regenerated from the brand original at the registry's
|
||||
400×400 square maximum:
|
||||
raw GitHub URL on `main`. The registry stores the *URL*, not the bytes, and the
|
||||
Manager hotlinks it, so **replacing this file on `main` restyles every card with
|
||||
no republish**. Only changing the URL needs a version bump, because `icon` is
|
||||
node-level metadata written as a side effect of publishing a version.
|
||||
|
||||
The background is **transparent on purpose**. The frontend's `PackBanner` draws
|
||||
the icon twice into a 7:3 box — once as a backdrop, `bg-cover` plus `blur(10px)`
|
||||
at `opacity-30`, and once `object-contain` on top. An opaque icon therefore shows
|
||||
as a hard rectangle: `bg-cover` crops to the centre and zooms ~2.3x, so it samples
|
||||
mostly glow and lifts the surround to ~47, while the contained copy still shows
|
||||
the icon's own near-black corners at ~17. Deriving alpha from luminance removes
|
||||
the edge completely, and it is the right derivation because the artwork is
|
||||
additive glow on near-black. The cost, accepted deliberately, is that the pale
|
||||
mark washes out on ComfyUI's light theme.
|
||||
|
||||
Regenerate from the brand original, capped at the registry's 400x400 square
|
||||
maximum. Downscale in linear light; the naive sRGB-space resize dulls the ring
|
||||
stroke and blurs the bar separations inside the D:
|
||||
|
||||
```bash
|
||||
magick ~/Projects/alora/dev/assets/brand/dreevelle_pfp.png \
|
||||
-colorspace RGB -filter Lanczos -resize 400x400 -colorspace sRGB -strip \
|
||||
assets/icon.png
|
||||
-colorspace RGB -filter Lanczos -resize 400x400 -colorspace sRGB \
|
||||
\( +clone -grayscale Rec601Luma -level 7.45%,100% \) \
|
||||
-alpha off -compose CopyOpacity -composite \
|
||||
-background none -alpha Background -strip assets/icon.png
|
||||
oxipng -o max --strip safe assets/icon.png
|
||||
```
|
||||
|
||||
Downscale in linear light as above; the naive sRGB-space resize dulls the glow.
|
||||
Do not set `[tool.comfy] Banner`. `PackBanner` resolves `banner_url || icon`, so
|
||||
a banner *replaces* the mark rather than sitting behind it.
|
||||
|
||||
Binary file not shown.
|
Before Width: | Height: | Size: 79 KiB After Width: | Height: | Size: 101 KiB |
Reference in New Issue
Block a user