nodes/ethanfel-ComfyUI-LoRA-Optimizer
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(detect): stop krea2 from hijacking LTX-2 (to_gate_logits false-match)

Browse Source 
LTX-2 (LTXV 2.3) LoRAs have dual video/audio + cross-modal attention with
'*_attn.to_gate_logits'. The krea2 gate detector's '(?=[._])' lookahead let
the '..._attn.to_gate' substring match inside 'to_gate_logits', so LTX-2 LoRAs
were detected as krea2, ran through krea2 normalization (which renames
transformer_blocks->blocks), and then every key failed to map to the model
(1632 skipped, nothing merged). Require a '.' after the gate/proj leaf — always
the LoRA suffix in real krea2 keys — so LTX-2 falls through to the existing ltx
detection (transformer_blocks + attn1/attn2) and its pass-through normalizer.

No version bump (detection-only fix; correctly-detected arches unaffected).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Ethanfel
2026-06-27 19:11:39 +02:00
co-authored by Claude Opus 4.8
parent 4a474c80aa
commit 3bb407efb0
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lora_optimizer.py
+5 -1
View File
@@ -1069,7 +1069,11 @@ class _LoRAMergeBase:
# diffusion_model.blocks.N.attn.wq (Comfy-Org native)
# diffusion_model.transformer_blocks.N.attn.to_gate (krea_2 trainer)
# transformer.transformer_blocks.N.attn.to_gate + text_fusion (diffusers)
if any(re.search(r'attn[._](?:to_gate|gate|w[qkvo])(?=[._])', k) for k in keys):
# The gate/proj is always a leaf module followed by the LoRA suffix '.'
# (.lora_down/.lora_A/.lokr_w1/.alpha). Require the '.' so this does NOT
# false-match LTX-2's '*_attn.to_gate_logits' (where '_logits' follows) —
# that hijacked LTX-2 LoRAs as krea2 and broke their merge.
if any(re.search(r'attn[._](?:to_gate|gate|w[qkvo])(?=\.)', k) for k in keys):
return 'krea2'
# Z-Image Turbo (Lumina2): layers.N with attention patterns
tests/test_lora_optimizer.py
+16
View File
@@ -4844,6 +4844,22 @@ class Krea2DetectionTests(unittest.TestCase):
self.assertEqual(self.det(flux), "flux")
self.assertEqual(self.det(qwen), "qwen_image")
def test_ltx2_gate_logits_not_stolen_by_krea2(self):
# Regression: LTX-2 (LTXV 2.3) has dual video/audio + cross-modal attention
# with '*_attn.to_gate_logits'. The substring '..._attn.to_gate' must NOT
# trip krea2's gate detection (krea2's gate is a leaf followed by '.', LTX-2's
# is 'to_gate_logits' with '_' after). These LTX LoRAs were mis-detected as
# krea2 -> wrong normalization (transformer_blocks->blocks) -> nothing merged.
s = _sd([
"diffusion_model.transformer_blocks.0.attn1.to_q.lora_A.weight",
"diffusion_model.transformer_blocks.0.attn1.to_gate_logits.lora_A.weight",
"diffusion_model.transformer_blocks.0.attn2.to_k.lora_A.weight",
"diffusion_model.transformer_blocks.0.audio_to_video_attn.to_gate_logits.lora_A.weight",
"diffusion_model.transformer_blocks.0.video_to_audio_attn.to_v.lora_A.weight",
])
self.assertNotEqual(self.det(s), "krea2")
self.assertEqual(self.det(s), "ltx")
class Krea2NormalizationTests(unittest.TestCase):
"""Both Krea 2 trainer forms normalize to the model-native diffusion_model.* keys.