SolitaryThinker
db866dfb04
Sweep all 296 v2 modules: simplify verbose docstrings/comments and remove 376 dangling "(design_vN §X)" citations to the now-deleted design docs (v2/README.md is the source of truth). Comment/docstring-only — AST-verified code-identical; the CPU suite holds at 237 passed / 5 pre-existing. Also applies yapf + ruff --fix auto-fixes (import ordering, forward-ref annotation de-quoting under `from __future__ import annotations`; behavior- neutral, suite-confirmed) and adds the legitimate domain terms mot/clen/te to the codespell ignore-list. Remaining ruff (24) + mypy (68 no-untyped-call) findings are pre-existing v2 debt, untouched here.
60 lines
2.2 KiB
Python
60 lines
2.2 KiB
Python
"""Pre-flight parallelism validation.
|
|
|
|
Validate at load or fail, never halfway. Ownership conflicts are build errors, and
|
|
applicability conditions travel with axes (e.g. ``pp_patch`` is invalid for causal/AR).
|
|
All checks are CPU-testable on a fake mesh.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
from v2._enums import LoopKind
|
|
from v2.parallel.plan import AXIS_NAMES, ParallelPlan
|
|
|
|
|
|
class ParallelValidationError(ValueError):
|
|
pass
|
|
|
|
|
|
# loop kinds whose causality is broken by PipeFusion displaced-patch pipelining
|
|
_CAUSAL_KINDS = {LoopKind.CHUNK_ROLLOUT, LoopKind.AR_DECODE}
|
|
|
|
|
|
def validate_plan(plan: ParallelPlan,
|
|
card=None,
|
|
*,
|
|
world_size: int | None = None,
|
|
cfg_policy_batched: bool = False) -> ParallelPlan:
|
|
"""Validate a plan, optionally against a card. Returns the plan or raises.
|
|
|
|
Checks:
|
|
1. axis names are known; degrees >= 1
|
|
2. cfgp <= 2
|
|
3. product of degrees matches world_size (when given)
|
|
4. pp_patch invalid for any causal/AR loop on the card
|
|
5. ownership conflict: cfgp>1 AND a batched CFGPolicy is rejected
|
|
"""
|
|
errs: list[str] = []
|
|
|
|
for name, deg in plan.axes.items():
|
|
if name not in AXIS_NAMES:
|
|
errs.append(f"unknown parallel axis {name!r} (known: {AXIS_NAMES})")
|
|
if int(deg) < 1:
|
|
errs.append(f"axis {name!r} has degree {deg} < 1")
|
|
|
|
if plan.degree("cfgp") > 2:
|
|
errs.append(f"cfgp degree {plan.degree('cfgp')} > 2 (CFG has at most 2 branches)")
|
|
|
|
if world_size is not None and plan.world_size() != world_size:
|
|
errs.append(f"product of degrees {plan.world_size()} != world_size {world_size}")
|
|
|
|
if plan.degree("cfgp") > 1 and cfg_policy_batched:
|
|
errs.append("ownership conflict: a request owns a BatchedCFG policy OR a cfgp group, never both")
|
|
|
|
if card is not None and plan.degree("pp_patch") > 1:
|
|
causal = [lid for lid, lp in card.loops.items() if lp.kind in _CAUSAL_KINDS]
|
|
if causal:
|
|
errs.append(f"pp_patch is invalid for causal/AR loops {causal} (stale KV breaks causality, §8)")
|
|
|
|
if errs:
|
|
raise ParallelValidationError("ParallelPlan failed validation:\n - " + "\n - ".join(errs))
|
|
return plan
|