Make preview video save by default
This commit is contained in:
@@ -88,8 +88,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -137,8 +137,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -208,8 +208,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -88,8 +88,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -396,8 +396,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -165,8 +165,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -131,8 +131,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -170,8 +170,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -128,8 +128,7 @@
|
||||
"Node name for S&R": "Comfyui-Kling-Wrapper Preview Video"
|
||||
},
|
||||
"widgets_values": [
|
||||
"Comfyui-Kling-Wrapper",
|
||||
true
|
||||
"Comfyui-Kling-Wrapper"
|
||||
]
|
||||
}
|
||||
],
|
||||
|
||||
@@ -170,7 +170,7 @@ def preview_video_node(node_id, pos, order, link_id):
|
||||
pos,
|
||||
[430, 820],
|
||||
order,
|
||||
[NODE_PREFIX, True],
|
||||
[NODE_PREFIX],
|
||||
inputs=[input_slot("video_url", "STRING", link_id)],
|
||||
outputs=[output_slot("file_path", "STRING", slot_index=0)],
|
||||
)
|
||||
|
||||
+1
-2
@@ -1523,7 +1523,6 @@ class PreviewVideo:
|
||||
"required": {
|
||||
"video_url": ("STRING", {"forceInput": True}),
|
||||
"filename_prefix": ("STRING", {"default": DEFAULT_FILENAME_PREFIX}),
|
||||
"save_output": ("BOOLEAN", {"default": True}),
|
||||
}
|
||||
}
|
||||
|
||||
@@ -1534,7 +1533,7 @@ class PreviewVideo:
|
||||
RETURN_TYPES = ("STRING",)
|
||||
RETURN_NAMES = ("file_path",)
|
||||
|
||||
def run(self, video_url, filename_prefix, save_output):
|
||||
def run(self, video_url, filename_prefix, save_output=True):
|
||||
if not save_output:
|
||||
return {"ui": {"video_url": [video_url]}, "result": ('',)}
|
||||
|
||||
|
||||
@@ -142,7 +142,6 @@ class BackendConfigTests(unittest.TestCase):
|
||||
result = kling_nodes.PreviewVideo().run(
|
||||
"https://example.com/video.mp4",
|
||||
"Comfyui-Kling-Wrapper",
|
||||
True,
|
||||
)
|
||||
|
||||
self.assertEqual(
|
||||
@@ -154,6 +153,11 @@ class BackendConfigTests(unittest.TestCase):
|
||||
"Comfyui-Kling-Wrapper_00001_.mp4",
|
||||
)
|
||||
|
||||
def test_preview_video_save_output_is_not_user_toggleable(self):
|
||||
required = kling_nodes.PreviewVideo.INPUT_TYPES()["required"]
|
||||
|
||||
self.assertNotIn("save_output", required)
|
||||
|
||||
def test_preview_video_registers_saved_file_as_asset(self):
|
||||
with tempfile.TemporaryDirectory() as tmpdir:
|
||||
tmpdir_path = Path(tmpdir)
|
||||
@@ -169,7 +173,6 @@ class BackendConfigTests(unittest.TestCase):
|
||||
result = kling_nodes.PreviewVideo().run(
|
||||
"https://example.com/video.mp4",
|
||||
"Comfyui-Kling-Wrapper",
|
||||
True,
|
||||
)
|
||||
|
||||
register_mock.assert_called_once_with(result["result"][0])
|
||||
@@ -189,7 +192,6 @@ class BackendConfigTests(unittest.TestCase):
|
||||
result = kling_nodes.PreviewVideo().run(
|
||||
"https://example.com/video.mp4",
|
||||
"Comfyui-Kling-Wrapper",
|
||||
True,
|
||||
)
|
||||
|
||||
self.assertTrue(Path(result["result"][0]).is_file())
|
||||
@@ -199,7 +201,7 @@ class BackendConfigTests(unittest.TestCase):
|
||||
ValueError,
|
||||
"empty video_url",
|
||||
):
|
||||
kling_nodes.PreviewVideo().run("", "Comfyui-Kling-Wrapper", True)
|
||||
kling_nodes.PreviewVideo().run("", "Comfyui-Kling-Wrapper")
|
||||
|
||||
def test_upload_file_to_tmpfiles_retries_transient_ssl_error(self):
|
||||
with tempfile.TemporaryDirectory() as tmpdir:
|
||||
|
||||
Reference in New Issue
Block a user