nodes/olivv-cs-ComfyUI-FunPack
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: split leaves a phantom/duplicated video transition on the first half

Browse Source 
splitScene deep-clones the scene into the second half, then clears the
first half's transition_to_next and transition_frames so the internal
split seam reads as a hard cut (store.js). But it never cleared
video_transition (the NLE video blend). Two consequences:

- videoTransitionState (timeline.js:484) treats ANY non-empty
  video_transition as active and falls back to 16 frames when
  transition_frames is null, so a phantom transition renders on the
  internal A1|A2 seam that should be a clean cut.
- the transition is duplicated: the deep clone kept it on the second
  half (correct) AND it survived on the first half (wrong).
- on export _renderClips emits transition="<type>" with tdur=0 for the
  first half (store.js:3434-3435), a malformed transition to the stitcher.

Clear video_transition on the first half alongside the other two
transition fields. The clone happens before the clear, so the second
half still correctly inherits the original transition.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
digital-garbage
2026-06-28 19:41:07 +03:00
co-authored by Claude Opus 4.8
parent 580279c847
commit 12ca209bef
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
movie_editor/frontend/store.js
+6 -1
View File
@@ -1816,7 +1816,12 @@
second.transition_to_next = s.transition_to_next || "";
second.transition_frames = s.transition_frames || null;
s.gen_unit_id = unitId;
s.frames = cut; s.transition_to_next = ""; s.transition_frames = null;
// The split seam between the two halves is an internal HARD CUT: the original clip's
// outgoing edge now belongs to the second half. Clear ALL transition fields on the first
// half — the prompt transition (transition_to_next), the NLE video blend (video_transition),
// and its frame count — so the seam doesn't show/render a phantom (the deep clone already
// carried these onto the second half, which correctly keeps them).
s.frames = cut; s.transition_to_next = ""; s.transition_frames = null; s.video_transition = "";
if (playsFromSourceMedia(s)) {
const srcIn = s.source_in || 0;
const totalDur = s.source_dur != null ? s.source_dur : (frames / effFps);