nodes/olivv-cs-ComfyUI-FunPack
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(editor): the H3 gain dials were visible in learned mode too

Browse Source 
dependsVals (an array) is the Studio-field convention; sampler knobs read a
singular dependsValue and fall back to a plain truthy check when it's absent —
which a non-empty combo string always passes. All five dials showed regardless
of h3_gain_mode. Switched to dependsValue: "manual" to match the mechanism
that's actually there.
This commit is contained in:
digital-garbage
2026-08-25 22:05:43 +03:00
parent 0fced8cb63
commit 67cfa858cb
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
movie_editor/frontend/engine_settings.js
+5 -5
View File
@@ -305,20 +305,20 @@
hint: "MiniMax H3 only. 'learned' takes the five render strengths from your ratings and ignores the dials below. 'manual' uses the dials as typed.",
detail: "Learned needs the Refiner's 'Rating-learned render gains (H3)' left on — with it off, or before anything is rated, learned mode renders at the model's trained strengths and the dials still do nothing. Switch to manual to drive them yourself." },
{ name: "h3_gain_video", label: "Write gain · picture", kind: "float", default: 1.0, min: 0.0, max: 2.0, step: 0.01,
dependsOn: "h3_gain_mode", dependsVals: ["manual"],
dependsOn: "h3_gain_mode", dependsValue: "manual",
hint: "How hard each block writes into the picture rows. Below 1.0 is a calmer, less-committed image; above pushes harder. 1.0 = untouched. Free.",
detail: "Keyframe pins and reference images ride the same modality tag as the video, so this moves the anchor with it." },
{ name: "h3_gain_prompt", label: "Write gain · prompt", kind: "float", default: 1.0, min: 0.0, max: 2.0, step: 0.01,
dependsOn: "h3_gain_mode", dependsVals: ["manual"],
dependsOn: "h3_gain_mode", dependsValue: "manual",
hint: "How much each block rewrites the prompt as it draws. Lower it when a scene slowly stops matching what you asked for; 0.0 freezes the text at its encoded value. 1.0 = untouched. Free." },
{ name: "h3_gain_audio", label: "Write gain · soundtrack", kind: "float", default: 1.0, min: 0.0, max: 2.0, step: 0.01,
dependsOn: "h3_gain_mode", dependsVals: ["manual"],
dependsOn: "h3_gain_mode", dependsValue: "manual",
hint: "How hard each block writes into the audio rows. Below 1.0 builds the soundtrack more conservatively. 1.0 = untouched. Free." },
{ name: "h3_prompt_scale", label: "Prompt loudness", kind: "float", default: 1.0, min: 0.0, max: 2.0, step: 0.01,
dependsOn: "h3_gain_mode", dependsVals: ["manual"],
dependsOn: "h3_gain_mode", dependsValue: "manual",
hint: "How loudly the prompt is READ, as opposed to how much it is rewritten. Above 1.0 it is harder to ignore; below, the anchor or the reference gets more say. 1.0 = untouched. Free." },
{ name: "h3_taste_bias", label: "Taste push", kind: "float", default: 0.0, min: -0.30, max: 0.30, step: 0.01,
dependsOn: "h3_gain_mode", dependsVals: ["manual"],
dependsOn: "h3_gain_mode", dependsValue: "manual",
hint: "Pushes the prompt toward what you have rated well. Negative pushes away from it. Needs at least 3 liked runs on the refinement key; without them it does nothing and says so. 0.0 = off. Free.",
detail: "The Refiner already steers along your liked direction, but on H3 that edit is mixed and renormalized by the token refiner before the model reads it. This adds the same direction after the refiner, where it lands as sent. Measured as a fraction of a typical prompt row, so one value means the same thing on every prompt." },
{ name: "segmented_detailing", label: "Segmented detailing (region refine)", kind: "bool", default: false,