nodes/olivv-cs-ComfyUI-FunPack
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ui): a run already finished at reload is recorded at once instead of locking the page; recovered length uses the shared-frame rule; H3 second pass gets a fresh seed too

Browse Source 
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
digital-garbage
2026-10-03 20:02:46 +03:00
co-authored by Claude Sonnet 5.5
parent c046fa02c4
commit 69c678e97e
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/ui/features/generate/index.js
+8 -5
View File
@@ -24,7 +24,7 @@ export default {
const record = (pid, unit, image, frames) => p.project && p.project.id === pid && p.edit((pr) => {
const group = pr.scenes.filter((s) => genUnitId(s) === unit);
if (!group.length) return false;
const secs = frames ? frames / effFps(group[0], pr) : group.reduce((t, s) => t + effFrames(s, pr) / effFps(s, pr), 0); // as queued, not as the project reads now
const secs = (frames || group.reduce((t, s) => t + effFrames(s, pr), 0) - (group.length - 1)) / effFps(group[0], pr); // as queued, not as the project reads now
const media = { filename: image.filename, subfolder: image.subfolder || "", type: image.type || "output" };
group.forEach((s) => {
(pr.scene_renders ||= {})[s.id] = renderFor(s, pr, media, secs);
@@ -88,13 +88,16 @@ export default {
const claim = ({ sceneId, projectId }) => {
const sc = p.project && p.project.id === projectId && p.project.scenes.find((s) => s.id === sceneId);
if (!sc) return false;
const unit = genUnitId(sc), done = g.waitForTerminal();
busy = true; draw(); // Stop works on it, Generate waits
done.then((end) => {
const unit = genUnitId(sc);
const finish = (end) => {
const im = g.run.state.images;
if (end === g.DONE && im.length) record(projectId, unit, im[im.length - 1]);
busy = false; draw();
});
};
const now = g.run.state.phase; // a run that ended while the page reloaded is over already: nothing to wait for
if (now === g.DONE || now === g.FAILED || now === g.CANCELLED) { finish(now); return true; }
busy = true; draw(); // Stop works on it, Generate waits
g.waitForTerminal().then(finish);
return true;
};
// The page may know the run before it has opened a project: wait for the project, then claim or give up.
modules/models/minimax_h3/pipeline.py
+1
View File
@@ -177,6 +177,7 @@ def h3_reference_to_video_second_pass():
{"id": "pass2_sigmas", "group": "Second pass", "node": "ManualSigmas",
"inputs": {"sigmas": "0.4, 0.3, 0.2, 0.1, 0.0"}},
{"id": "pass2", "group": "Second pass", "node": "FunPackSampler",
"roles": [{"at": "generation.seed", "input": "seed", "label": "Seed"}],
"inputs": {
"model": ["markup_apply", 0], "positive": ["resample", 1],
"negative": ["resample", 2], "latent": ["resample", 0],