fix: readiness points a missing FunPack node at Settings > Modules; CHANGELOG states that preset nodes are required by their preset (attacker round 25)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Sonnet 5.5
parent
892a49afc2
commit
e0c960313d
+2
-1
@@ -2,7 +2,7 @@
|
||||
|
||||
## [5.0.0] "Cunning Cranberry" - unreleased
|
||||
|
||||
A rewrite from scratch, not an update of 4.x. Same idea (a studio for video inside ComfyUI that learns from your ratings), new architecture: every feature is a module that announces itself, so a feature cannot be forgotten in the UI, a wire cannot be missed, and a failing feature module is left out while the run carries on. 4.x projects are not imported; see "Not carried over".
|
||||
A rewrite from scratch, not an update of 4.x. Same idea (a studio for video inside ComfyUI that learns from your ratings), new architecture: every feature is a module that announces itself, so a feature cannot be forgotten in the UI, a wire cannot be missed, and a failing optional feature module is left out while the run carries on. 4.x projects are not imported; see "Not carried over".
|
||||
|
||||
### What it is
|
||||
|
||||
@@ -38,6 +38,7 @@ A rewrite from scratch, not an update of 4.x. Same idea (a studio for video insi
|
||||
- **`.gguf` text encoders** need the ComfyUI-GGUF node pack and work only for architectures it understands; otherwise they are refused with a message. Gemma 4 `.gguf` does not work; a loader for it may come later.
|
||||
- **H3 start frame**: in the H3 preset the scene picture sets the video's shape only; a start frame is not part of it.
|
||||
- **H3 second pass** is held back: not offered until verified.
|
||||
- The ready-made pipelines (presets) name some FunPack nodes directly: Save video, Cut opening, Shot camera, Prompt markup, Negative erase, Enhance prompt, Load media, Identity transfer. If the module behind one of them fails to load, Generate says which node is missing and refuses until you delete that card in Models & Pipeline or fix the module.
|
||||
- Turning some modules on switches the model compiler off for the run, which costs sampling time.
|
||||
|
||||
### Docs
|
||||
|
||||
+7
-2
@@ -101,8 +101,13 @@ def pipelines(presets: Iterable[dict], installed: Callable[[str], bool]) -> List
|
||||
out = []
|
||||
for preset in presets:
|
||||
missing = sorted({s["node"] for s in preset.get("slots", []) if not installed(s["node"])})
|
||||
if missing:
|
||||
out.append(row("warn", f"“{preset.get('title') or preset.get('id')}” needs nodes that are not installed: {', '.join(missing)}. Install the pack that provides them (Settings ▸ Custom Nodes)."))
|
||||
ours = [n for n in missing if n.startswith("FunPack")] # this pack's own nodes: their module did not load
|
||||
theirs = [n for n in missing if n not in ours]
|
||||
title = preset.get("title") or preset.get("id")
|
||||
if theirs:
|
||||
out.append(row("warn", f"“{title}” needs nodes that are not installed: {', '.join(theirs)}. Install the pack that provides them (Settings ▸ Custom Nodes)."))
|
||||
if ours:
|
||||
out.append(row("warn", f"“{title}” needs FunPack's own {', '.join(ours)}, but the module behind it did not load. See Settings ▸ Modules for why."))
|
||||
return out or [row("ok", "Every starting point's nodes are installed")]
|
||||
|
||||
|
||||
|
||||
@@ -66,3 +66,12 @@ def test_the_blackwell_xformers_warning_follows_whether_xformers_is_on_not_insta
|
||||
for on, warned in ((True, True), (False, False)):
|
||||
monkeypatch.setattr(r, "xformers_on", lambda: on)
|
||||
assert any("xformers" in x["text"] for x in r.machine()) is warned
|
||||
|
||||
|
||||
def test_a_funpack_node_that_is_missing_points_at_the_modules_page_not_at_another_pack():
|
||||
from core import readiness
|
||||
rows = readiness.pipelines([{"id": "p", "title": "P", "slots": [{"node": "FunPackCutOpening"}, {"node": "ImageTransformKJ"}]}],
|
||||
installed=lambda n: False)
|
||||
text = " | ".join(r["text"] for r in rows)
|
||||
assert "FunPackCutOpening" in text and "Settings ▸ Modules" in text
|
||||
assert "ImageTransformKJ" in text and "Custom Nodes" in text
|
||||
|
||||
Reference in New Issue
Block a user