digital-garbageandClaude Sonnet 5
61a4817460
Round 3's review found the enumeration approach (patchStore()'s blocked list) was still incomplete, and worse, live rather than dormant: keyboard shortcuts (Delete/Backspace/S) bypass the tour's click-blocking backdrop entirely, since CSS pointer-events does nothing to a window-level keydown listener. timeline.js's shortcut handler calls removeSelectedScenes(), removeAudioTrack(), removeSelectedOverlay(), and splitScene() -- none of them in the blocked list -- and every one ends in scheduleSave(), whose setTimeout calls the closure-scoped commit() directly, reaching a real, unmocked PUT /funpack/api/projects/<id>. tour-s1 is pre-selected from the moment the tour boots, so pressing Delete at any point immediately triggers this -- no click needed, no specific step required. The blocked-list pattern (three rounds of fixes: parsed.scenes crash, syncFromPreview, saveClipToMediaBin) was closing this one caller at a time and kept finding another. Fixed at the root instead: every mutating path in store.js funnels through the single closure-scoped commit() function before it can reach the network, so that's the one place a tour-mode guard covers every current AND future caller by construction, without needing tour.js to know the name of anything that might call it. Verified live: dispatched a real Delete keydown during the tour with tour-s1 selected (the default boot state) -- the scene still gets removed locally (harmless, it's fake demo data), but zero requests to /api/projects appear in the network log across the full debounce window after the fix, versus a real PUT before it. Confirmed the guard is a no-op outside tour mode (window.__FUNPACK_TOUR__ is false there) and the full 16-step tour sequence still completes with zero thrown errors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ComfyUI-FunPack v5 — "Cunning Cranberry"
FunPack v4.0.0 is going to be the latest release of classic FunPack. Next update is another milestone update, or shall I say, a full rework.
Maintenance of current FunPack became a mess — forgetting to add or remove buttons from/to UI, finding functions that don't do anything but still present in the code absolutely randomly, trying to keep the UI neat while it has no strict boundaries on how it should look like, and of course — making it easy for users to understand how FunPack operates and how you can operate it — this is all time, money and token-consuming.
General idea behind the FunPack v5 rework is writing it from scratch, with a new architecture where a feature can't be forgotten, where a wire can't be missed, where one failing module never stops whole process from executing. Loaders and features would tell the UI by themselves what sorts of inputs they need and where to put it — and UI will compose them according to design guidelines it would have. Samplers would become independent from features — if a feature is available and enabled, sampler would call it. If it's not — it gets skipped and doesn't even appear in the UI so it won't confuse you.
Most of this comes from a FunUI backend draft that got shelved after understanding on how much time has to be invested into polishing it. Without a community support and wide usage it would become another dead project only one person in the world needs but no one else.
Come to think of it, FunPack already became something alike, with an exception — this project is more than alive, and while I can, I will support it.
Final goal is to make FunPack an ultimate answer for a novice's question "I don't know how to generate — what do I install and how do I start?" and for a professional's question "I need a UI with all the cutting edge techniques available on day 0 — which one?"
Preparation for the v5 had started.
FunPack v5.0 "Cunning Cranberry" — coming fall 2026.
This branch is a clean start. Classic FunPack lives on main.