digital-garbage
6371c4ad48
Fourth off the port list. Users do not open devtools, and "it did not work" with nothing to read is where a bug report dies -- especially on a rented box behind a tunnel, where the terminal that has the answer is not on this desk. Read from ComfyUI's own log FILE rather than from a buffer in this process. v4 kept both and its own comment says why the file is the half that matters: a crash and restart empties an in-memory buffer, and the lines from before the crash are exactly the ones worth reading. So this is the smaller half and the more useful one. Three things the panel refuses to do, each because of what a log is FOR: * It does not redraw while text is being selected. Copying a stack trace is the one thing anybody opens a log to do, and a panel that repaints under the drag makes it impossible. * It keeps the last lines when the server stops answering. The most interesting thing a log can say is that ComfyUI just died, and replacing the lines from just before it went with the error that says it is gone throws away the only evidence of why. * No log file is an ANSWER, with the reason and where to look instead. An empty list reads as a quiet log, and the difference matters precisely when somebody opened the panel because something else already broke.
85 lines
3.1 KiB
JavaScript
85 lines
3.1 KiB
JavaScript
// ComfyUI's log, in the app.
|
|
//
|
|
// Users do not open devtools. "It did not work" with nothing to read is where a
|
|
// bug report dies, and the one place the reason is written down is a terminal
|
|
// they may not even be able to see -- a rented box behind a tunnel has no
|
|
// terminal on this desk at all.
|
|
//
|
|
// It polls only while open, and it stops polling while you are selecting text:
|
|
// a panel that redraws under a drag makes copying a stack trace impossible,
|
|
// which is the single thing anybody opens a log to do.
|
|
|
|
import { composer } from "../composer/composer.js";
|
|
|
|
const EVERY = 2000;
|
|
|
|
export function open({ poll = EVERY } = {}) {
|
|
let window_ = null;
|
|
let timer = null;
|
|
let follow = true; // stick to the end until the user scrolls off it
|
|
let last = "";
|
|
|
|
const view = composer.code.block({ text: "Reading…" });
|
|
const body = composer.region.stack({ gap: "sm", fill: true, children: [view] });
|
|
|
|
const selecting = () => {
|
|
const sel = document.getSelection();
|
|
return sel && !sel.isCollapsed && view.node.contains(sel.anchorNode);
|
|
};
|
|
|
|
// Following the end is the default and stops being it the moment someone
|
|
// scrolls up -- otherwise reading anything older than two seconds is a fight.
|
|
view.node.addEventListener("scroll", () => {
|
|
const room = view.node.scrollHeight - view.node.scrollTop - view.node.clientHeight;
|
|
follow = room < 40;
|
|
});
|
|
|
|
async function refresh() {
|
|
if (selecting()) return; // never redraw under a drag
|
|
try {
|
|
const res = await fetch("/funpack/api/log?limit=600", { cache: "no-store" });
|
|
const payload = await res.json().catch(() => ({}));
|
|
const text = (payload.lines || []).join("\n")
|
|
|| payload.detail
|
|
|| "Nothing in the log yet.";
|
|
if (text !== last) {
|
|
last = text;
|
|
view.setText(text);
|
|
if (follow) view.node.scrollTop = view.node.scrollHeight;
|
|
}
|
|
if (window_) window_.setFooter({ note: payload.path || "", actions: footer() });
|
|
} catch (err) {
|
|
// The server being gone is the most interesting thing a log can say, so it
|
|
// is said -- and the lines already on screen are kept, because they are
|
|
// the ones from just before it went.
|
|
if (window_) {
|
|
window_.setFooter({ note: `Cannot reach ComfyUI: ${err.message}`, actions: footer() });
|
|
}
|
|
}
|
|
}
|
|
|
|
const footer = () => [
|
|
composer.button.md({
|
|
label: "Copy", onClick: () => {
|
|
// Selecting a thousand lines by hand is the other reason this is hard to
|
|
// get out of a log panel.
|
|
if (navigator.clipboard) navigator.clipboard.writeText(last).catch(() => {});
|
|
},
|
|
}),
|
|
composer.button.md({ label: "Close", tone: "primary",
|
|
onClick: () => window_ && window_.close("done") }),
|
|
];
|
|
|
|
window_ = composer.modal.generic({
|
|
title: "ComfyUI log",
|
|
subtitle: "What the server printed. Newest at the bottom.",
|
|
size: "xl",
|
|
body,
|
|
onClose: () => { clearInterval(timer); timer = null; window_ = null; },
|
|
});
|
|
window_.setFooter({ actions: footer() });
|
|
refresh();
|
|
timer = setInterval(refresh, poll);
|
|
return window_;
|
|
}
|