digital-garbageandClaude Sonnet 5
cd1d07d96c
Round 4's review confirmed the commit() guard genuinely closes every project-save path (keyboard shortcuts included), but caught the fix's own comment overreaching: "every mutating path in this module funnels through here" is false. store.js's shortcut/category/transition CRUD functions (saveShortcut, deleteShortcut, addCategory, importShortcuts, clearShortcuts, saveTransition, deleteTransition, importTransitions, clearTransitions) each call their own real, unmocked API.* endpoint directly and never touch commit() at all -- a second, separate funnel the guard doesn't cover. Currently dormant (no Settings > Shortcuts panel is wired up in v5 yet, confirmed by grep -- these functions have no caller anywhere outside store.js/api.js today), same shape as the saveClipToMediaBin landmine rounds 2-3 already closed pre-emptively rather than waiting for it to go live. These write GLOBAL state (the on-disk shortcut/transition library), not sandboxed per-project state like everything commit() guards, so if left open they'd be worse than a stray project PUT once a Shortcuts UI ships. Fixed with the same block-list pattern, and corrected both comments (store.js's commit() guard, tour.js's blocklist) to state their actual scope instead of the overclaim. Verified live: all nine now return the block toast instead of reaching Store's real implementation; full tour sequence still completes with zero thrown errors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ComfyUI-FunPack v5 — "Cunning Cranberry"
FunPack v4.0.0 is going to be the latest release of classic FunPack. Next update is another milestone update, or shall I say, a full rework.
Maintenance of current FunPack became a mess — forgetting to add or remove buttons from/to UI, finding functions that don't do anything but still present in the code absolutely randomly, trying to keep the UI neat while it has no strict boundaries on how it should look like, and of course — making it easy for users to understand how FunPack operates and how you can operate it — this is all time, money and token-consuming.
General idea behind the FunPack v5 rework is writing it from scratch, with a new architecture where a feature can't be forgotten, where a wire can't be missed, where one failing module never stops whole process from executing. Loaders and features would tell the UI by themselves what sorts of inputs they need and where to put it — and UI will compose them according to design guidelines it would have. Samplers would become independent from features — if a feature is available and enabled, sampler would call it. If it's not — it gets skipped and doesn't even appear in the UI so it won't confuse you.
Most of this comes from a FunUI backend draft that got shelved after understanding on how much time has to be invested into polishing it. Without a community support and wide usage it would become another dead project only one person in the world needs but no one else.
Come to think of it, FunPack already became something alike, with an exception — this project is more than alive, and while I can, I will support it.
Final goal is to make FunPack an ultimate answer for a novice's question "I don't know how to generate — what do I install and how do I start?" and for a professional's question "I need a UI with all the cutting edge techniques available on day 0 — which one?"
Preparation for the v5 had started.
FunPack v5.0 "Cunning Cranberry" — coming fall 2026.
This branch is a clean start. Classic FunPack lives on main.