digital-garbageandClaude Sonnet 5 ecbdc42785 fix: tour -- restart mock was reloading the real page, plus a stray player fetch
Round 9's module-definition sweep came back clean (the four standalone
modules found in rounds 5/7/8 are all still correctly covered, and no
fifth exists) -- but it caught two real bugs my own round-8 live
verification missed by not waiting long enough:

- Both restartComfy() implementations call FunPackRestart.waitForReload()
  after API.restart() resolves. That function polls API.health() starting
  3.5s later and calls location.reload() once it reports ok -- and
  API.health is ALREADY mocked to ok:true for the Settings About panel's
  own unrelated reasons, so the very first poll after a restart click
  reloads the real page mid-tour, silently resetting all tour progress.
  Nothing actually restarted, so there's nothing to wait for -- fixed by
  short-circuiting waitForReload() in tour mode instead of polling toward
  a reload.
- demoProject() pointed a fake scene_renders entry at a real-shaped
  ComfyUI /view URL for a file that doesn't exist. Since bootstrap()
  notifies immediately on tour start, player.js's render() (a plain Store
  subscriber, never blocked or mocked) picks it up and issues a real GET,
  then a real HEAD retry, against the live backend -- zero clicks, always
  404s, but still a genuine unmocked reach into the real install. Fixed at
  the source instead of patching player.js's internals: an always-
  unrendered demo scene is an honest trade-off the tour's own FAQ text
  already accounts for.

Verified live: clicked both restartComfy implementations, waited the full
5s past the 3.5s poll delay this time (my round-8 verification hadn't
waited long enough to catch this) -- confirmed no reload, still on
?mode=tour; confirmed zero /view?filename= requests; full tour sequence
still completes cleanly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-09-16 00:48:40 +03:00
2026-08-27 16:25:34 +03:00
2026-08-27 16:25:34 +03:00
2026-08-27 16:25:34 +03:00

ComfyUI-FunPack v5 — "Cunning Cranberry"

FunPack v4.0.0 is going to be the latest release of classic FunPack. Next update is another milestone update, or shall I say, a full rework.

Maintenance of current FunPack became a mess — forgetting to add or remove buttons from/to UI, finding functions that don't do anything but still present in the code absolutely randomly, trying to keep the UI neat while it has no strict boundaries on how it should look like, and of course — making it easy for users to understand how FunPack operates and how you can operate it — this is all time, money and token-consuming.

General idea behind the FunPack v5 rework is writing it from scratch, with a new architecture where a feature can't be forgotten, where a wire can't be missed, where one failing module never stops whole process from executing. Loaders and features would tell the UI by themselves what sorts of inputs they need and where to put it — and UI will compose them according to design guidelines it would have. Samplers would become independent from features — if a feature is available and enabled, sampler would call it. If it's not — it gets skipped and doesn't even appear in the UI so it won't confuse you.

Most of this comes from a FunUI backend draft that got shelved after understanding on how much time has to be invested into polishing it. Without a community support and wide usage it would become another dead project only one person in the world needs but no one else.

Come to think of it, FunPack already became something alike, with an exception — this project is more than alive, and while I can, I will support it.

Final goal is to make FunPack an ultimate answer for a novice's question "I don't know how to generate — what do I install and how do I start?" and for a professional's question "I need a UI with all the cutting edge techniques available on day 0 — which one?"

Preparation for the v5 had started.

FunPack v5.0 "Cunning Cranberry" — coming fall 2026.


This branch is a clean start. Classic FunPack lives on main.

S
Description
No description provided
Readme GPL-3.0
23 MiB
Languages
Python 64.4%
JavaScript 32.7%
CSS 2.8%