- Changed from 'Completely resolves' to 'Significantly improves'
- Added caveat about potential edge cases
- Encourages users to report if issues persist
- More honest and transparent communication
- Reported by @recursionlaplace-eng
- Problem: Re-executing workflows with multiple LoRAs could result in LoRAs not being applied
- Root cause: Shallow comparison logic failed to detect when LoRA reapplication was needed
- Solution: Implemented deep comparison with explicit checks for None, length, and element-by-element comparison
- Technical details:
* Explicit None check ensures initial state detection
* Length comparison detects LoRA addition/removal
* Element-by-element comparison detects path/strength/order changes
* Early break optimization for efficiency
* Robust against reference sharing and shallow copy issues
- Testing: Comprehensive test suite validates all detection scenarios
- Impact: Ensures consistent LoRA application across multiple workflow executions
- Add clear note that .bat files are Windows-only
- Direct macOS and Linux users to Manual Installation section
- Add 'Platform: Windows only' to both installer descriptions
- Improve cross-platform user experience by setting proper expectations
- Change 'Regular ComfyUI Installations' to 'ComfyUI Installations with Global Python Environment'
- Change 'Regular ComfyUI' to 'Global Python Environment' in script details
- Clarify that the distinction is about Python environment, not ComfyUI type
- Acknowledge that portable ComfyUI with embedded Python is actually more common
- Improve accuracy of installation script descriptions
- Acknowledge @vvhitevvizard's crucial suggestion for portable ComfyUI support
- Highlight the importance of embedded Python detection feature
- Recognize that without this suggestion, portable ComfyUI users would not have been able to use this LoRA loader
- Add Issue #10 to the Features section with proper attribution
- Add comprehensive explanation of both installation scripts
- Clearly distinguish between regular and portable ComfyUI installations
- Document Python environment requirements for each script
- Explain automatic detection mechanisms for embedded Python
- Detail folder name independence and path detection
- Provide clear usage guidelines for each installation type
- Address user feedback about insufficient documentation
- Add install_qwen_lora_portable.bat for embedded Python environments
- Automatically detects python_embeded folder in multiple possible locations
- Works with any ComfyUI folder name (not just 'ComfyUI')
- Supports both standard and portable ComfyUI structures:
- Pattern 1: ComfyUI/python_embeded/python.exe
- Pattern 2: [ParentFolder]/python_embeded/python.exe
- Update README.md with installation options for both regular and portable installations
- Addresses Issue #10 suggestion for portable ComfyUI compatibility
- Tested successfully on actual ComfyUI environment
- Fixed intermittent ModuleNotFoundError: No module named 'wrappers.qwenimage'
- Root cause: Module-level sys.path setup insufficient in all execution contexts
- Solution: Implemented importlib.util-based dynamic import within method execution
- Each method now dynamically imports using file paths at execution time
- Completely bypasses Python's import mechanism for 100% reliability
- No dependency on sys.path state or module loading order
- Works in all ComfyUI execution scenarios
- Updated README.md with comprehensive v1.5.2 documentation
This fix ensures the LoRA loader works reliably regardless of:
- Python module cache state
- ComfyUI execution context variations
- sys.path configuration timing
- Module loading order
Special thanks to community for bug reports and patience during troubleshooting.
- Add Special Thanks section recognizing @mcv1234's solution
- Credit @mcv1234 for providing the technical solution
- Emphasize community contribution in changelog
- Update Features section to acknowledge user's solution
- Show proper attribution for the path detection improvement
- Recognize that this fix was made possible by community feedback
- Add NunchakuQwenImageLoraLoader for single LoRA loading
- Add NunchakuQwenImageLoraStack for multiple LoRA stacking
- Add ComfyQwenImageWrapper for LoRA composition
- Add dynamic VRAM management with CPU offloading
- Add JavaScript UI for dynamic LoRA count control
- Add comprehensive LoRA application logic
- Support for Nunchaku Qwen Image models
- Integration with ComfyUI-nunchaku plugin
- Requires modification of official ComfyUI-nunchaku plugin
Your Name